From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3473C433E0 for ; Wed, 27 May 2020 13:52:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9B1522078C for ; Wed, 27 May 2020 13:52:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="IQd9QRIu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388906AbgE0NwK (ORCPT ); Wed, 27 May 2020 09:52:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388516AbgE0NwJ (ORCPT ); Wed, 27 May 2020 09:52:09 -0400 Received: from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com [IPv6:2607:f8b0:4864:20::1043]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12689C08C5C3 for ; Wed, 27 May 2020 06:52:09 -0700 (PDT) Received: by mail-pj1-x1043.google.com with SMTP id 5so1549304pjd.0 for ; Wed, 27 May 2020 06:52:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=sVOrxsk18BnSFATyAjPbeo6+7yMbRqTwIElwDUYrAFk=; b=IQd9QRIugzIzBpTvp3+gDmqldfXigO2E49gsEa4gWjkW8zQ7okCePzzME85lMseCYp C6UogWhM76FwGK5GWiG8mRjoqMxQAiVMmmfU32mB1clNfA4oHsd9jNVbdkKq9iRLaZ6o /GSx8wknomZEweg/pRNTs5AEyhz2TlPsVfIh1FVWAsub3p7gsfYfKsWEW0GjuGLOSeH3 JX/KrTERHguXCxqwKCC2l18gU5RD125PFLl4ooOSVZXxkfqWDt3XB8oULXtxbINGB7jy IZ+Ys2oL0/yBtqmoT9wOKg1LwOZXfABmxwNOY7WVGXRfz3jB/ahveiTxn+3ArAeBKNsp azNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=sVOrxsk18BnSFATyAjPbeo6+7yMbRqTwIElwDUYrAFk=; b=aPElxz3LaSWagxfHEwWpaljR/X6cHeHZ0PQCNu5c8gLoblJqgydwLNA2HA/7E0lCT5 mjOPzmS8+8Gm9j/FBIuSLyT3P02aF4h+7xi4bcTeAav8mv//Zb6Fx0Ive4folzYrholO riZlsx+LA1NwI6ogWxfVXlGIuCxwxVqRxvTULC5bXiBvfBZ65+XYfYOUJOp/Pe/ci2az BYlJn2mL9sgVtw6QTuoN1wipEbH0axp7M9Er3Iq/vUrLluT5Kw+/TmNcjSTo05OPjibs Yh0DJl0kadbnLVCUH3b9YmwJR5SpBJLU82craAhX3EHi8iRfRoYNP0w5ffx9ldFRTtgr Y/oA== X-Gm-Message-State: AOAM530IWgxTEowAa5nekDXv2hZFqXFsDB6+8aspc9/uYziElIKtXS3D 4LqTJtWhLX6M4r5uEe9oKLhhvQ== X-Google-Smtp-Source: ABdhPJyJEWrfFe5MlHVlgCY+nDX0MeA9yhMhsez39F2xUkBVmUD/N243xLXOBOeIAja47JbP7VfxPQ== X-Received: by 2002:a17:90a:2ac2:: with SMTP id i2mr5055611pjg.80.1590587528565; Wed, 27 May 2020 06:52:08 -0700 (PDT) Received: from [192.168.11.133] (li1566-229.members.linode.com. [139.162.86.229]) by smtp.gmail.com with ESMTPSA id s15sm2106775pgv.5.2020.05.27.06.51.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 May 2020 06:52:07 -0700 (PDT) Subject: Re: [PATCH 0/2] Introduce PCI_FIXUP_IOMMU To: Arnd Bergmann , Greg Kroah-Hartman Cc: Joerg Roedel , Bjorn Helgaas , Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , "Rafael J. Wysocki" , Len Brown , jean-philippe , Herbert Xu , kenneth-lee-2012@foxmail.com, Wangzhou , "linux-kernel@vger.kernel.org" , "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , "open list:IOMMU DRIVERS" , ACPI Devel Maling List , Linux ARM , linux-pci References: <1590493749-13823-1-git-send-email-zhangfei.gao@linaro.org> <20200527090007.GA179718@kroah.com> From: Zhangfei Gao Message-ID: Date: Wed, 27 May 2020 21:51:13 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/5/27 下午5:53, Arnd Bergmann wrote: > On Wed, May 27, 2020 at 11:00 AM Greg Kroah-Hartman > wrote: >> On Tue, May 26, 2020 at 07:49:07PM +0800, Zhangfei Gao wrote: >>> Some platform devices appear as PCI but are actually on the AMBA bus, >> Why would these devices not just show up on the AMBA bus and use all of >> that logic instead of being a PCI device and having to go through odd >> fixes like this? > There is a general move to having hardware be discoverable even with > ARM processors. Having on-chip devices be discoverable using PCI config > space is how x86 SoCs usually do it, and that is generally a good thing > as it means we don't need to describe them in DT > > I guess as the hardware designers are still learning about it, this is not > always done correctly. In general, we can also describe PCI devices on > DT and do fixups during the probing there, but I suspect that won't work > as easily using ACPI probing, so the fixup is keyed off the hardware ID, > again as is common for x86 on-chip devices. > > Yes, thanks Arnd :) In order to use pasid, io page fault has to be supported, either by PCI PRI feature (from pci device) or stall mode from smmu (platform device). Here is letting system know the platform device can support smmu stall mode, as a result support pasid. While stall is not a pci capability, so we use a fixup here. Thanks