Re: [RFC PATCH 5/5] mm: shmem: add anonymous share mTHP counters

[Baolin Wang <baolin.wang@linux.alibaba.com>]

On 2024/4/23 19:22, Lance Yang wrote:
> On Tue, Apr 23, 2024 at 5:46 PM Lance Yang <ioworker0@gmail.com> wrote:
>>
>> On 2024/4/23 09:17, Barry Song wrote:
>> [...]
>>>> diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h
>>>> index 26b6fa98d8ac..67b9c1acad31 100644
>>>> --- a/include/linux/huge_mm.h
>>>> +++ b/include/linux/huge_mm.h
>>>> @@ -270,6 +270,8 @@ enum mthp_stat_item {
>>>>           MTHP_STAT_ANON_SWPOUT,
>>>>           MTHP_STAT_ANON_SWPOUT_FALLBACK,
>>>>           MTHP_STAT_ANON_SWPIN_REFAULT,
>>>> +       MTHP_STAT_SHMEM_ANON_ALLOC,
>>>> +       MTHP_STAT_SHMEM_ANON_ALLOC_FALLBACK,
> 
> Seems like you forgot to add the FILE_FALLBACK_CHARGE counter
> in this patch :)
> 
> IIUC, you've excluded the THP_FILE_FALLBACK_CHARGE counter
> for PTE-mapped mTHP that size < PMD in patch3.

Yes, will add in next version.