From: Andrew Lunn <andrew@lunn.ch>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: Oleksij Rempel <o.rempel@pengutronix.de>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v4 2/3] phy: Add Open Alliance helpers for the PHY framework
Date: Sun, 11 Aug 2024 17:33:30 +0200 [thread overview]
Message-ID: <ec9f6d52-b035-47f8-8ea5-afb50030406a@lunn.ch> (raw)
In-Reply-To: <ZriCqClUc/Yd0uMK@shell.armlinux.org.uk>
On Sun, Aug 11, 2024 at 10:21:44AM +0100, Russell King (Oracle) wrote:
> On Sun, Aug 11, 2024 at 07:20:04AM +0200, Oleksij Rempel wrote:
> > diff --git a/drivers/net/phy/Makefile b/drivers/net/phy/Makefile
> > index 202ed7f450da6..e93dfec881c5d 100644
> > --- a/drivers/net/phy/Makefile
> > +++ b/drivers/net/phy/Makefile
> > @@ -23,6 +23,7 @@ obj-$(CONFIG_MDIO_DEVRES) += mdio_devres.o
> > libphy-$(CONFIG_SWPHY) += swphy.o
> > libphy-$(CONFIG_LED_TRIGGER_PHY) += phy_led_triggers.o
> >
> > +obj-$(CONFIG_OPEN_ALLIANCE_HELPERS) += open_alliance_helpers.o
>
> I was thinking more
> libphy-$(CONFIG_OPEN_ALLIANCE_HELPERS) += open_alliance_helpers.o
>
> rather than a potentially separate module.
>
> If it is going to end up a separate module, then it needs its own
> MODULE_LICENSE, MODULE_DESCRIPTION, etc.
I'm happy either way.
Andrew
next prev parent reply other threads:[~2024-08-11 15:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-11 5:20 [PATCH net-next v4 1/3] ethtool: Add new result codes for TDR diagnostics Oleksij Rempel
2024-08-11 5:20 ` [PATCH net-next v4 2/3] phy: Add Open Alliance helpers for the PHY framework Oleksij Rempel
2024-08-11 9:21 ` Russell King (Oracle)
2024-08-11 15:33 ` Andrew Lunn [this message]
2024-08-11 5:20 ` [PATCH net-next v4 3/3] net: phy: dp83tg720: Add cable testing support Oleksij Rempel
2024-08-11 15:32 ` Andrew Lunn
2024-08-11 15:29 ` [PATCH net-next v4 1/3] ethtool: Add new result codes for TDR diagnostics Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec9f6d52-b035-47f8-8ea5-afb50030406a@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®