From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 313AE33C50D for ; Mon, 25 May 2026 05:51:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779688271; cv=none; b=PXQNXI2U2ZbScXen172L6hUYgzx7p+nGGptlHMKYQNkZDR7Qj3bC9urlduw+8Gu1ECRI0bpBUV/tdYXX5ACX0JcEpjqQc1YDCbNqJVrTK1wZODFi24fjFM6Niz9zGqTCqEgq7i2Gkr40hrsbA9JaFGvGVrsDn5S+VVMdbQP/rPw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779688271; c=relaxed/simple; bh=vl/IvMjHQaPAG9h0CsmqVgUy8/dTJ2JHEUpBkVfgozE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Rkcx6gzoDsTb2j8oQFN29F08aT/R/EceufuNYObH23VDYNliobdjP52ukRwnpsMZKW3iJ4oCzuMkCbk1hnhbi057q1BkGiV/fGnz1NNy0ORIaBsMlZ10Oejvnju8/aqzWrfP5yco9ZjIubuQ6xQZE5maDZN/zo82jxEGXLShKII= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WuUsyAIW; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YabP8PU+; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WuUsyAIW"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YabP8PU+" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64ONuwXH961954 for ; Mon, 25 May 2026 05:51:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= c0NrB06rrKegh0h82YKmeB1//5EOvAGt2u2s0wAxFrA=; b=WuUsyAIWUlyQijQk 8xCNHknZt3TjwD55WSqnMX1np2l7sh+fHzt4zgIlDmxQK/fvVpOohPz6ojnzDERH sz8+MASuZZKwlTLiRJA1ApN2ht+aWkRUV+upRwABFYLkVFk7C/odOhX9kcxdolxO 8TSxJHA9vAPr4qDpG5uY/kViS06gf3AcUro/OJi+zEya2nHJv1uYgO8d367JKa56 zKKxL/2hSLus/0luPi9VUs8kLLFJ+kFIoYw9euFE+LTEj7acavFD5Y35BGbNdevE q3AxveC5rtonLlNfU+gq/rYoxXABihQSoxjrWoKk6ajyvjvz9fV+Itq8hlsbfCzw wSX1/Q== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eb4f3d318-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 25 May 2026 05:51:09 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2b458add85aso101568875ad.2 for ; Sun, 24 May 2026 22:51:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779688269; x=1780293069; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=c0NrB06rrKegh0h82YKmeB1//5EOvAGt2u2s0wAxFrA=; b=YabP8PU+vQmGuLw843AvYJRsknPKbPtbTDz8MdiatTfLU7jD7MvbGrnk/w2nk9tK0g 8h/GbDfk0cYHRmqrI6iPOHc5TjWSsK+3WbdiVNPzeqZQdEEefoZWr2pkixR1ISgH6wFP 8bDcGOHDj5Zxh2URrUf9W2qe+Tpmg0nXLb9R9NSURzfWvXSOe6KaWSwjrud1F4SQI+O2 DSoSzKL58C/9TzgIVYc/11KZAWQr3tLNQuAkn9hdtAbndh8gtTuJFrHTx4hhtuOgqqbd KCUJyB+GWV7eidIzohPHhUhtarkcxdoGqIwCeFgCb+2wpKMzbpWivLj0F+sro2dRc9Aw o4iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779688269; x=1780293069; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=c0NrB06rrKegh0h82YKmeB1//5EOvAGt2u2s0wAxFrA=; b=cLGYWQsmf/D2syTiAIAwgQI1LEhmqYxz9zvOjLCfIVUlMMj9Sne75DANT3Z7LpniF/ BIIrUPBMOycnKP7wZEaziWduIn64M4KCGhQZsQedFdBG8vRTfbnKE4rRLG+fVUNL866m xwh6BWBXN/0ErJU6ET4Qe8UNFckITXwrxxNCFgFi/Tp5Z8FdkxtBVfi38CPji4WHtxfs 8ngxKN6VISsQqrnjeDa9gKzdQ8hRSISHPYziqtI+9EPh9ccJJ+iqEDcpYXJoNmIRAoG8 wQe5jZbKk76Fx7vZnEX+cLYdvaOyq7E5tzxLq1ROSVRqHP7+y1ghmIif8WMhOwnT6gP8 QIAw== X-Forwarded-Encrypted: i=1; AFNElJ/RPTcytokSPvC9EAFQ/c0ejuDLWeEFTfupGaoz7mG8Rqg7535gT+maYNqLvBs+KYCLZyaaQxDCudlxsOs=@vger.kernel.org X-Gm-Message-State: AOJu0Yzjl7HbYyV9Fzo2mbJirNHBj4HIjgetp1aQ31UejH7QLwpUJwbj UD+LvC6oWP9LIA2LdQe4PP22TTWg3w9nOqfz7W+7XXewsjh6E5pOVE3Z2tn8jouLwU3U1e8P4u9 BNdrDVuLNCgzOYxGZ10YtRe08j2O+NXoDB0P32EbmoVZ1DJTyY/14SOAtXneB9b3YVmw= X-Gm-Gg: Acq92OGGcM7HKu4eD6+alyxSXCOdURRCgVWYwQcfGg7xAmDSAic1mlk0DauVik3lywv Ae7kRGhcB3OFeHHzXgilcTj13q3pCq+k1BNA2VkmKWR4YXCAl8JS8M1PX2mbjkA4xl11oKTBTdB fQDHYUkJVg9qhzMl2DFntJhB+vCfyQmpkNq/4ZgU7TYsR6hn0YLOD/gcLN51tCppdrcVy7BdfZz HIPbc/xmX99E25omfO31ccSN1mD2Y/0cmO/+iVozrEDIycB9Z2kk8G7bQNvBBS+ktoTW16NXz2w 30bXeYqakhS6Rb0216HfPfpGSaEvXwqSxt5mhDh/zzT0PqSJ6YMSnJdYbTnGn6qp5lj57We3MPl DjWhHVaQvO+31JHH2MR+pkphnfEf/AzjHh7SRkDROKJHoazzu X-Received: by 2002:a17:903:350d:b0:2ae:826f:2c50 with SMTP id d9443c01a7336-2beb05d2054mr152233475ad.12.1779688268660; Sun, 24 May 2026 22:51:08 -0700 (PDT) X-Received: by 2002:a17:903:350d:b0:2ae:826f:2c50 with SMTP id d9443c01a7336-2beb05d2054mr152233085ad.12.1779688268163; Sun, 24 May 2026 22:51:08 -0700 (PDT) Received: from [10.217.216.23] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2beb58dba7bsm80743675ad.66.2026.05.24.22.51.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 24 May 2026 22:51:07 -0700 (PDT) Message-ID: Date: Mon, 25 May 2026 11:21:00 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 2/9] clk: qcom: gcc-msm8939: mark Venus core GDSCs as hardware controlled To: Erikas Bitovtas , Bryan O'Donoghue , Vikash Garodia , Dikshita Agarwal , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , =?UTF-8?Q?Andr=C3=A9_Apitzsch?= , Bjorn Andersson , Konrad Dybcio , Michael Turquette , Stephen Boyd , Brian Masney Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org References: <20260519-msm8939-venus-rfc-v8-0-542ec7557ebc@gmail.com> <20260519-msm8939-venus-rfc-v8-2-542ec7557ebc@gmail.com> <608dc53d-17a8-4230-9ebb-48a94bf03675@kernel.org> <6ae3a89c-f205-45c5-87c0-5550f78502d6@oss.qualcomm.com> <01f9a303-846a-4048-8115-c94b9b78078a@gmail.com> Content-Language: en-US From: Taniya Das In-Reply-To: <01f9a303-846a-4048-8115-c94b9b78078a@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: BCQZ1WvwksgOj8jvAdisG3k0vwgvmuzM X-Authority-Analysis: v=2.4 cv=WvYb99fv c=1 sm=1 tr=0 ts=6a13e34d cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=4fXVvXKQPWswVA94wWgA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTI1MDA1NSBTYWx0ZWRfX8WNMgQNfuSq0 45+Xq3GS/ZxyKNzRjutQyutEDJA1l0KQqOy6e6ZlFgfs73OtSDLZeIh0y21M90T9ObCqTK9I6VS YKW2Fde0qWsqFWOtMMOKzzxJyYDXPmQLVknaEc3qxI2knz4r/GqhkHoUqKS/8yzMKXAdQcgQbXa dcXD6iTfO7+pEmKdMyp2eaWlEJ+2k5TfbTEgjHsHwW9cAWN7Cux78qHhsktUbvDtYHjeQlP7Bfs GcSii2VKpqneIIYi3hrDvLfJM8f+Rnc8iVrcDrCrVP1eYNWckneCPViTxoNhJn5v2JOrD2B1169 Ks5XBr9tc29ibLA2I/Ob5qZKSkxmT98q4higzUhCt9NQ/KYWMT+ST9V5IrL14arPTbbpPqXZSMd uZypDWHEtCyVdZgClgaclIPpD5EBMF4d7tC2Ys74g1MIDz+9W5BD2KA4bCdycnLD2ivo4EJgog6 mkxs77yRl/Q+6FpeRqQ== X-Proofpoint-GUID: BCQZ1WvwksgOj8jvAdisG3k0vwgvmuzM X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-25_01,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 clxscore=1015 phishscore=0 adultscore=0 suspectscore=0 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605250055 On 5/22/2026 4:18 PM, Erikas Bitovtas wrote: >>>>   static struct clk_branch gcc_venus0_core0_vcodec0_clk = { >>>>       .halt_reg = 0x4c02c, >>>> +    .halt_check = BRANCH_HALT_SKIP, >> please use .halt_check = BRANCH_HALT >> > If I do that, the clock fails to power on on boot. > [ 20.324488] ------------[ cut here ]------------ > [ 20.324520] gcc_venus0_core0_vcodec0_clk status stuck at 'off' > [ 20.324663] WARNING: drivers/clk/qcom/clk-branch.c:88 at I am hoping the Venus driver has enabled the GDSC before requesting the clock enable. -- Thanks, Taniya Das