From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 786B0A59; Tue, 3 Dec 2024 03:04:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733195060; cv=none; b=vD3qW9pMdlvSi7xTRQ/Dow4QfgFkNZ+XJ29Rpuqv+s0gb11oBbg5AEyOSTwvuMUTtXQLZe/xr6NFw5M3hWiFjtQ65kSWqyRAMHCnxFd3AS0O1kwEc7H70Pr8WWwFbsuvnKjZlDPO5FenfO76UBzMeq+zzDrrmWHbRyJRZ5NgIfc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733195060; c=relaxed/simple; bh=ANTovGAcxlPO1ucIOTjsicYB3Ns+CZUVNLf4o9dhSlQ=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=LrRkLWBG5sAJncEfb5JvqiJQKOE73khjeYeCCJPUeXE1ldG53wIhay2OGYOpCCMzsiWSjRagQddwAaCQsWNQXvNDITFFspQ7onTvLLgRr0wn5Rb6jWk7U2xdfK99BXt9/lwUwNEqrVEjDu0iBfUzIT2PZreqJAyWr9Pq6YVwejw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=MnJUnGc8; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="MnJUnGc8" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4B2Id5bB022426; Tue, 3 Dec 2024 03:04:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= u4FFRI9PocAedoUX29Uk7maPjQQNDzrbRqz7FWjCFWw=; b=MnJUnGc8JwoF/bZh FRGMafI0m5R+wKoY0UQ0mU6RL3UuRC8oXkDMgxGrFavxoVKtd79ruAYZaHa7eXi2 Tc/OdBxFExMdCluyv/rj84461G8XAWl99IrppVCvX0qogJCcQ/ShtHUSLbi353U2 cILnOdKAcjGdxcAsa6M3mKvuL6KpaLdawIHSa52flxd5OCLTXfZq4Q4RMtqbVSM4 Cd9NWH3GKXQVtfrETLSR/4QzdYZi2ykJcOSHDBQ2zmyaro6SOxWZaJ+3u7Ab7vdq wWBJ/MtVGndm9KSFIfM/XWSnI4/BUESCCMBUlXcvBu2CTEHdXbkiuqfr6aEYYAMs gojt1A== Received: from nalasppmta01.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 437v07phy0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 03 Dec 2024 03:04:10 +0000 (GMT) Received: from nalasex01b.na.qualcomm.com (nalasex01b.na.qualcomm.com [10.47.209.197]) by NALASPPMTA01.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 4B33494t026685 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 3 Dec 2024 03:04:09 GMT Received: from [10.231.216.175] (10.80.80.8) by nalasex01b.na.qualcomm.com (10.47.209.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Mon, 2 Dec 2024 19:04:05 -0800 Message-ID: Date: Tue, 3 Dec 2024 11:04:02 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/4] dt-bindings: bluetooth: add 'qcom,product-variant' To: Dmitry Baryshkov CC: Marcel Holtmann , Luiz Augusto von Dentz , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , "Balakrishna Godavarthi" , Rocky Liao , , , , , , References: <20241120095428.1122935-1-quic_chejiang@quicinc.com> <20241120095428.1122935-2-quic_chejiang@quicinc.com> <454tdpuglu23nmxfqqesv42h5rk3vqiji7spo3naf2djqwojqt@6x3ram3lnlkq> <944fdc7f-313e-48b9-8917-370942d4f073@quicinc.com> Content-Language: en-US From: "Cheng Jiang (IOE)" In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01b.na.qualcomm.com (10.47.209.197) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: fpjY4RRrNY6f3cqPZwCXcx71ZQ9mVlwe X-Proofpoint-GUID: fpjY4RRrNY6f3cqPZwCXcx71ZQ9mVlwe X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 adultscore=0 mlxlogscore=999 bulkscore=0 suspectscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 spamscore=0 mlxscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412030024 Hi Dmitry, On 12/2/2024 11:14 PM, Dmitry Baryshkov wrote: > On Mon, 2 Dec 2024 at 16:25, Cheng Jiang (IOE) > wrote: >> >> >> >> On 12/2/2024 7:38 PM, Dmitry Baryshkov wrote: >>> On Mon, Dec 02, 2024 at 10:22:52AM +0800, Cheng Jiang (IOE) wrote: >>>> Hi Dmitry, >>>> >>>> On 11/30/2024 4:24 PM, Dmitry Baryshkov wrote: >>>>> On Sat, 30 Nov 2024 at 05:48, Cheng Jiang (IOE) >>>>> wrote: >>>>>> >>>>>> Hi Dmitry, >>>>>> >>>>>> On 11/21/2024 12:38 PM, Dmitry Baryshkov wrote: >>>>>>> On Thu, 21 Nov 2024 at 06:02, Cheng Jiang wrote: >>>>>>>> >>>>>>>> Hi Dmitry, >>>>>>>> >>>>>>>> On 11/20/2024 6:43 PM, Dmitry Baryshkov wrote: >>>>>>>>> On Wed, Nov 20, 2024 at 05:54:25PM +0800, Cheng Jiang wrote: >>>>>>>>>> Several Qualcomm projects will use the same Bluetooth chip, each >>>>>>>>>> focusing on different features. For instance, consumer projects >>>>>>>>>> prioritize the A2DP SRC feature, while IoT projects focus on the A2DP >>>>>>>>>> SINK feature, which may have more optimizations for coexistence when >>>>>>>>>> acting as a SINK. Due to the patch size, it is not feasible to include >>>>>>>>>> all features in a single firmware. >>>>>>>>>> >>>>>>>>>> Therefore, the 'product-variant' devicetree property is used to provide >>>>>>>>>> product information for the Bluetooth driver to load the appropriate >>>>>>>>>> firmware. >>>>>>>>>> >>>>>>>>>> If this property is not defined, the default firmware will be loaded, >>>>>>>>>> ensuring there are no backward compatibility issues with older >>>>>>>>>> devicetrees. >>>>>>>>>> >>>>>>>>>> The product-variant defines like this: >>>>>>>>>> 0 - 15 (16 bits) are product line specific definitions >>>>>>>>>> 16 - 23 (8 bits) are for the product line. >>>>>>>>>> 24 - 31 (8 bits) are reserved for future use, 0 currently >>>>>>>>> >>>>>>>>> Please use text strings instead of encoding this information into random >>>>>>>>> integers and then using just 3 bits out of 32. >>>>>>>> Ack. Originally intended to make it more flexible for future use. It can be >>>>>>>> text strings for current requirement. >>>>>>> >>>>>>> No, fixed-format data isn't flexible. Fine-grained properties are. >>>>>>> Please define exactly what is necessary rather than leaving empty >>>>>>> holes "for future expansion".= >>>>>>> >>>>>>>>> >>>>>>>>>> >>>>>>>>>> |---------------------------------------------------------------------| >>>>>>>>>> | 32 Bits | >>>>>>>>>> |---------------------------------------------------------------------| >>>>>>>>>> | 31 - 24 (bits) | 23 - 16 (bits) | 15 - 0 (16 bits) | >>>>>>>>>> |---------------------------------------------------------------------| >>>>>>>>>> | Reserved | 0: default | 0: default | >>>>>>>>>> | | 1: CE | | >>>>>>>>>> | | 2: IoT | | >>>>>>>>>> | | 3: Auto | | >>>>>>>>>> | | 4: Reserved | | >>>>>>>>>> |---------------------------------------------------------------------| >>>>>>>>>> >>>>>>>>>> Signed-off-by: Cheng Jiang >>>>>>>>>> --- >>>>>>>>>> .../bindings/net/bluetooth/qualcomm-bluetooth.yaml | 6 ++++++ >>>>>>>>>> 1 file changed, 6 insertions(+) >>>>>>>>>> >>>>>>>>>> diff --git a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml >>>>>>>>>> index 7bb68311c609..9019fe7bcdc6 100644 >>>>>>>>>> --- a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml >>>>>>>>>> +++ b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml >>>>>>>>>> @@ -110,6 +110,12 @@ properties: >>>>>>>>>> description: >>>>>>>>>> boot firmware is incorrectly passing the address in big-endian order >>>>>>>>>> >>>>>>>>>> + qcom,product-variant: >>>>>>>>>> + $ref: /schemas/types.yaml#/definitions/uint32 >>>>>>>>>> + description: >>>>>>>>>> + specify the product information for driver to load the appropriate firmware >>>>>>>>> >>>>>>>>> DT describes hardware. Is this a hardware property? >>>>>>>> >>>>>>>> It has been added to identify the firmware image for the platform. The driver >>>>>>>> parses it, and then the rampatch is selected from a specify directory. Currently, >>>>>>>> there is a 'firmware-name' parameter, but it is only used to specify the NVM >>>>>>>> (config) file. We also need to specify the rampatch (TLV file). >>>>>>>> >>>>>>>> >>>>>>>> Can we re-use the "firmware-name"? add two segments like the following? >>>>>>>> firmware-name = "rampatch_xx.tlv", "nvm_xx.bin"; >>>>>>> >>>>>>> I think this is the better solution >>>>>>> >>>>>> How about the following logic for handling 'firmware-name' property: >>>>>> 1. If there is only one string in firmware-name, it must be the NVM file, which is used >>>>>> for backward compatibility. >>>>>> >>>>>> 2. If there are two strings in firmware-name, the first string is for the rampatch, and >>>>>> the second string is for the NVM. >>>>> >>>>> I'd say, other way around: the first one is always NVM, the second one >>>>> is rampatch and it is optional. >>>>> >>>> OK, Got it. >>>>>> >>>>>> 3. Due to variations in RF performance of chips from different foundries, different NVM >>>>>> configurations are used based on the board ID. If the second string ends with boardid, >>>>>> the NVM file will be selected according to the board ID. >>>>> >>>>> Is there a reason why you can not use the exact firmware name? The >>>>> firmware name is a part of the board DT file. I assume you know the >>>>> board ID that has been used for the board. >>>>> >>>> The boardid is the connectivity board's id. NVM is a board specific configuration file, >>>> it's related to the connectivity board. We may attach different connectivity board on the >>>> same platform. For example, we have connectivity boards based on the QCA6698 chipset that >>>> can support either a two-antenna or three-antenna solution. Both boards work fine on the >>>> sa8775p-ride platform. >>> >>> Please add such an info to the commit messages (plural for it being a >>> generic feedback: please describe the reasons for your design >>> decisions), >>> >> Ack. >>> I really don't like the .boardid template. What if we change property >>> behaviour in the following way: if there is no file extension then .bNN >>> will be probed, falling back to .bin. This will require reading board ID >>> for all the platforms that support it (do wcn3990 have board ID?) >>> >> Ack, this proposal is great. >> Yes, We have board ID for each connectivity card. An NVM file maps to it >> if necessary. > > The question was about the WiFI generations, not about the NVM cards. > Do wcn3990 also support reading board ID? > WCN3990 supports reading board id. However, the board ID is only associated with the connectivity board, not the chipset itself. From a Bluetooth perspective, all WCN3990 connectivity boards use the same NVM file. >> >> Let me provide a new patchset based on this solution. Thank you very much for >> the valuable comments. > > :-) > >>>>>> >>>>>> >>>>>> Here are two examples: >>>>>> >>>>>> firmware-name = "qca/QCA6698/hpbtfw21.tlv", "qca/QCA6698/hpnv21.bin"; >>>>>> In this configuration, the driver will use the two files directly. >>>>>> >>>>>> >>>>>> firmware-name = "qca/QCA6698/hpbtfw21.tlv", "qca/QCA6698/hpnv21.boardid"; >>>>>> In this configuration, the driver will replace boardid with the actual board information. >>>>>> If the board id is 0x0206, the nvm file name will be qca/QCA6698/hpnv21.b0206 >>>>>> >>>>>>>> >>>>>>>> Or add a new property to specify the rampatch file? >>>>>>>> rampatch-name = "rampatch_xx.tlv"; >>>>>>>> >>>>>>>>> >>>>>>>>>> + >>>>>>>>>> + >>>>>>>>>> required: >>>>>>>>>> - compatible >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> 2.25.1 >>>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>> >>>>> >>>>> -- >>>>> With best wishes >>>>> Dmitry >>>> >>> >> > >