From: Carlos Bilbao <carlos.bilbao@lambdal.com>
To: davem@davemloft.net, kuba@kernel.org, jmaxwell37@gmail.com,
dsahern@kernel.org, linux-decnet-user@lists.sourceforge.net
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bilbao@vt.edu
Subject: [PATCH] net: decnet: fix build error due to incompatible pointer type, in dn_dst_gc
Date: Fri, 23 Jan 2026 15:23:10 -0800 [thread overview]
Message-ID: <ecb0ffd9-4a1f-4579-bff8-264aedb5bab1@lambdal.com> (raw)
Update the signature of dn_dst_gc() to return void instead of int.
This change is required because the .gc member of struct dst_ops was
updated to a void return type in a previous commit [1]. This leads to the
following build error:
net/decnet/dn_route.c:132:10: error: initialization of 'void (*)(struct dst_ops *)' from incompatible pointer type 'int (*)(struct dst_ops *)' [-Werror=incompatible-pointer-types]
Note that dst_alloc() inside net/core/dst.c was already updated to
ignore the return value of this callback.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit?id=af6d10345ca76670c1b7c37799f0d5576ccef277
Fixes: af6d10345ca7 ("ipv6: remove max_size check inline with ipv4")
Signed-off-by: Carlos Bilbao (Lambda) <carlos.bilbao@kernel.org>
---
net/decnet/dn_route.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/net/decnet/dn_route.c b/net/decnet/dn_route.c
index 729d3de6020d..840a0e3852de 100644
--- a/net/decnet/dn_route.c
+++ b/net/decnet/dn_route.c
@@ -100,7 +100,7 @@ static const int dn_rt_mtu_expires = 10 * 60 * HZ;
static unsigned long dn_rt_deadline;
-static int dn_dst_gc(struct dst_ops *ops);
+static void dn_dst_gc(struct dst_ops *ops);
static struct dst_entry *dn_dst_check(struct dst_entry *, __u32);
static unsigned int dn_dst_default_advmss(const struct dst_entry *dst);
static unsigned int dn_dst_mtu(const struct dst_entry *dst);
@@ -208,7 +208,7 @@ static void dn_dst_check_expire(struct timer_list *unused)
mod_timer(&dn_route_timer, now + decnet_dst_gc_interval * HZ);
}
-static int dn_dst_gc(struct dst_ops *ops)
+static void dn_dst_gc(struct dst_ops *ops)
{
struct dn_route *rt;
struct dn_route __rcu **rtp;
@@ -236,8 +236,6 @@ static int dn_dst_gc(struct dst_ops *ops)
}
spin_unlock_bh(&dn_rt_hash_table[i].lock);
}
-
- return 0;
}
/*
--
2.50.1 (Apple Git-155)
next reply other threads:[~2026-01-23 23:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-23 23:23 Carlos Bilbao [this message]
2026-01-24 20:33 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ecb0ffd9-4a1f-4579-bff8-264aedb5bab1@lambdal.com \
--to=carlos.bilbao@lambdal.com \
--cc=bilbao@vt.edu \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=jmaxwell37@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-decnet-user@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®