From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80206C6778A for ; Tue, 3 Jul 2018 14:44:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3A848214FA for ; Tue, 3 Jul 2018 14:44:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3A848214FA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932926AbeGCOoX (ORCPT ); Tue, 3 Jul 2018 10:44:23 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:59836 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932838AbeGCOoV (ORCPT ); Tue, 3 Jul 2018 10:44:21 -0400 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w63EYQvx027632 for ; Tue, 3 Jul 2018 10:44:20 -0400 Received: from e15.ny.us.ibm.com (e15.ny.us.ibm.com [129.33.205.205]) by mx0b-001b2d01.pphosted.com with ESMTP id 2k09dh5e0f-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 03 Jul 2018 10:44:19 -0400 Received: from localhost by e15.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 3 Jul 2018 10:44:19 -0400 Received: from b01cxnp22035.gho.pok.ibm.com (9.57.198.25) by e15.ny.us.ibm.com (146.89.104.202) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Tue, 3 Jul 2018 10:44:15 -0400 Received: from b01ledav001.gho.pok.ibm.com (b01ledav001.gho.pok.ibm.com [9.57.199.106]) by b01cxnp22035.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w63EiDhh10420932 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 3 Jul 2018 14:44:13 GMT Received: from b01ledav001.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1718928058; Tue, 3 Jul 2018 10:43:46 -0400 (EDT) Received: from b01ledav001.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DEBDF28059; Tue, 3 Jul 2018 10:43:43 -0400 (EDT) Received: from oc8043147753.ibm.com (unknown [9.60.75.218]) by b01ledav001.gho.pok.ibm.com (Postfix) with ESMTP; Tue, 3 Jul 2018 10:43:43 -0400 (EDT) Subject: Re: [PATCH v6 05/21] KVM: s390: CPU model support for AP virtualization To: Cornelia Huck , Halil Pasic Cc: Christian Borntraeger , Tony Krowiak , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, freude@de.ibm.com, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, kwankhede@nvidia.com, bjsdjshi@linux.vnet.ibm.com, pbonzini@redhat.com, alex.williamson@redhat.com, pmorel@linux.vnet.ibm.com, alifm@linux.vnet.ibm.com, mjrosato@linux.vnet.ibm.com, jjherne@linux.vnet.ibm.com, thuth@redhat.com, pasic@linux.vnet.ibm.com, berrange@redhat.com, fiuczy@linux.vnet.ibm.com, buendgen@de.ibm.com References: <1530306683-7270-1-git-send-email-akrowiak@linux.vnet.ibm.com> <1530306683-7270-6-git-send-email-akrowiak@linux.vnet.ibm.com> <276b5ae7-7f27-faae-1e5a-0d4c084139e9@linux.ibm.com> <20180702174103.5d1ce603.cohuck@redhat.com> <20180702181108.2c721a86.cohuck@redhat.com> <76165cca-b8ec-172a-4a1b-6f3514b44344@linux.ibm.com> <20180702182840.34560fed.cohuck@redhat.com> From: Tony Krowiak Date: Tue, 3 Jul 2018 10:44:10 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <20180702182840.34560fed.cohuck@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-TM-AS-GCONF: 00 x-cbid: 18070314-0068-0000-0000-00000312738D X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00009301; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000266; SDB=6.01055980; UDB=6.00541656; IPR=6.00833903; MB=3.00021977; MTD=3.00000008; XFM=3.00000015; UTC=2018-07-03 14:44:18 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18070314-0069-0000-0000-000044E635D2 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-07-03_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1806210000 definitions=main-1807030168 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/02/2018 12:28 PM, Cornelia Huck wrote: > On Mon, 2 Jul 2018 18:20:55 +0200 > Halil Pasic wrote: > >> On 07/02/2018 06:11 PM, Cornelia Huck wrote: >>> On Mon, 2 Jul 2018 11:54:28 -0400 >>> Tony Krowiak wrote: >>> >>>> On 07/02/2018 11:41 AM, Cornelia Huck wrote: >>>>> On Mon, 2 Jul 2018 11:37:11 -0400 >>>>> Tony Krowiak wrote: >>>>> >>>>>> On 07/02/2018 10:38 AM, Christian Borntraeger wrote: >>>>>>> On 06/29/2018 11:11 PM, Tony Krowiak wrote: >>>>>>>> Introduces a new CPU model feature and two CPU model >>>>>>>> facilities to support AP virtualization for KVM guests. >>>>>>>> >>>>>>>> CPU model feature: >>>>>>>> >>>>>>>> The KVM_S390_VM_CPU_FEAT_AP feature indicates that >>>>>>>> AP instructions are available on the guest. This >>>>>>>> feature will be enabled by the kernel only if the AP >>>>>>>> instructions are installed on the linux host. This feature >>>>>>>> must be specifically turned on for the KVM guest from >>>>>>>> userspace to use the VFIO AP device driver for guest >>>>>>>> access to AP devices. >>>>>>>> >>>>>>>> CPU model facilities: >>>>>>>> >>>>>>>> 1. AP Query Configuration Information (QCI) facility is installed. >>>>>>>> >>>>>>>> This is indicated by setting facilities bit 12 for >>>>>>>> the guest. The kernel will not enable this facility >>>>>>>> for the guest if it is not set on the host. This facility >>>>>>>> must not be set by userspace if the KVM_S390_VM_CPU_FEAT_AP >>>>>>>> feature is not installed. >>>>>>>> >>>>>>>> If this facility is not set for the KVM guest, then only >>>>>>>> APQNs with an APQI less than 16 will be available to the >>>>>>>> guest regardless of the guest's matrix configuration. This >>>>>>>> is a limitation of the AP bus running on the guest. >>>>>>>> >>>>>>>> 2. AP Facilities Test facility (APFT) is installed. >>>>>>>> >>>>>>>> This is indicated by setting facilities bit 15 for >>>>>>>> the guest. The kernel will not enable this facility for >>>>>>>> the guest if it is not set on the host. This facility >>>>>>>> must not be set by userspace if the KVM_S390_VM_CPU_FEAT_AP >>>>>>>> feature is not installed. >>>>>>>> >>>>>>>> If this facility is not set for the KVM guest, then no >>>>>>>> AP devices will be available to the guest regardless of >>>>>>>> the guest's matrix configuration. This is a limitation >>>>>>>> of the AP bus running under the guest. >>>>>>>> >>>>>>>> Reviewed-by: Christian Borntraeger >>>>>>>> Reviewed-by: Halil Pasic >>>>>>>> Signed-off-by: Tony Krowiak >>>>>>> I think it probably should be at the end of the series, other than that its good. >>>>>> If I move this to the end of the series, the very next patch checks the >>>>>> >>>>>> KVM_S390_VM_CPU_FEAT_AP feature? >>>>> Introduce it here, offer it only with the last patch? >>>> I apologize, but I don't know what you mean by this. Are you suggesting >>>> this patch >>>> should only include the #define for KVM_S390_VM_CPU_FEAT_AP? >>> Yes, just introduce the definition here (so code later in the series >>> can refer to it) and flip the switch (offer the bit) as the final >>> patch. >>> >> The other features introduced and exposed here are no different. For >> KVM_S390_VM_CPU_FEAT_AP defer exposing means defer allow_cpu_feat(); >> for the STFLE features, defer adding to FACILITIES_KVM_CPUMODEL. >> >> Anyway, I think the definition should be squashed into #6. Expose the >> features after patch #6 is in place or expose them at the end of the >> series is IMHO a matter of taste -- and I lean towards expose at the >> end of the series. > Squashing with patch 6 and enabling at the end of the series sounds > good to me as well. Consider it done. >