From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08EA7CDB482 for ; Mon, 16 Oct 2023 13:08:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233456AbjJPNIa (ORCPT ); Mon, 16 Oct 2023 09:08:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48758 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231569AbjJPNI3 (ORCPT ); Mon, 16 Oct 2023 09:08:29 -0400 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE922E6 for ; Mon, 16 Oct 2023 06:08:26 -0700 (PDT) Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-1c9e95aa02dso26714605ad.0 for ; Mon, 16 Oct 2023 06:08:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20230601.gappssmtp.com; s=20230601; t=1697461706; x=1698066506; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=tfy1ziPitTIKCgP7hgWatYcJeB1MWA1vHtQFUnRwmZU=; b=O80akG8HMtlEwCSfu7ToJqjUfOBwqyuB/N+7UgY2tM3TzKU7F6JMqdayHK08mRe1rJ ZqykConvOfOciejVhe/MZC35rkgQglss+K+TZ+9Q0wejP2hmeOqWxhOyNu/Bm7HLNt2V 8JbCWQ1waGDllker+kN9OIaTzuy/WmHtUgZnNEunIiZrYsD1YwO6d1BpOPddFcNDyJHC ANjTrg9cc8Zyi3QF4klfPamU0rvLrTxDLAiJKXa1OiYdjaGwFsY7YTLcLKYGaEF1x4A6 h7CBSD4vG/YN5WGOQTqxkjfW2lhj5QQ2Phux001IEBE0+xMfD56ym/mljoVRpijgfpQc W7vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697461706; x=1698066506; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tfy1ziPitTIKCgP7hgWatYcJeB1MWA1vHtQFUnRwmZU=; b=D2/Y/TU2pV0yhecJ9FrBtuCDvKGFfSo20ks91f9WxPwdhUIdHp/aycuSssL4kLSFp0 Dk1B1iWrtlmtGdW1U0ctdKOmchL6XrOVXoNJcxq3enY/Z/OAS/7eTnYo+IdsXqltuP9/ PamUGBqxHXygBMjNNB49jpqJqzD6wuOc0i9ZxB8CON14Z0JGEozpsX7oFdpGeNDlyYr1 cgUci0ABsPpyyuZpuvu541WK8eYgT9/k1cT3ODEVqBk03oa/2vU3lXDoNsmrxQOMZChN stG5N9edb2cXrVgUr0d75PYp54dv0zJ96dXtAssQfnIbxyHyuvKM8g0vuKyEyp7hjgi5 z8Pg== X-Gm-Message-State: AOJu0YwdybT3qB48Kf2z8cLR/3Ddu9HfrxtVlPrfzFbtQTUQ/OHRhHCg K03U5QtIEebb2JHRmt1sZUDv/Kf6g8K6dJqcKAUBtA== X-Google-Smtp-Source: AGHT+IEFoc6AGYZwR5/ObdpuzM9hbI7UWGokG/QIvGghVbavGZhqHMPuFgH+U+30ml7a/ChTLmr1wA== X-Received: by 2002:a17:903:1ce:b0:1c7:27a1:a9e5 with SMTP id e14-20020a17090301ce00b001c727a1a9e5mr10234801plh.33.1697461706303; Mon, 16 Oct 2023 06:08:26 -0700 (PDT) Received: from ?IPV6:2400:4050:a840:1e00:78d2:b862:10a7:d486? ([2400:4050:a840:1e00:78d2:b862:10a7:d486]) by smtp.gmail.com with ESMTPSA id l13-20020a170902eb0d00b001b890009634sm8420579plb.139.2023.10.16.06.08.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Oct 2023 06:08:26 -0700 (PDT) Message-ID: Date: Mon, 16 Oct 2023 22:08:21 +0900 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH bpf-next v3] selftests/bpf: Use pkg-config to determine ld flags To: Daniel Borkmann Cc: Andrii Nakryiko , Mykola Lysenko , Alexei Starovoitov , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Shuah Khan , Nick Terrell , bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20231016124313.60220-1-akihiko.odaki@daynix.com> Content-Language: en-US From: Akihiko Odaki In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/10/16 21:52, Daniel Borkmann wrote: > On 10/16/23 2:43 PM, Akihiko Odaki wrote: >> When linking statically, libraries may require other dependencies to be >> included to ld flags. In particular, libelf may require libzstd. Use >> pkg-config to determine such dependencies. >> >> Signed-off-by: Akihiko Odaki >> --- >> V2 -> V3: Added missing "echo". >> V1 -> V2: Implemented fallback, referring to HOSTPKG_CONFIG. > > Same issue in v3. Please don't resend your patches too quickly, but > properly set up an > environment where you can test that this fallback works first : > > https://github.com/kernel-patches/bpf/actions/runs/6533309175/job/17738285759 I think you are looking at a wrong run. The run checks out: https://github.com/kernel-patches/bpf/commit/0c184cb0b561d2fb60b2dc79c2917cd7ff8cd8a2 This is v2. I think the correct one is: https://github.com/kernel-patches/bpf/actions/runs/6533797864 That said, I found spurious error messages with the run. I tested it by setting PKG_CONFIG=false, but I should have tested it with PKG_CONFIG=a-command-that-does-not-exist. Now I sent v4, which does no longer emit noisy error messages and is properly tested.