From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D62B5C34026 for ; Tue, 18 Feb 2020 12:38:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B54B4206F4 for ; Tue, 18 Feb 2020 12:38:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726599AbgBRMh7 (ORCPT ); Tue, 18 Feb 2020 07:37:59 -0500 Received: from foss.arm.com ([217.140.110.172]:51322 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726363AbgBRMh7 (ORCPT ); Tue, 18 Feb 2020 07:37:59 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6DB051FB; Tue, 18 Feb 2020 04:37:58 -0800 (PST) Received: from [192.168.0.7] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A1A6B3F6CF; Tue, 18 Feb 2020 04:37:56 -0800 (PST) Subject: Re: [PATCH v2 2/5] sched/numa: Replace runnable_load_avg by load_avg To: Vincent Guittot , mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, linux-kernel@vger.kernel.org Cc: pauld@redhat.com, parth@linux.ibm.com, valentin.schneider@arm.com, hdanton@sina.com References: <20200214152729.6059-1-vincent.guittot@linaro.org> <20200214152729.6059-3-vincent.guittot@linaro.org> From: Dietmar Eggemann Message-ID: Date: Tue, 18 Feb 2020 13:37:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200214152729.6059-3-vincent.guittot@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/02/2020 16:27, Vincent Guittot wrote: [...] > /* > * The load is corrected for the CPU capacity available on each node. > * > @@ -1788,10 +1831,10 @@ static int task_numa_migrate(struct task_struct *p) > dist = env.dist = node_distance(env.src_nid, env.dst_nid); > taskweight = task_weight(p, env.src_nid, dist); > groupweight = group_weight(p, env.src_nid, dist); > - update_numa_stats(&env.src_stats, env.src_nid); > + update_numa_stats(&env, &env.src_stats, env.src_nid); This looks strange. Can you do: -static void update_numa_stats(struct task_numa_env *env, +static void update_numa_stats(unsigned int imbalance_pct, struct numa_stats *ns, int nid) - update_numa_stats(&env, &env.src_stats, env.src_nid); + update_numa_stats(env.imbalance_pct, &env.src_stats, env.src_nid); [...] > +static unsigned long cpu_runnable_load(struct rq *rq) > +{ > + return cfs_rq_runnable_load_avg(&rq->cfs); > +} > + Why not remove cpu_runnable_load() in this patch rather moving it? kernel/sched/fair.c:5492:22: warning: ‘cpu_runnable_load’ defined but not used [-Wunused-function] static unsigned long cpu_runnable_load(struct rq *rq)