From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753193AbcGGPjp (ORCPT ); Thu, 7 Jul 2016 11:39:45 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:32615 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752214AbcGGPjh (ORCPT ); Thu, 7 Jul 2016 11:39:37 -0400 Subject: Re: [Xen-devel] [PATCH] xen/apic: Update the comment for apic_id_mask To: Konrad Rzeszutek Wilk , Wei Jiangang , david.vrabel@citrix.com References: <1467862098-2374-1-git-send-email-weijg.fnst@cn.fujitsu.com> <20160707152510.GJ17766@localhost.localdomain> Cc: linux-kernel@vger.kernel.org, x86@kernel.org, mingo@redhat.com, hpa@zytor.com, xen-devel@lists.xenproject.org, tglx@linutronix.de, Juergen Gross From: Boris Ostrovsky Message-ID: Date: Thu, 7 Jul 2016 11:37:59 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <20160707152510.GJ17766@localhost.localdomain> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/07/2016 11:25 AM, Konrad Rzeszutek Wilk wrote: > On Thu, Jul 07, 2016 at 11:28:18AM +0800, Wei Jiangang wrote: >> verify_local_APIC() had been removed by >> commit 4399c03c6780 ("x86/apic: Remove verify_local_APIC()"), >> so apic_id_mask isn't used by it. Is anyone actually using this field? It looks like 4399c03c6780 removed the only user. -boris > CC-ing the proper maintainers. >> Signed-off-by: Wei Jiangang >> --- >> arch/x86/xen/apic.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/x86/xen/apic.c b/arch/x86/xen/apic.c >> index db52a7fafcc2..9cbb1f48381b 100644 >> --- a/arch/x86/xen/apic.c >> +++ b/arch/x86/xen/apic.c >> @@ -177,7 +177,7 @@ static struct apic xen_pv_apic = { >> >> .get_apic_id = xen_get_apic_id, >> .set_apic_id = xen_set_apic_id, /* Can be NULL on 32-bit. */ >> - .apic_id_mask = 0xFF << 24, /* Used by verify_local_APIC. Match with what xen_get_apic_id does. */ >> + .apic_id_mask = 0xFF << 24, /* Match with what xen_get_apic_id does. */ >> >> .cpu_mask_to_apicid_and = flat_cpu_mask_to_apicid_and, >> >> -- >> 1.9.3 >> >> >> >> >> _______________________________________________ >> Xen-devel mailing list >> Xen-devel@lists.xen.org >> https://lists.xen.org/xen-devel