From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39225C77B7F for ; Mon, 8 May 2023 16:22:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234073AbjEHQWh (ORCPT ); Mon, 8 May 2023 12:22:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54732 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233277AbjEHQWf (ORCPT ); Mon, 8 May 2023 12:22:35 -0400 Received: from hust.edu.cn (unknown [202.114.0.240]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 459DA3A8B; Mon, 8 May 2023 09:22:34 -0700 (PDT) Received: from [192.168.10.39] ([120.202.201.11]) (user=saraday@hust.edu.cn mech=PLAIN bits=0) by mx1.hust.edu.cn with ESMTP id 348GMCEx006603-348GMCF1006603 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Tue, 9 May 2023 00:22:12 +0800 Message-ID: Date: Tue, 9 May 2023 00:22:10 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH 2/2] bus: qcom-ebi2: simplify the code in qcom_ebi2_probe() To: Linus Walleij Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , hust-os-kernel-patches@googlegroups.com, Dongliang Mu , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230430125154.126863-1-saraday@hust.edu.cn> <20230430125154.126863-2-saraday@hust.edu.cn> From: Ziliang Liao In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-FEAS-AUTH-USER: saraday@hust.edu.cn Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks for your advice. Do I need to delete the Fixes in [PATCH 2/2] and resend another patch set? > On Sun, Apr 30, 2023 at 2:54 PM Ziliang Liao wrote: > >> The code use platform_get_resource() and devm_ioremap_resource() to >> allocate memory resources for the device. It can be simplified by using >> devm_platform_ioremap_resource(). >> >> Fixes: 335a12754808 ("bus: qcom: add EBI2 driver") > It doesn't need Fixes: if it's not a bug, but who cares. Maybe > the stable maintainers care. > >> Signed-off-by: Ziliang Liao >> Reviewed-by: Dongliang Mu > Reviewed-by: Linus Walleij > > Yours, > Linus Walleij