From: Dan Carpenter <dan.carpenter@linaro.org>
To: Kent Overstreet <kent.overstreet@linux.dev>
Cc: David Laight <David.Laight@aculab.com>,
Colin Ian King <colin.i.king@gmail.com>,
Brian Foster <bfoster@redhat.com>,
"linux-bcachefs@vger.kernel.org" <linux-bcachefs@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][next] bcachefs: remove redundant initialization of variable level
Date: Mon, 20 Nov 2023 07:00:39 -0500 [thread overview]
Message-ID: <ecc75e51-7244-4caa-b89e-b2fc89f6c7bc@suswa.mountain> (raw)
In-Reply-To: <20231112191249.srvcmay2yeewy7ql@moria.home.lan>
On Sun, Nov 12, 2023 at 02:12:49PM -0500, Kent Overstreet wrote:
> David, I don't want you giving this kind of advice here, and if finding
> declarations is something you have trouble with - perhaps find something
> easier to do.
David is correct. Putting declarations in the middle of code is still
frowned on. It's necessary for the __cleanup work and it's okay in for
loop iterators but it's generally frowned on.
Please don't force people to redo patches in non-standard style.
regards,
dan carpenter
prev parent reply other threads:[~2023-11-20 12:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-11 20:45 Colin Ian King
2023-11-11 21:02 ` Kent Overstreet
2023-11-11 21:19 ` David Laight
2023-11-11 23:39 ` Kent Overstreet
2023-11-12 18:34 ` David Laight
2023-11-12 19:12 ` Kent Overstreet
2023-11-20 12:00 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ecc75e51-7244-4caa-b89e-b2fc89f6c7bc@suswa.mountain \
--to=dan.carpenter@linaro.org \
--cc=David.Laight@aculab.com \
--cc=bfoster@redhat.com \
--cc=colin.i.king@gmail.com \
--cc=kent.overstreet@linux.dev \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-bcachefs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®