From: Maulik Shah <mkshah@codeaurora.org>
To: Marc Zyngier <maz@kernel.org>, Rajendra Nayak <rnayak@codeaurora.org>
Cc: agross@kernel.org, robh+dt@kernel.org,
bjorn.andersson@linaro.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Lina Iyer <ilina@codeaurora.org>
Subject: Re: [PATCH v2 11/13] drivers: irqchip: qcom-pdc: Add irqchip for sc7180
Date: Tue, 22 Oct 2019 10:55:51 +0530 [thread overview]
Message-ID: <ecca1dde-6729-2ad0-4a30-b5a6de335198@codeaurora.org> (raw)
In-Reply-To: <18195431666bd42aa31cf4ec1eed2881@www.loen.fr>
On 10/21/2019 1:40 PM, Marc Zyngier wrote:
> On 2019-10-21 07:55, Rajendra Nayak wrote:
>> From: Maulik Shah <mkshah@codeaurora.org>
>>
>> Add sc7180 pdc irqchip
>>
>> Signed-off-by: Maulik Shah <mkshah@codeaurora.org>
>> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
>> Cc: Lina Iyer <ilina@codeaurora.org>
>> Cc: Marc Zyngier <maz@kernel.org>
>> ---
>> v2: No change
>>
>> drivers/irqchip/qcom-pdc.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/irqchip/qcom-pdc.c b/drivers/irqchip/qcom-pdc.c
>> index faa7d61b9d6c..954fb599fa9c 100644
>> --- a/drivers/irqchip/qcom-pdc.c
>> +++ b/drivers/irqchip/qcom-pdc.c
>> @@ -310,3 +310,4 @@ static int qcom_pdc_init(struct device_node
>> *node, struct device_node *parent)
>> }
>>
>> IRQCHIP_DECLARE(pdc_sdm845, "qcom,sdm845-pdc", qcom_pdc_init);
>> +IRQCHIP_DECLARE(pdc_sc7180, "qcom,sc7180-pdc", qcom_pdc_init);
>
> What I gather from these 3 irq-related patches is that as far as
> the PDC is concerned, SDM845/850 and SC7180 are strictly identical.
>
> Why the churn?
>
> M.
Hi Marc,
Different compatible were used to distinguish since interrupt mapping
(PDC to GIC) was earlier kept in driver.
Now since mapping is kept in DTSI, we can continue to use
qcom,sdm845-pdc for sc7180.
i will submit another patch to make it more generic for all SoCs like
"qcom,pdc".
Thanks,
Maulik
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2019-10-22 5:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 6:55 [PATCH v2 00/13] Add device tree support " Rajendra Nayak
2019-10-21 6:55 ` [PATCH v2 01/13] dt-bindings: qcom: Add SC7180 bindings Rajendra Nayak
2019-10-21 6:55 ` [PATCH v2 02/13] arm64: dts: sc7180: Add minimal dts/dtsi files for SC7180 soc Rajendra Nayak
2019-10-22 0:08 ` Matthias Kaehlcke
2019-10-22 6:15 ` Rajendra Nayak
2019-10-21 6:55 ` [PATCH v2 03/13] dt-bindings: arm-smmu: update binding for qcom sc7180 SoC Rajendra Nayak
2019-10-21 6:55 ` [PATCH v2 04/13] arm64: dts: sc7180: Add device node for apps_smmu Rajendra Nayak
2019-10-21 6:55 ` [PATCH v2 05/13] arm64: dts: qcom: sc7180: Add cmd_db reserved area Rajendra Nayak
2019-10-21 6:55 ` [PATCH v2 06/13] arm64: dts: qcom: sc7180: Add rpmh-rsc node Rajendra Nayak
2019-10-21 6:55 ` [PATCH v2 07/13] arm64: dts: qcom: sc7180: Add SPMI PMIC arbiter device Rajendra Nayak
2019-10-21 6:55 ` [PATCH v2 08/13] arm64: dts: qcom: pm6150: Add PM6150/PM6150L PMIC peripherals Rajendra Nayak
2019-10-21 6:55 ` [PATCH v2 09/13] arm64: dts: qcom: sc7180-idp: Add RPMh regulators Rajendra Nayak
2019-10-21 6:55 ` [PATCH v2 10/13] arm64: dts: qcom: SC7180: Add node for rpmhcc clock driver Rajendra Nayak
2019-10-21 6:55 ` [PATCH v2 11/13] drivers: irqchip: qcom-pdc: Add irqchip for sc7180 Rajendra Nayak
2019-10-21 8:10 ` Marc Zyngier
2019-10-22 5:25 ` Maulik Shah [this message]
2019-10-21 6:55 ` [PATCH v2 12/13] dt-bindings: qcom,pdc: Add compatible " Rajendra Nayak
2019-10-25 21:31 ` Rob Herring
2019-10-21 6:55 ` [PATCH v2 13/13] arm64: dts: qcom: sc7180: Add pdc interrupt controller Rajendra Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ecca1dde-6729-2ad0-4a30-b5a6de335198@codeaurora.org \
--to=mkshah@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=ilina@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome