From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S935942AbdCXMNk (ORCPT <rfc822;w@1wt.eu>);
        Fri, 24 Mar 2017 08:13:40 -0400
Received: from mout.web.de ([212.227.15.3]:64951 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S935113AbdCXMNd (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 24 Mar 2017 08:13:33 -0400
Subject: Re: selinux: Delete an error message for a failed memory allocation
 in policydb_read()
To: Paul Moore <paul@paul-moore.com>
References: <ca34123f-ced6-d2bc-363b-690858618827@users.sourceforge.net>
 <c589a851-2bf6-c44f-1df7-11f242285a73@users.sourceforge.net>
 <CAHC9VhTf6LdUNJHV9G+YA=P1rj78v5WKG8v+QNoFGZ6DA+mDmQ@mail.gmail.com>
Cc: linux-security-module@vger.kernel.org, selinux@tycho.nsa.gov,
        Eric Paris <eparis@parisplace.org>,
        James Morris <james.l.morris@oracle.com>,
        "Serge E. Hallyn" <serge@hallyn.com>,
        Stephen Smalley <sds@tycho.nsa.gov>,
        William Roberts <william.c.roberts@intel.com>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org,
        Wolfram Sang <wsa@the-dreams.de>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <ecce7c5c-cbeb-5896-ec12-26c97619c102@users.sourceforge.net>
Date: Fri, 24 Mar 2017 13:13:09 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <CAHC9VhTf6LdUNJHV9G+YA=P1rj78v5WKG8v+QNoFGZ6DA+mDmQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Provags-ID: V03:K0:6j5GwjfsUEmNqgn11VN1QGDShonaa6JwXv9RNOLgFf5y7ny3WaJ
 XsYhXQ1QnZHB3xo3NXd4Ico3VcsSCLSVWlgdtgmS4VMJlk6Grj3Sp6wEdL9f8pOYePu7xD4
 fFka5rN0s/NkzvhjqOpW5rcKH9cXQPfiwkVkhSMCFXDH7x+5O22WeDvuLLoYN2uJzcCP29R
 jZjkgSv1qrGjZBjyS1j3A==
X-UI-Out-Filterresults: notjunk:1;V01:K0:uDHeVMrlmSI=:nD1StEqAPJTqTF6jhG2C6b
 cAkKclppRdNc2EjJWX6ESBdmQKG8lG8mnfQjDBvP/lVeo7malCtWO5NPZt3eLj7+g36aR1AOl
 WTFfFRor9Yct95Zcd710zgNW7w9hb9u+9WlaSlsCplL0kECXhUZWVzm+m62PbQLJzTEWYKU7F
 bGogGR4utvQlWeXGmzCi9OvqkjFs+hwQPBSWlsdbA9zR4LW3+J0gMbssaBES6BtomOedejiSr
 wwsu7j7lEmobo6OQnNPekVWs9DNy5a5HFQGQ+yCXpBashfGDnl4krA3iCDDYwFZC4Y+bhaFov
 +fcN5uvRZXut4QB5NtqjULKC8zvi1gMrWDYaEggkJWIZm8odKI4JG6IVzei5PXx+DQgh7cAEi
 y6OoRDJNNdceN4FEZsm64SnNMbRsoUbyQbs86dUatk9nn0Y7nHLOfQCtc2Dvra5HzzZ9ltdWT
 Y4WHPrri370WG+TvR//PYfYUyLePaGOgrIbESzFmFcQPWpRHlIhfRB7U/NAFVaNDTmU0HccmI
 aBxNjc/TLPXplk5DP+tWKKSQFYHhiQW2duYXhZogtRkijJezVRbGzac0WVDKrE6tAi0nFt2Zu
 MFJoBY5iFO58IdWD3F+xBR6aUp0+1XqucB8/vbtNzNXQ6tEnzU/dtMHetIiDzotjI1+ZVp7VM
 mlsZAGqKvjoIL6HhwzNfpvVQ8pjUg6fmJAkorHW6uECukRisReiEvIANawwFdM3jiIkRZY+nb
 +Y5ce1xvy7o5eE7suKzpRJGafiEv3a+4VKP+XWGHfZO7NjItMrirP2Ahi5zgPFgSDreX4XJrG
 B4OPcfA
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> Omit an extra message for a memory allocation failure in this function.
>>
>> Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
>> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
>> ---
>>  security/selinux/ss/policydb.c | 5 +----
>>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> I'm not going to remove an error message without some better reasoning
> in the patch description.  Providing a link to slides is fine, but
> your commit message needs to convey the important information and I
> don't think that is the case here (what happens when that URL dies?).

Do you need an explicit reminder there that the function “kmalloc” provides its own
error reporting already because the flag “__GFP_NOWARN” was not passed here?

Regards,
Markus