From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2914EC46467 for ; Tue, 10 Jan 2023 16:49:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238384AbjAJQtX (ORCPT ); Tue, 10 Jan 2023 11:49:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238664AbjAJQtM (ORCPT ); Tue, 10 Jan 2023 11:49:12 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A26422FD for ; Tue, 10 Jan 2023 08:48:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673369320; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lJePnZsKXnubDcGA3DYzaayBveLdWQPssGSlTfWc4l8=; b=TVodgAXQv+xTQHZdt2rKYeMfVOTOBMl1yTTiaHRGOz6fGYmsBvN0F8bCjlzvrEB4USFwEU iCWjVXInJFw+mSOzqBOoaa3uF64nNHPwXuqma9NQHeEXIKXrAEwaUSN2sF5P0RfhGyeX+m a0U5pCHXOPwICIhj2DrwEtF3ttPy1hk= Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-260-psxe9C5YNsqL2FzB9oGVIw-1; Tue, 10 Jan 2023 11:48:39 -0500 X-MC-Unique: psxe9C5YNsqL2FzB9oGVIw-1 Received: by mail-pf1-f200.google.com with SMTP id x28-20020a056a000bdc00b005826732edb6so5497929pfu.22 for ; Tue, 10 Jan 2023 08:48:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-language:content-transfer-encoding:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lJePnZsKXnubDcGA3DYzaayBveLdWQPssGSlTfWc4l8=; b=H+Srb42Ed+Bf1N7FW2NckZ1h2fBPo3rgcjaIw/+nlQTDlReZ7tqRELKtygRyZSzV1r 9m2i5lSJez3nRBY4EggF4fedbzSRxLU/PS3XupZVRzaAuqZ5szeiwpmiGBTb9qXjy9tS rougmlDBNTcjVL0psFgoHhXxMHkae+VOnHfQ6zXbUuEbOFuHM7wwpwNs9qP3UNmBGPF2 ny++peSrUpWXCU37t4lgMvm4MWIjbglUGrK2mygXcwZEYDt1IDPbHk7NogwWOvtgPCCr Vg46YBM+ZwnSgQFwMSMesnJPkdRvjduA5VQEVDFVN6iEFQWWVw1a6UKEcmDIQXcqCgci aj7A== X-Gm-Message-State: AFqh2kqAcJirRsCxE6gyNZ7u42xAm/VTK4x+Bf038pM3NRZ2olacUzu8 mCVBBVfJ76Lp4uKYwD2BOlBirMADwyeDr+ZEY6Zcul64g9AUadaj5b7e+na023O1jKD28Tnqi0i 6m0hau+6FHjJCIyZvaMTAoTFm X-Received: by 2002:a17:902:8c90:b0:192:a470:2c0b with SMTP id t16-20020a1709028c9000b00192a4702c0bmr36292908plo.49.1673369318520; Tue, 10 Jan 2023 08:48:38 -0800 (PST) X-Google-Smtp-Source: AMrXdXuNUHJUABqba3WYraNADndH3NP90X++/rRyazKN7bjjjbrXyT/4JMDE35Fof+hR07vv+79c1g== X-Received: by 2002:a17:902:8c90:b0:192:a470:2c0b with SMTP id t16-20020a1709028c9000b00192a4702c0bmr36292883plo.49.1673369318177; Tue, 10 Jan 2023 08:48:38 -0800 (PST) Received: from localhost.localdomain (024-205-208-113.res.spectrum.com. [24.205.208.113]) by smtp.gmail.com with ESMTPSA id l7-20020a655607000000b00477bdc1d5d5sm7061400pgs.6.2023.01.10.08.48.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Jan 2023 08:48:37 -0800 (PST) Subject: Re: [PATCH] crypto: initialize error To: Peter Gonda Cc: brijesh.singh@amd.com, thomas.lendacky@amd.com, john.allen@amd.com, herbert@gondor.apana.org.au, davem@davemloft.net, nathan@kernel.org, ndesaulniers@google.com, rientjes@google.com, marcorr@google.com, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev References: <20230110161831.2625821-1-trix@redhat.com> From: Tom Rix Message-ID: Date: Tue, 10 Jan 2023 08:48:33 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/10/23 8:27 AM, Peter Gonda wrote: > On Tue, Jan 10, 2023 at 9:18 AM Tom Rix wrote: >> clang static analysis reports this problem >> drivers/crypto/ccp/sev-dev.c:1347:3: warning: 3rd function call >> argument is an uninitialized value [core.CallAndMessage] >> dev_err(sev->dev, "SEV: failed to INIT error %#x, rc %d\n", >> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> >> __sev_platform_init_locked() can return without setting the >> error parameter, causing the dev_err() to report a gargage > garbage ok > >> value. >> >> Fixes: 3d725965f836 ("crypto: ccp - Add SEV_INIT_EX support") > Should this be: 'Fixes: 200664d5237f ("crypto: ccp: Add Secure > Encrypted Virtualization (SEV) command support")' > > Since in that patch an uninitialized error can be printed? It was a bit of a toss up on who is at fault. This is fine, i'll change this as well. Thanks Tom > +void psp_pci_init(void) > +{ > + struct sev_user_data_status *status; > + struct sp_device *sp; > + int error, rc; > + > + sp = sp_get_psp_master_device(); > + if (!sp) > + return; > + > + psp_master = sp->psp_data; > + > + /* Initialize the platform */ > + rc = sev_platform_init(&error); > + if (rc) { > + dev_err(sp->dev, "SEV: failed to INIT error %#x\n", error); > + goto err; > + } > > > ... > > +static int __sev_platform_init_locked(int *error) > +{ > + struct psp_device *psp = psp_master; > + int rc = 0; > + > + if (!psp) > + return -ENODEV; > + > + if (psp->sev_state == SEV_STATE_INIT) > + return 0; > > > So if !psp an uninitialized error is printed? > >> Signed-off-by: Tom Rix >> --- >> drivers/crypto/ccp/sev-dev.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/crypto/ccp/sev-dev.c b/drivers/crypto/ccp/sev-dev.c >> index 56998bc579d6..643cccc06a0b 100644 >> --- a/drivers/crypto/ccp/sev-dev.c >> +++ b/drivers/crypto/ccp/sev-dev.c >> @@ -1307,7 +1307,7 @@ EXPORT_SYMBOL_GPL(sev_issue_cmd_external_user); >> void sev_pci_init(void) >> { >> struct sev_device *sev = psp_master->sev_data; >> - int error, rc; >> + int error = 0, rc; >> >> if (!sev) >> return; >> -- >> 2.27.0 >>