mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>
To: "max.kellermann@ionos.com" <max.kellermann@ionos.com>
Cc: Alex Markuze <amarkuze@redhat.com>,
	"idryomov@gmail.com" <idryomov@gmail.com>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>,
	"ceph-devel@vger.kernel.org" <ceph-devel@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Xiubo Li <xiubli@redhat.com>
Subject: RE: [PATCH] fs/ceph/addr: always call ceph_shift_unused_folios_left()
Date: Mon, 8 Sep 2025 18:40:38 +0000	[thread overview]
Message-ID: <ecd1c723930ed436a0b85652c95d453254664af3.camel@ibm.com> (raw)
In-Reply-To: <CAKPOu+-HZQa_p3JUXeQY+KZL1yAFK29A6PD2KartKTT6zA785w@mail.gmail.com>

On Fri, 2025-09-05 at 20:35 +0200, Max Kellermann wrote:
> On Fri, Sep 5, 2025 at 7:11 PM Viacheslav Dubeyko <Slava.Dubeyko@ibm.com> wrote:
> > 
> > On Fri, 2025-09-05 at 05:41 +0200, Max Kellermann wrote:
> > > Thanks, I'm glad you could verify the bug and my fix. In case this
> > > wasn't clear: you saw just a warning, but this is usually a kernel
> > > crash due to NULL pointer dereference. If you only got a warning but
> > > no crash, it means your test VM does not use transparent huge pages
> > > (no huge_zero_folio allocated yet). In a real workload, the kernel
> > > would have crashed.
> > 
> > I would like to reproduce the crash. But you've share only these steps.
> > And it looks like that it's not the complete recipe. So, something was missing.
> > If you could share more precise explanation of steps, it will be great.
> 
> The email you just cited explains the circumstances that are necessary
> for the crash to occur.
> 
> Let me repeat it for you: you have to ensure that huge_zero_folio gets
> allocated (or else the code that dereferences the NULL pointer and
> crashes gets skipped).
> 
> Got it now?

Not yet. I would like to see the clear explanation of steps.
Otherwise, the probability to reproduce the crash is equal to zero.

Thanks,
Slava.

  reply	other threads:[~2025-09-08 18:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-27 18:17 Max Kellermann
2025-08-27 19:07 ` Viacheslav Dubeyko
2025-08-28 18:54 ` Viacheslav Dubeyko
2025-08-28 19:05   ` Ilya Dryomov
2025-08-28 19:08     ` Viacheslav Dubeyko
2025-08-28 21:37       ` Max Kellermann
2025-09-04 21:43         ` Viacheslav Dubeyko
2025-09-05  3:41           ` Max Kellermann
2025-09-05 17:11             ` Viacheslav Dubeyko
2025-09-05 18:35               ` Max Kellermann
2025-09-08 18:40                 ` Viacheslav Dubeyko [this message]
2025-09-08 10:32 ` Ilya Dryomov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ecd1c723930ed436a0b85652c95d453254664af3.camel@ibm.com \
    --to=slava.dubeyko@ibm.com \
    --cc=amarkuze@redhat.com \
    --cc=ceph-devel@vger.kernel.org \
    --cc=idryomov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=max.kellermann@ionos.com \
    --cc=stable@vger.kernel.org \
    --cc=xiubli@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®