From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B989C1D9663 for ; Mon, 8 Jun 2026 04:32:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780893160; cv=none; b=aOffkWggyOfxOGBFNsIUOaiSaf1yxDCN7fdUfZANidP3HrLaR7YPaNUbhpkl3Qrju6J++BT9674fL1XSAoeuAZ2CqCDRaPM2YXO/Q1HRc2GAnXDstyR+82LcTQT3Ry2Iz17xyrBIaf0OOuhIOVH3QAlDN6Ab5DqR0i2iu8rCSk0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780893160; c=relaxed/simple; bh=JZpmG6C0+Pi7UOPLxctXabWtx7LNxwJc3AoSsxhRaqg=; h=Message-ID:Date:MIME-Version:Subject:To:References:From:Cc: In-Reply-To:Content-Type; b=E+dPAx1DJUZSo8OK5CXatcwZwL8RnqmSWIiijLdjkZm6lFhXnVmjtei/K8DEZM8HrlZcXs01EsOEeAvax4f6syeZyfNDou5IGqq/794c2MmVPDvXi692R9QzjUDompDD0NN9rFI0bTmBl95HY1TEmbhfCyyH6tJSNIlt/Viku0s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Pu4NH3fB; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=kKnpskRq; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Pu4NH3fB"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="kKnpskRq" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6580GY2f1991549 for ; Mon, 8 Jun 2026 04:32:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= AhE1r+/Z7fVsTmMsF7iSZtgbqyLki//uNGgX9+Uqu0I=; b=Pu4NH3fB3QZanzjY ZtkPCTAEQirUnqtJgso+XYtQtN2XJf1T/KHHHnUIfeRu98HWczrsyfj+s+yVEEd/ JI2pQoydqhsma+K+GMbM3rZFDFsjvT5yWUK4re0b2zR/lncxEsfSa5rR7y9Fwr1e AEE7RI6VtyUjuYNLhSNfGBbdTL9pwzcE0sGovqbuvvKXODnKL/S5S6wLsv26nhJO naQIBiwyQodqm7N6D/VXCDPcIizGQRPYg1XRBK3BQTvQLmoe9znx9WzoaBe3+DDi X9PDKEnyUwOrTjOHFaBOFsl3dxuXA+DvnILtVMa9ut0EFI9BNOPDb/o+LKj3Phfy aUv3Qg== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4em9k3p6sk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 08 Jun 2026 04:32:38 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2c0c331eda3so41639005ad.2 for ; Sun, 07 Jun 2026 21:32:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780893158; x=1781497958; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:cc:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=AhE1r+/Z7fVsTmMsF7iSZtgbqyLki//uNGgX9+Uqu0I=; b=kKnpskRq6wxgd+5eWxGZtcMdb72VNAsNfnheDBgPcRXXr+9eVMU/tVZOs8VAj1mvfo qetckg8+pjAE8ONU9RFQZDFxlSdq69xMaGly85/wZAhFY/ugizZmcM5WjSjM1TOoPELy u8nVEmBqLLvGgM8X9Lgc1DIVqgkdpA43hmP8Q4FWqUtvKXvn8Cls6mr/kSraCu1jpDgu jHmZGE6+WtNrCL3OZPcLsgaOVbTxAiolvm3DyHoXOOhADte6hn65+Di+O33uz2ehju6K fMWvEYewn8H8aSLVAnky1kNP0kBfuV7i9HxNQ7RaNE/LYMtmDh8dM4bLRkIvXk8vOayQ s/nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780893158; x=1781497958; h=content-transfer-encoding:in-reply-to:cc:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AhE1r+/Z7fVsTmMsF7iSZtgbqyLki//uNGgX9+Uqu0I=; b=h7uV/l6lSZiNQegw3YuikIoQuou4F4KVFntxkvqNDTdc+m4pzPwwILuOcLc/a9Og7K bNDOuxpULmrw9xrF0phK2+xQj6v/s4P21GA8vwKdHAZc92X2yaPOURpYnTHoJnlEMuac SGdO2TbDaAesqqw7m6jNcAN0a0QhZYzBKkT4hsU4oiCILN8LCOpUDhVvGavf1kGM4cKY CrBVbhE1TKMuI7G4q3/3IhKnyJD4/UQChHDpu2movDD357ZwsT/z/uoohiFMhpKsiv9/ E9mwwIJJB5MQgDEReq/Cgy0P87OzO7kLfuF3KsdGmHNHucvLW/Np+xoGvswa662NFPTr 9RmA== X-Forwarded-Encrypted: i=1; AFNElJ8zPXGXdT7NpykF30RNU4IV4fLRKNSy4E/vFPLXDbyZqwxaSPJcOQtZudvYGSC+s3v8m9GYcKavMbRy25s=@vger.kernel.org X-Gm-Message-State: AOJu0YxU7gC9bZNg2DbJKyPIKC/QYcg2aNRkcDxogYQTHO2uVunNpplC nm/NUTpqgvZbLXgMQy8QsOnTSBpjuqAPFwYKTHxyv7hJwG9gHekhueTkMs7Y3eJoMP0aS6VwhuZ o5Fer/aBzpR9aPAWeITDQgIsQduP16NGxjyl5PscK4Rq3jhRHN+oQJwkUQ/kAERNCEr0= X-Gm-Gg: Acq92OEdKB+Duyt9eQGTMV4We7olvN86PQGRb1Ajzg7UNxZge4by5KvtV11dhxWZIK2 DFVAFALd+tboCL+NmCMDDQ27Ak/hEyO06B6ysw9ub8wuI7mHHS35wolFsi35QLDpQ5dkB2LcqWI T1tzl87WVh4rhCzuzOgK8MAximxsQ3afRVpPqJKkg6gcgEs/8hvrZkluZadLTYUQIkJGvUAmdcl RJFFjZ6Xc5zu/Ijdb1liSD9tOLqWwjLvD/kUP+B9ZpT4fYkV7kLOCpfvRo/YJj8U+zkr3zMDHX9 v8bGmF/wX5PvmyXCoCiQofo8rQzbo6lVW4QnivnBHO53rTsjiL2BKJCJekexcCIQqptr6kTt3EQ GULZXf+m6Gb/KpNSFc3PFd2KF3jgK0tPwiHa6tsOEQj7U6gNscllqTkjX/PW6r61VYlwU3MdU6C h+BWUQaho3yzU/01Cjso2fLq0OH+4= X-Received: by 2002:a17:903:1a10:b0:2bd:606d:b342 with SMTP id d9443c01a7336-2c1e881ff09mr158867655ad.26.1780893157574; Sun, 07 Jun 2026 21:32:37 -0700 (PDT) X-Received: by 2002:a17:903:1a10:b0:2bd:606d:b342 with SMTP id d9443c01a7336-2c1e881ff09mr158867175ad.26.1780893157068; Sun, 07 Jun 2026 21:32:37 -0700 (PDT) Received: from [10.133.33.209] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c164f890b2sm166345345ad.26.2026.06.07.21.32.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 07 Jun 2026 21:32:36 -0700 (PDT) Message-ID: Date: Mon, 8 Jun 2026 12:32:21 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 3/5] misc: fastrpc: Fail Audio PD init when reserved memory is missing To: Jie Gan References: <20260602071750.526-1-jianping.li@oss.qualcomm.com> <20260602071750.526-4-jianping.li@oss.qualcomm.com> <7e5299fd-85f9-4f74-9e69-5192aca81f05@oss.qualcomm.com> Content-Language: en-US From: Jianping Li Cc: srini@kernel.org, amahesh@qti.qualcomm.com, arnd@arndb.de, Greg KH , abelvesa@kernel.org, jorge.ramirez@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ekansh Gupta , quic_chennak@quicinc.com, stable@kernel.org In-Reply-To: <7e5299fd-85f9-4f74-9e69-5192aca81f05@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA4MDAzNyBTYWx0ZWRfX4rVonzOE/zfA WRYToMwZIGe3yy+Xq5q6mDl9Gh9OPHR+UeHE2zWJTjMIl0D4H5U+8mFkOm3egsf0v/mlKhZEzFh HXF8SY/NbpnwPeZgbFFobQh/ZNLDdlLf5CcKrcPp6Qb1kLN0529u+e5aP5tVsMsEH3Y67/MIHoZ Rwgjfp+n+YI7YqvTi9c6/FEn0ICDNqMpcwnPNYKQidaDgeBqHGQIGIFsZ3p6V/jWwVJpZZGCN88 D02AUl3reOt44ntCpFGDdp5yb3v6+eId1FEX6/AZ408WdPrFHGFEhFOm3pLUqmU7Kq6lcpeNL7C h7ArUaTTR7LqZQNZLjT4KhLKEg4Ikafh9aeBbU39wZ78355pv1xQ2nAeePOsU65Y8JVey5TxAh4 1mz71JwkpGrp97foRYYpEJhA1B7taXp0zUMP+2A8NXeF8AeJgIJcmf9E28yGx7MTen+YmCZfqXi BTwifyssGcPGdWwCy1w== X-Proofpoint-ORIG-GUID: MK8nCEIzk46rrmsi7fbrMJkK4fNgR8Ms X-Proofpoint-GUID: MK8nCEIzk46rrmsi7fbrMJkK4fNgR8Ms X-Authority-Analysis: v=2.4 cv=TIB1jVla c=1 sm=1 tr=0 ts=6a2645e6 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=LuRWb-Sg13DV_SJKcp8A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-08_01,2026-06-05_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 phishscore=0 clxscore=1015 adultscore=0 priorityscore=1501 bulkscore=0 malwarescore=0 suspectscore=0 spamscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606080037 On 6/2/2026 5:25 PM, Jie Gan wrote: > > > On 6/2/2026 3:17 PM, Jianping Li wrote: >> Audio PD static process creation assumes that a reserved-memory >> region is defined in DT and exposed via cctx->remote_heap. >> >> If reserved-memory is missing or incomplete, the driver may pass >> invalid address/size information to the DSP, leading to undefined >> behavior or crashes. >> >> Add explicit validation for remote_heap presence and size before >> sending the memory to DSP, and fail early if the configuration is >> invalid. >> >> Fixes: 0871561055e66 ("misc: fastrpc: Add support for audiopd") >> Cc: stable@kernel.org >> Signed-off-by: Jianping Li >> --- >>   drivers/misc/fastrpc.c | 7 +++++++ >>   1 file changed, 7 insertions(+) >> >> diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c >> index a8a58f889d07..f46a8f53970d 100644 >> --- a/drivers/misc/fastrpc.c >> +++ b/drivers/misc/fastrpc.c >> @@ -1354,6 +1354,13 @@ static int >> fastrpc_init_create_static_process(struct fastrpc_user *fl, >>       } inbuf; >>       u32 sc; >>   +    if (!fl->cctx->remote_heap || >> +        !fl->cctx->remote_heap->dma_addr || >> +        !fl->cctx->remote_heap->size) { >> +        err = -ENOMEM; >> +        dev_dbg(fl->sctx->dev, "remote heap memory region is not >> added\n"); > > should be an error instead of dbg info. > > Thanks, > Jie I will use dev_err to print this log. Thanks, Jianping. > >> +        return err; >> +    } >>       args = kzalloc_objs(*args, FASTRPC_CREATE_STATIC_PROCESS_NARGS); >>       if (!args) >>           return -ENOMEM; >