From: Neil Armstrong <narmstrong@baylibre.com>
To: Arnd Bergmann <arnd@arndb.de>, Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Felipe Balbi <felipe.balbi@linux.intel.com>,
Roger Quadros <rogerq@ti.com>, Lee Jones <lee.jones@linaro.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: dwc3: select CONFIG_REGMAP_MMIO
Date: Mon, 21 Oct 2019 16:19:36 +0200 [thread overview]
Message-ID: <ecd51843-2805-8209-2f72-b2af37bf4e5d@baylibre.com> (raw)
In-Reply-To: <20191021141847.2214613-1-arnd@arndb.de>
On 21/10/2019 16:18, Arnd Bergmann wrote:
> After many randconfig builds, one configuration caused a link
> error with dwc3-meson-g12a lacking the regmap-mmio code:
>
> drivers/usb/dwc3/dwc3-meson-g12a.o: In function `dwc3_meson_g12a_probe':
> dwc3-meson-g12a.c:(.text+0x9f): undefined reference to `__devm_regmap_init_mmio_clk'
>
> Add the select statement that we have for all other users
> of that dependency.
>
> Fixes: c99993376f72 ("usb: dwc3: Add Amlogic G12A DWC3 glue")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/usb/dwc3/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
> index 89abc6078703..556a876c7896 100644
> --- a/drivers/usb/dwc3/Kconfig
> +++ b/drivers/usb/dwc3/Kconfig
> @@ -102,6 +102,7 @@ config USB_DWC3_MESON_G12A
> depends on ARCH_MESON || COMPILE_TEST
> default USB_DWC3
> select USB_ROLE_SWITCH
> + select REGMAP_MMIO
> help
> Support USB2/3 functionality in Amlogic G12A platforms.
> Say 'Y' or 'M' if you have one such device.
>
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
prev parent reply other threads:[~2019-10-21 14:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 14:18 Arnd Bergmann
2019-10-21 14:19 ` Neil Armstrong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ecd51843-2805-8209-2f72-b2af37bf4e5d@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=arnd@arndb.de \
--cc=balbi@kernel.org \
--cc=felipe.balbi@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=rogerq@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®