From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C058DC433F5 for ; Mon, 14 Feb 2022 11:32:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351737AbiBNLco (ORCPT ); Mon, 14 Feb 2022 06:32:44 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:59036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351650AbiBNLai (ORCPT ); Mon, 14 Feb 2022 06:30:38 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 998714925E for ; Mon, 14 Feb 2022 03:13:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644837185; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cd7FfNhaOUqw4MafFCrvctc+5I4/l56rH8rjuuoMQx8=; b=EphOaXML+De4JBnoV8MLtsu1dTXpX7nu0Okpc1fb0oxHJYW3DKnuggN1+7oxGeQf6baVjx RYFcDrZbBW2GlIQNxsa0wA+1JTZNTZuFGYKnAnzqiOrQYOiwKWMk8U9ago7r+uhRHK7N+2 VRaequv/pYkBlrr9p8RTa2usgel9fzw= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-574-IZ39JI6hOb6jbstYH-NwsA-1; Mon, 14 Feb 2022 06:13:04 -0500 X-MC-Unique: IZ39JI6hOb6jbstYH-NwsA-1 Received: by mail-ej1-f69.google.com with SMTP id mp5-20020a1709071b0500b0069f2ba47b20so5618181ejc.19 for ; Mon, 14 Feb 2022 03:13:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=cd7FfNhaOUqw4MafFCrvctc+5I4/l56rH8rjuuoMQx8=; b=LF53UDkbz2jAaZIy+pjV+HqJuVYGCOuIhGUqPvosTPTGgieMb8vqW+/Bxfn7aFKdAP aWmg5Il/TvN5+rfwu8TZRR9y3utFdgs6HRGY2zZR53T0X6YXECFw7a0VRBIRtZhiWxue fAaKVgUdubMl8/6Riou7X0wq6o4M/+mGxRjf4ye8Keqac6DZjG07zAtKll/tIbhbn0C+ PxuOzEIwWME3cQDWio5UrfeXyrrBmSrHnRdTp3BncQRA/judnSSKyypAn+gSLicHfK8u w7FFJQZT2I++2P5KRqtoWNj9JBcg2fLh/0S3EroRuOiWswS08NMz518SFdM9g6uQr2uq 4i6g== X-Gm-Message-State: AOAM531oIMcnYUKHw7iQTKtIFiUteXGFNrmQTogMMmdQkz04izqFR4p1 EqGO18Bim25fNec5l83QH2RmMWwRmvWpcjkXwndCygLJ0+R7HPzI6DaAHKiR/zYsPsyqWbklkID 4MgNiXodTf4A1IMmADB+mtJsd X-Received: by 2002:aa7:d40f:: with SMTP id z15mr11148449edq.357.1644837183434; Mon, 14 Feb 2022 03:13:03 -0800 (PST) X-Google-Smtp-Source: ABdhPJzaDY+IY+Ydj+aXMFKhLtloPk4nt05m+QD+99CTBrzop3qEzQnXTRrUQXMBvsF014QaDo+TYg== X-Received: by 2002:aa7:d40f:: with SMTP id z15mr11148436edq.357.1644837183291; Mon, 14 Feb 2022 03:13:03 -0800 (PST) Received: from [10.40.98.142] ([78.108.130.194]) by smtp.gmail.com with ESMTPSA id z5sm10405008eja.20.2022.02.14.03.13.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Feb 2022 03:13:02 -0800 (PST) Message-ID: Date: Mon, 14 Feb 2022 12:13:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH] fix linux 5.16 freeze regression on 32-bit ThinkPad T40 Content-Language: en-US To: Woody Suwalski , linux-pm@vger.kernel.org, LKML , "Rafael J. Wysocki" References: <80742062-8629-3978-e78d-92ffc9bb2e0b@gmail.com> From: Hans de Goede In-Reply-To: <80742062-8629-3978-e78d-92ffc9bb2e0b@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2/9/22 22:05, Woody Suwalski wrote: > From: Woody Suwalski > > Add and ACPI idle power level limit for 32-bit ThinkPad T40. > > There is a regression on T40 introduced by commit d6b88ce2, starting with kernel 5.16: > > commit d6b88ce2eb9d2698eb24451eb92c0a1649b17bb1 > Author: Richard Gong > Date:   Wed Sep 22 08:31:16 2021 -0500 > >     ACPI: processor idle: Allow playing dead in C3 state > > The above patch is trying to enter C3 state during init, what is causing a T40 system freeze. I have not found a similar issue on any other of my 32-bit machines. > > The fix is to add another exception to the processor_power_dmi_table[] list. > As a result the dmesg shows as expected: > >     2.155398] ACPI: IBM ThinkPad T40 detected - limiting to C2 max_cstate. Override with "processor.max_cstate=9" > [    2.155404] ACPI: processor limited to max C-state 2 > > The fix is trivial and affects only vintage T40 systems. > > Signed-off-by: Woody Suwalski > --- Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- a/drivers/acpi/processor_idle.c    2022-02-04 09:09:54.515906362 -0500 > +++ b/drivers/acpi/processor_idle.c    2022-02-04 14:21:08.264911271 -0500 > @@ -96,6 +96,11 @@ static const struct dmi_system_id proces >        DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK Computer Inc."), >        DMI_MATCH(DMI_PRODUCT_NAME,"L8400B series Notebook PC")}, >       (void *)1}, > +    /* T40 can not handle C3 idle state */ > +    { set_max_cstate, "IBM ThinkPad T40", { > +      DMI_MATCH(DMI_SYS_VENDOR, "IBM"), > +      DMI_MATCH(DMI_PRODUCT_NAME, "23737CU")}, > +     (void *)2}, >      {}, >  }; > >