From: Tom Rix <trix@redhat.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: balbi@kernel.org, gregkh@linuxfoundation.org, joel@jms.id.au,
andrew@aj.id.au, nicolas.ferre@microchip.com,
alexandre.belloni@bootlin.com, claudiu.beznea@microchip.com,
alcooperx@gmail.com, christophe.jaillet@wanadoo.fr,
cai.huoqing@linux.dev, benh@kernel.crashing.org,
neal_liu@aspeedtech.com, miles.chen@mediatek.com,
balamanikandan.gunasundar@microchip.com,
macpaul.lin@mediatek.com, s.shtylyov@omp.ru,
jakobkoschel@gmail.com, stern@rowland.harvard.edu,
quic_wcheng@quicinc.com, yashsri421@gmail.com,
rdunlap@infradead.org, linux-geode@lists.infradead.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org,
bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH] usb: gadget: udc: clean up comments
Date: Mon, 11 Apr 2022 04:49:00 -0700 [thread overview]
Message-ID: <ecd8609b-2c52-5fb8-7820-191559d76011@redhat.com> (raw)
In-Reply-To: <YlQBgnjpkSurf9PZ@smile.fi.intel.com>
On 4/11/22 3:22 AM, Andy Shevchenko wrote:
> On Sun, Apr 10, 2022 at 11:08:28AM -0400, Tom Rix wrote:
>> SPDX
>> *.h use /* */ style comments
>>
>> For double words, remove
>> with, also
>>
>> Spelling replacements
>> wayt to way
>> wakup to wakeup
>> Contrl to Control
>> cheks to checks
>> initiaization to initialization
>> dyanmic to dynamic
> Something really wrong with indentation above.
>
> ...
>
>> drivers/usb/gadget/udc/amd5536udc.h | 2 +-
>> drivers/usb/gadget/udc/aspeed-vhub/core.c | 2 +-
>> drivers/usb/gadget/udc/aspeed-vhub/ep0.c | 2 +-
>> drivers/usb/gadget/udc/aspeed-vhub/hub.c | 2 +-
>> drivers/usb/gadget/udc/aspeed-vhub/vhub.h | 4 ++--
>> drivers/usb/gadget/udc/at91_udc.c | 2 +-
>> drivers/usb/gadget/udc/bdc/bdc_core.c | 4 ++--
>> drivers/usb/gadget/udc/core.c | 4 ++--
>> drivers/usb/gadget/udc/trace.h | 2 +-
> I believe that Greg's bot asks to split on per-driver basis.
> OTOH I don't see anything that can be problematic if in one
> change. So, it's up to maintainers then.
Yes, whatever folks want. I can split these.
I have been cleaning up the comments in other areas and am trying to
strike a balance between too big of a patch vs peppering with many
single changes.
Tom
>
> ...
>
>> --- a/drivers/usb/gadget/udc/amd5536udc.h
>> +++ b/drivers/usb/gadget/udc/amd5536udc.h
>> * amd5536.h -- header for AMD 5536 UDC high/full speed USB device controller
> At the same time you may drop the filename(s) from the file(s) as this very
> one shows why it's good not to have a filename inside file.
>
next prev parent reply other threads:[~2022-04-11 11:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-10 15:08 Tom Rix
2022-04-10 15:18 ` Greg KH
2022-04-11 10:22 ` Andy Shevchenko
2022-04-11 11:49 ` Tom Rix [this message]
2022-04-11 12:24 ` Greg KH
2022-04-11 12:54 ` Tom Rix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ecd8609b-2c52-5fb8-7820-191559d76011@redhat.com \
--to=trix@redhat.com \
--cc=alcooperx@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@aj.id.au \
--cc=andriy.shevchenko@linux.intel.com \
--cc=balamanikandan.gunasundar@microchip.com \
--cc=balbi@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=benh@kernel.crashing.org \
--cc=cai.huoqing@linux.dev \
--cc=christophe.jaillet@wanadoo.fr \
--cc=claudiu.beznea@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=jakobkoschel@gmail.com \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-geode@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=macpaul.lin@mediatek.com \
--cc=miles.chen@mediatek.com \
--cc=neal_liu@aspeedtech.com \
--cc=nicolas.ferre@microchip.com \
--cc=quic_wcheng@quicinc.com \
--cc=rdunlap@infradead.org \
--cc=s.shtylyov@omp.ru \
--cc=stern@rowland.harvard.edu \
--cc=yashsri421@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®