From: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
To: Sasha Levin <sashal@kernel.org>,
Madhavan Srinivasan <maddy@linux.ibm.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Shrikanth Hegde <sshegde@linux.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
"Christophe Leroy (CS GROUP)" <chleroy@kernel.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] powerpc/irq: Fix build with CONFIG_PROC_FS=n
Date: Sat, 24 Oct 2026 05:39:30 +0530 [thread overview]
Message-ID: <ecdg558l.ritesh.list@gmail.com> (raw)
In-Reply-To: <20261023211503.3764302-1-sashal@kernel.org>
Sasha Levin <sashal@kernel.org> writes:
> Commit fbb22ceaaf8f ("powerpc/irq: Make irqstats array based") made
> arch_show_interrupts() call irq_proc_emit_counts(). That function lives
> in kernel/irq/proc.c, which is only built with CONFIG_PROC_FS, so
> kernels without procfs no longer link:
>
> powerpc64-linux-ld: arch/powerpc/kernel/irq.o: in function `arch_show_interrupts':
> arch/powerpc/kernel/irq.c:134:(.text+0x4b8c): undefined reference to `irq_proc_emit_counts'
>
> arch_show_interrupts() is only called from irq_seq_show(), which is in
> kernel/irq/proc.c as well, so build it only with CONFIG_PROC_FS, as x86
> already does.
>
> Fixes: fbb22ceaaf8f ("powerpc/irq: Make irqstats array based")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202609271531.8kf2NTjK-lkp@intel.com/
Looks like it still slipped through.
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> ---
Change looks good to me. Thanks Sasha for fixing it.
-ritesh
next prev parent reply other threads:[~2026-10-24 0:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-21 4:49 [GIT PULL] Please pull powerpc/linux.git powerpc-7.4-1 tag Madhavan Srinivasan
2026-10-22 18:31 ` pr-tracker-bot
2026-10-23 21:15 ` [PATCH] powerpc/irq: Fix build with CONFIG_PROC_FS=n Sasha Levin
2026-10-23 23:50 ` Linus Torvalds
2026-10-24 0:09 ` Ritesh Harjani [this message]
2026-10-24 7:30 ` Shrikanth Hegde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ecdg558l.ritesh.list@gmail.com \
--to=ritesh.list@gmail.com \
--cc=chleroy@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lkp@intel.com \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=sashal@kernel.org \
--cc=sshegde@linux.ibm.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®