From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7428D3B8D4D for ; Tue, 6 Jan 2026 18:05:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767722729; cv=none; b=AqxLA1HxaPZ9F/IUNJXlgw6s01BIEtuwp+3yYU6hnYd5sdQ35Ves0mh3QYTp0b5lY3IAN/zV6oQ/JG9AhpGM1wBW18JwqvnnJHmKW7VINz1dKlAN6CC+BEWmpVOypm5HQaYYoSQElJWiW6YKZ3xV/Pqt+ltSxVcGPiWn7ZJ0xUE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767722729; c=relaxed/simple; bh=u4Ucw346p0LskE2Agd4cJRPVq6GJdLEmyHn4EWRgWi8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PHT7/poMB+DBN179vGYLMzcPCEmSgR57e4xFLGybY133EhmM50LfWVi05djXRkQhJ5cUG6/UAWYZrY/oWu/jKrRGYdepP30gWt0EUsr9374IXyFC42VeNZqRqOys0iG3lDxm+YEoHGKikguN9Lmr3pNfUuxE53O2unqNYQKF/N0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=LLPPreo1; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=g6ol/unq; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="LLPPreo1"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="g6ol/unq" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 606EfkKn322873 for ; Tue, 6 Jan 2026 18:05:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= AxdnYtkQsJk/Nx0EcAu08x9Bd7auZ3nLxm9/Y46BzGo=; b=LLPPreo1Kq+ql8mD gM6JoQxZI4oP6sphNDmzjcS9c1t2Bhtn8vF3N72RlhkOKE42YkZsWwBcBl1UHcCc TWsRS/PjzFE8jDl66XcFusU7bd+8FY84RAEXW6ngcLQuupdFGzHqk//cH011f8El qc2lOcN5Ia4GhFX4KJJGSkB5h+/sFXJ4HPh1zqHdMv1ixFuG3GKYFj1N/pl1yqF9 wbzFstqXR2jgoUd0dSRaUvS+t86HqdqcR7msoypInpYqpEcO3mjXKHuh9ltA6XMI RUHg2nWXrafh9ILhzD+4FezlBIyEnRZ6dyF7iPzOOl5nM38M/L6Gtd8pLH0XO8O5 68nPvA== Received: from mail-dy1-f198.google.com (mail-dy1-f198.google.com [74.125.82.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bh4crgmpy-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 06 Jan 2026 18:05:26 +0000 (GMT) Received: by mail-dy1-f198.google.com with SMTP id 5a478bee46e88-2ae546fa935so2150707eec.1 for ; Tue, 06 Jan 2026 10:05:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767722726; x=1768327526; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=AxdnYtkQsJk/Nx0EcAu08x9Bd7auZ3nLxm9/Y46BzGo=; b=g6ol/unq+u6bx7yIbfBIBtkBFAic09bPPjdSAXyVqAYLEURuehBBmUzHruIKis0uuV 8wUDoEASfEibGlQPFQoEpNXIxXQx13DWNdq2zA+SOQTrWpMdLvtEOZ9a0vPM+nqtaHnS 74LqoSqLxuf5y5+M/ShjXx9/gJOleFaSM1pYBj3034F6zunu+g7qkb7PZUBhrVw3Jh5f czPDvRoDQ+F+Y25MNobb5s3wrQu2kAOc0MqEoQkKopHaqgC5G3k5JRNFUDbFTCcbO2IH XDdOWm6l1KWfG8oufz7jEsB8GEXUy7jH1Jx7heEQ8tTdNwu3ht3wktINelRPOPnzs6hu XNXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767722726; x=1768327526; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AxdnYtkQsJk/Nx0EcAu08x9Bd7auZ3nLxm9/Y46BzGo=; b=vrW3TeSNMpRrC1fGtEjDGlAwn/p8edmnKVubhILwrareriRX6mb3IsYDF9A4KHa9Qv ftO/qgUxRVsphJCCO6Peusv/olTLT0XNZt4uOwzw3BXm83tBv8Ufi+iYDkE5SZ1PzdJn OGOx/05kNRCRhIq0H8aKkvudsAt7TRv0tQv16cENXWo2nPzNs4R3tGVBjBouRqxLcda4 A4qDEhCwM4W+59RlHaY7R8snk5zVWq5fIf9cjVHWM9ASlDg3V3bmpQ4BbKpA2Rvm9IZC MnfJYWnEXi8tgwuwwqHhgoozuw3QVQtvdDOGtfMSNFrIkghwIbuOyNUgWviAinTI04dK mSbg== X-Forwarded-Encrypted: i=1; AJvYcCVKwuliazpI5GvuyNg7hRYTY935uDhJXSfafqXhMUkha325+LE7oIYFWrn1abCNOso3Sjbo+tRZN1wObkA=@vger.kernel.org X-Gm-Message-State: AOJu0YwMo3YNns/CA+y4xSiJhtSyd95bq2KozvG8/MfDRvLgattFISjj DT62Lohyq+wgoUACUyA5mZBaCrUuPoTCQRQ4bidiKF5f5Wf3JNCGXm1UJ+ybMZEuLud0dTHzxez SHmhfJbBMsmiinssk/XYtl3pz0GzbLhIRLgdyiavOV8bASpaSlrGPKj11vFwKk/qliSc= X-Gm-Gg: AY/fxX7tlwO7wZN0yJzyENCzxhlTzn1avvOUjd3S+atHv7dBHXp71+vsBf0AQYpiIYG knOvI+NMURFlZw3t6x2mQG+Mf+fyfXBH++vV0VSFeJw9sHyKBmjLjb4l/EKN/zOeBHb8S2vFzhi N224pP87ob5yns2mIwGlV3kfw0VxbeBTVqUdxDYrPovQQ1hyHqJWhRrXGVwj/T2SKDjh4Ohuhsv l+L8KTgIwBRXu4z9iH8qcK0u3+hikSzhFQtAlv5yuEgnfKMmUaOlRGXrhEz7fpSmx4pI1K51pOu hLz8mZTiif768Vg2EFU3Gql/6K/6y+Yw3JS/Eyt3KZC94j5ZjZltTUouVvEEdfU/ROkatFrvXtg qsLUATefYni+gRZI0MqIspt7jPyKhF/kLMdvH9YrQ7d1y X-Received: by 2002:a05:7301:4715:b0:2a4:3593:646a with SMTP id 5a478bee46e88-2b16f906b28mr2324267eec.26.1767722725816; Tue, 06 Jan 2026 10:05:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IGPmT/G9mHw1vDU2raXA+OeKBLh9EW3Uit++Kb5XbJqJTvaJem5/JDrr8t0ZlJgydfxs/Tk0w== X-Received: by 2002:a05:7301:4715:b0:2a4:3593:646a with SMTP id 5a478bee46e88-2b16f906b28mr2324233eec.26.1767722725225; Tue, 06 Jan 2026 10:05:25 -0800 (PST) Received: from [172.20.10.12] ([172.56.240.157]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b1707b0b2bsm4208772eec.23.2026.01.06.10.05.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Jan 2026 10:05:24 -0800 (PST) Message-ID: Date: Tue, 6 Jan 2026 10:05:22 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/7] media: qcom: camss: csiphy: Add support for v2.3.0 two-phase CSIPHY To: Krzysztof Kozlowski , Hangxiang Ma Cc: Loic Poulain , Robert Foss , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Todor Tomov , Vladimir Zapolskiy , Mauro Carvalho Chehab , Bryan O'Donoghue , linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, jeyaprakash.soundrapandian@oss.qualcomm.com References: <20251126-add-support-for-camss-on-sm8750-v1-0-646fee2eb720@oss.qualcomm.com> <20251126-add-support-for-camss-on-sm8750-v1-4-646fee2eb720@oss.qualcomm.com> <20251127-terrestrial-arboreal-bird-5a6d9b@kuoka> Content-Language: en-US From: Vijay Kumar Tumati In-Reply-To: <20251127-terrestrial-arboreal-bird-5a6d9b@kuoka> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=V9FwEOni c=1 sm=1 tr=0 ts=695d4ee6 cx=c_pps a=wEP8DlPgTf/vqF+yE6f9lg==:117 a=J3Fo5nLEaHaPiRlpdRcYgw==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=pAwv9sAArZx2eUU7DzAA:9 a=QEXdDO2ut3YA:10 a=bBxd6f-gb0O0v-kibOvt:22 X-Proofpoint-ORIG-GUID: cWzx24QizcsUOq9JK6mpx9i2Dy723kVN X-Proofpoint-GUID: cWzx24QizcsUOq9JK6mpx9i2Dy723kVN X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTA2MDE1NiBTYWx0ZWRfX29Ub6gdLbS8b t9ndjRur8XyblQxI7onwky8xHkxk6sfllYYtt/SGnnnaSTYFZ6GB37EmgrXQeHH+bkk6GNDpCkv bBNGcBTTPdq7KKJduV+mtrDzIQbjf8XTla816hOzcu8JWbpNZ8BwDhj+UEiB0qNEcPK5NSfrZNz /38p6OJUYcfmmVct+k07ZMX8aHMDO0yjcxzMoQMJMQ1wTXQfU2rjp2aZoNmenaQKnwUuxM0FXp3 SM4S77v5gFWNosg9/b5M8s6Zq+Vfs8BEGBFu/J2Dv3d3GUSTe6wjFYKLLChmjE+hNrsI264UQBw JDbNGJUB+OXG90hhZbVIifFbVC5oAsgC/54g2BV+mT8Sgdo4DN+Jmr36ZWvYPEeiLUewqhQcuCg dRetzvP+wUOmyACdqJ1rSV4T9WU7A6pp7XWi2bccUue5dRlGIY1fYH/EPYYbL0N0uLWhh4a70sx hGNP4GWGmelw2+d3B3Q== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-06_01,2026-01-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 priorityscore=1501 suspectscore=0 phishscore=0 bulkscore=0 adultscore=0 malwarescore=0 spamscore=0 clxscore=1015 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601060156 On 11/27/2025 12:14 AM, Krzysztof Kozlowski wrote: > On Wed, Nov 26, 2025 at 01:38:37AM -0800, Hangxiang Ma wrote: >> Add more detailed resource information for CSIPHY devices in the camss >> driver along with the support for v2.3.0 in the 2 phase CSIPHY driver >> that is responsible for the PHY lane register configuration, module >> reset and interrupt handling. >> >> Additionally, generalize the struct name for the lane configuration that >> had been added for Kaanapali and use it for SM8750 as well as they share >> the settings. >> >> Signed-off-by: Hangxiang Ma >> --- >> .../platform/qcom/camss/camss-csiphy-3ph-1-0.c | 11 ++- >> drivers/media/platform/qcom/camss/camss.c | 107 +++++++++++++++++++++ >> 2 files changed, 114 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c >> index f9db7e195dfe..157e946f67db 100644 >> --- a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c >> +++ b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c >> @@ -684,9 +684,9 @@ csiphy_lane_regs lane_regs_sm8650[] = { >> {0x0c10, 0x52, 0x00, CSIPHY_DEFAULT_PARAMS}, >> }; >> >> -/* 3nm 2PH v 2.4.0 2p5Gbps 4 lane DPHY mode */ >> +/* 3nm 2PH v 2.3.0/2.4.0 2p5Gbps 4 lane DPHY mode */ >> static const struct >> -csiphy_lane_regs lane_regs_kaanapali[] = { > There is no such line in next. Your cover letter does not explain > dependencies. Will do. Thanks. > >> +csiphy_lane_regs lane_regs_v_2_3[] = { > Best regards, > Krzysztof >