From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3960D34B661 for ; Fri, 13 Feb 2026 11:14:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770981256; cv=none; b=m+sb9s1aWL5yNWZv7dI/kTPFWkyzSLW87GyLbVPY157CDvvZu80phsorg4fZKrUGyybxVpzS3o3HZdSoo0VJxm0vH1Uti8r91S6iYKtHrhnFX73clJpHYO2l2OH0Dg9XrHRZ9U3taJujt1E1y0Fp43fGiY/FYa9C7lcSb5iY0rw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770981256; c=relaxed/simple; bh=a28rbnnIyfM2Q7sOoR/5JlN04Cll5610C+c1yHTmtQI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lt2QL0jUrwTGMwp6yXP2uvpK+uMWUxwBsN3WVoSCx30VDQ+6fw5k7+L1ncBJyZxXtb6iOqvHIdroteefUPc0m+LMfWDq4tsrD/A6Y2tJx+va5XDqZGW3XS4DZUoL/gbqlVqsIu+t/7BUjUqgfqcbPlRXzHuEjUdcfus9TRy/gy0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZKUd9Pfr; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Mcwk/PSt; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZKUd9Pfr"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Mcwk/PSt" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61D4sDvJ455012 for ; Fri, 13 Feb 2026 11:14:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Kf0MsnTl1MoxPVgGzu+Koh9phahROaNevqsbTzSVCnM=; b=ZKUd9Pfr0yxAL1GI MQSRCEhfkJglu9+6nNnDw5kpHryplPFl53WMA/qoIMCowX/G0zTkF1XMlIP/SiHG Zc3pR1WkzfdZkc6dVj/ip1yi7mvUmBJYMVp2+xNIXhazPlfDSIHIeRbiz3wrcyaR ktaQRXbnUK7R1i8sH7GSJi8vpGLOj7GKI5/VFZdlJC+S8rfCRUz+rzyqm3QZPpUh 6PJYNyEEm4JKuK+6axhVdWtGrXFGgbI8AD4EWXcWPikg/c5xS4igZCqXM5vSN0XF SxyqoNDUBk66OWHMom29rSpj9a5SWK6dDC2Tl8Kqzx/sQd+Q0P+oBeecrSoBXrem yiW1PQ== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c9mev337h-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 13 Feb 2026 11:14:14 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8cb39de5c54so39034185a.0 for ; Fri, 13 Feb 2026 03:14:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770981253; x=1771586053; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Kf0MsnTl1MoxPVgGzu+Koh9phahROaNevqsbTzSVCnM=; b=Mcwk/PStO8GoyzgR3zZmvBixvNvJck2Zl+skDLyt0qT0lA4cB/VQ9aTCYZjUXQCPGF e2Z/FCKxrglA8XpcYgkXQpzAw4K+uT4gDMfWWhdsKlIycCeb6N85VB2nLVlE8dTwAcYT HZ8Z0HTHq6CyC6ebRFywNxXQpLIk7vWBd8Ew0ORWY+HyP4KotAqZNK+SVoDsOcCMhdSt +3cgoY/gb8W84QLVfOrIQd3eDrOh3iIBeyApafWxDvkG+OZgX60jnVlxwNMOx+K9GkZy IIVHAGGCtxKzVEARmu/RnIPVNCKaabqoCQxOtivZ9nQiyAeKg3ZsOBivyQUABCKzIMTA Q4nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770981253; x=1771586053; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Kf0MsnTl1MoxPVgGzu+Koh9phahROaNevqsbTzSVCnM=; b=vMRyToXBgxoz7F5VbMpbWhWNw8EV67OAg0FWepTM5yy79oXOaKvk5xpJkCFFUTiwGo 9qV8esFm+NOVVRX5k6AMUmB+jrMcZmN5bc4eP4BsXfzDqNmfMnwk8a6ZnMz9BG87EUEF TKU0vYGQGkExZi7PWIBFdJDvjZrYjSq6lmq4sFJR9DgtmsTbuVw9A6Pccwdk/fnFlS2V s1JFdeSdRqAoD0zgKkZSnQs+pE79jxH1HE0q0ZZXhD2u6OU4wv/4vNqIxq7YyiEaQJB0 H1jZdwbzkyzWutvVMT0p4ddz+ziDjgW0dVNFuX7EE18u3J5Rpnj8aPWarhzXlC7Dvp3p f2mQ== X-Forwarded-Encrypted: i=1; AJvYcCXLpsGrPNM1fQPjo8aBYLd9mmENwZK7k24IxuMddQ1UdXSJKM1Yg2bpZtecOynqc16SoKK+RhRmuY0eilY=@vger.kernel.org X-Gm-Message-State: AOJu0Yx596uMnq1c2PvEKG+VDSQ3J/snc8ZwesIyBTGwAglxxxOhnR6X my8vIb8Gey7B2TrjHBVOhvGYmnqpYbK39vxUo58V1hy8DbM1HE542xnxF1sSHd3aEV3dgtWPmPo pvw3tViwyLG0UZNdIPAsMhuutaCoZVBq9TYK0xXrXz1/i/Secd04dGq9ljE3fZZaILBc= X-Gm-Gg: AZuq6aKoqXr4TEeJ+ajRWVw0P1Z8UKjoJtVCDkKJdxO8/SXvEPKW2i9q+5oobgDDqLW TY4TloZMg0Pny2Rlw4Q5yQdjQlm4rvDeN2yvP3/Cs0uJblT/BlCciQKozxEZBUXK1CY46+qhMkE iz96sTASRVzG/Ew3Ar6czneGjqRAGXkSpWlsHhBzJoS8ycm5D5EDF5lK6yEdTdr9NVXFjgBUKEv Pj5H1uFRMNGfV88n1Ia5B3TFkw40ckBa4+TajlMXB0D7qH8A60t1/CU6WejUx6SerqQANOUncFy dK+mvQ4ZFCMPM8WSvJPhNDN7V6BWKWlm7EnjO9bHyj4WINoHZb9cFIMvEOa16fVe7HU8tk/auI9 81AfaMG5jZCdpnCqZL2zcowmKWSzlVnePC4wFw85aJ0EWKyDkNRFiQ5i3Ir9lv6s3VBspnUsvpU xrKT0= X-Received: by 2002:a05:620a:454f:b0:8ca:2e7:56c5 with SMTP id af79cd13be357-8cb40916695mr184541485a.11.1770981253584; Fri, 13 Feb 2026 03:14:13 -0800 (PST) X-Received: by 2002:a05:620a:454f:b0:8ca:2e7:56c5 with SMTP id af79cd13be357-8cb40916695mr184538585a.11.1770981253134; Fri, 13 Feb 2026 03:14:13 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8f6eca3f67sm243715966b.59.2026.02.13.03.14.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Feb 2026 03:14:12 -0800 (PST) Message-ID: Date: Fri, 13 Feb 2026 12:14:10 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] phy: qcom: edp: Add per-version LDO configuration callback To: Yongxing Mou , Vinod Koul , Neil Armstrong , Dmitry Baryshkov Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260205-edp_phy-v1-0-231882bbf3f1@oss.qualcomm.com> <20260205-edp_phy-v1-2-231882bbf3f1@oss.qualcomm.com> <200b055b-7221-45b5-aea1-2462e07a3c1c@oss.qualcomm.com> <8dbc18a0-6a64-491b-84b0-ba220c9050ac@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <8dbc18a0-6a64-491b-84b0-ba220c9050ac@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=Zq7g6t7G c=1 sm=1 tr=0 ts=698f0786 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=EUspDBNiAAAA:8 a=cNRGMQsWfAapTQTvfRUA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-ORIG-GUID: D97ipHqiuABC8CWAhwoF8KDyOi8CpUA7 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjEzMDA4NiBTYWx0ZWRfX5p23UlS+KBJo pgFn+7q0Kme5A9m8V3IubZ3xApeRyQqC8km3tveuof7f+9nNiaUxSkcXmf0aNIrnKh9ILgOpTrZ cpcqLokhlV4jLSlDNgNHbLymvYewun5r+ul1ob60Dtnl1htDozjHAr0ZpaA+PIL855quPw5Wj+m a1eYrE0cb+cLLY5Qkg4fPFRpr3rvqEH0Ig8fFBerawAStqh8WWGOk9d46e7AUx8rDMvRkQo0740 ADnuL86sCZGQiNagU7dMl4GS1Eu93UO/Xy7QPb9B3JJ7ji9hs2vbEZDy4jbI6By5ZaqRfJz05Np WzgKnkvhYtJJyDJqp3jqlO9oJE/dGrsaZARE5wme1JJWHDNVMR/qxambYHHguzNrrwwgsifcFwE Qw+N9xAq3ny3xORyvgpiwo4FWSnVITRvNDdi1uvvJfESEthy1rI9NtcAvWEe7ROiYANPfwELiy8 QUbekEZJ/TCUR8k9c1w== X-Proofpoint-GUID: D97ipHqiuABC8CWAhwoF8KDyOi8CpUA7 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-13_01,2026-02-12_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 adultscore=0 priorityscore=1501 impostorscore=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602130086 On 2/12/26 10:04 AM, Yongxing Mou wrote: > > > On 2/6/2026 6:52 PM, Konrad Dybcio wrote: >> On 2/5/26 10:20 AM, Yongxing Mou wrote: >>> Introduce the com_ldo_config callback to support per‑PHY LDO >>> configuration. >>> >>> Signed-off-by: Yongxing Mou >>> --- >> >> [...] >> >>> +static int qcom_edp_ldo_config_v4(const struct qcom_edp *edp) >>> +{ >>> +    const struct phy_configure_opts_dp *dp_opts = &edp->dp_opts; >>> +    u32 ldo_config; >>> + >>> +    if (!edp->is_edp) >>> +        ldo_config = 0x0; >>> +    else if (dp_opts->link_rate <= 2700) >>> +        ldo_config = 0xC1; >> >> lowercase hex, please >> >>> +    else >>> +        ldo_config = 0x81; >>> + >>> +    writel(ldo_config, edp->tx0 + TXn_LDO_CONFIG); >>> +    writel(ldo_config, edp->tx1 + TXn_LDO_CONFIG); >> >> tx1 should be dp_ops->lanes ? 2 : ldo_config : 0x00, in all cases, >> I believe >> >> Konrad > Hi, here i want to confirm again.. In the HPG main link brinup sequence, it not say write TX0/TX1 ldo_config based on the lane count. Only when we switch the lane mode,  the LDO config will be updated according to the lane count. so here do we really need this condition? I don't believe these two cases are differentiated in your patch, unless you're trying to say that the hardware is smart enough to turn off the LDO for TX23 on its own as we switch modes, which I wouldn't bet it is and can't find confirmation for Konrad