From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEB98C433EF for ; Fri, 1 Oct 2021 23:22:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9661861A7B for ; Fri, 1 Oct 2021 23:22:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231660AbhJAXYh (ORCPT ); Fri, 1 Oct 2021 19:24:37 -0400 Received: from mga11.intel.com ([192.55.52.93]:64062 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231265AbhJAXYe (ORCPT ); Fri, 1 Oct 2021 19:24:34 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10124"; a="222408556" X-IronPort-AV: E=Sophos;i="5.85,340,1624345200"; d="scan'208";a="222408556" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Oct 2021 16:22:49 -0700 X-IronPort-AV: E=Sophos;i="5.85,340,1624345200"; d="scan'208";a="480787586" Received: from schen9-mobl.amr.corp.intel.com ([10.134.109.23]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Oct 2021 16:22:47 -0700 Message-ID: Subject: Re: [PATCH RESEND 0/3] Represent cluster topology and enable load balance between clusters From: Tim Chen To: Peter Zijlstra , Vincent Guittot Cc: Barry Song <21cnbao@gmail.com>, Dietmar Eggemann , LKML , Ingo Molnar , Aubrey Li , Borislav Petkov , Daniel Bristot de Oliveira , Ben Segall , Catalin Marinas , Greg Kroah-Hartman , Guodong Xu , "H. Peter Anvin" , Jonathan Cameron , Juri Lelli , "Cc: Len Brown" , ACPI Devel Maling List , LAK , Linuxarm , Mark Rutland , Mel Gorman , msys.mizuma@gmail.com, "Zengtao (B)" , "Rafael J. Wysocki" , Steven Rostedt , Barry Song , Sudeep Holla , Thomas Gleixner , "Rafael J. Wysocki" , Valentin Schneider , Will Deacon , x86 , yangyicong Date: Fri, 01 Oct 2021 16:22:46 -0700 In-Reply-To: References: <20210924085104.44806-1-21cnbao@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.4 (3.34.4-1.fc31) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2021-10-01 at 16:57 +0200, Peter Zijlstra wrote: > On Fri, Oct 01, 2021 at 12:39:56PM +0200, Vincent Guittot wrote: > > Hi Barry, > > > > On Fri, 1 Oct 2021 at 12:32, Barry Song <21cnbao@gmail.com> wrote: > > > Hi Vincent, Dietmar, Peter, Ingo, > > > Do you have any comment on this first series which exposes > > > cluster topology > > > of ARM64 kunpeng 920 & x86 Jacobsville and supports load balance > > > only for > > > the 1st stage? > > > I will be very grateful for your comments so that things can move > > > forward in the > > > right direction. I think Tim also looks forward to bringing up > > > cluster > > > support in > > > Jacobsville. > > > > This patchset makes sense to me and the addition of a new > > scheduling > > level to better reflect the HW topology goes in the right > > direction. > > So I had a look, dreading the selecti-idle-sibling changes, and was > pleasantly surprised they're gone :-) > > As is, this does indeed look like something mergable without too much > hassle. > > The one questino I have is, do we want default y? I also agree that default y is preferable. > > The one nit I have is the Kconfig text, I'm not really sure that's > clarifying what a cluster is. Do you have a preference of a different name other than cluster? Or simply better documentation on what a cluster is for ARM64 and x86 in Kconfig? Thanks. Tim