From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B7C7246778 for ; Mon, 23 Mar 2026 16:26:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774283170; cv=none; b=l61cpAxAGOAllV4EYugEgzHOoGpVO/tkL+uY7KT5I7rW35gGkrZ6PdHx6abER/7mRQywaeFgfDz+/x6Kvs3qQGRw0sfwo4qSapsSDu1ki3ZLA4eZahBjEQ5fUJtL+DMoSrHj6KDXeOEgnS2KZAXyE9cpofzIxUaWWrcVg1GnR1k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774283170; c=relaxed/simple; bh=RipYnVT+ThCFIlJ374YWkAW0MCF1qLEY1u8YX+IULI8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=s/GAoPF5yg9zbcm+4twK586IwxXubIQnUs5gdQ0GJViwv32lR7EYJm69UovZYUq2HziGeD9xOFpGloKMGe3UD5c0vtz9Y/GfcbcxYiCOtgLcOr2lVyCWjQ5ApJ+iLCxLqWOulQK9ZVnk1Baw7/WI3gEquQZA7yjxlXXmWll/LH4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IJACb4WY; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=UPBSGr/n; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IJACb4WY"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="UPBSGr/n" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62NFHpHC1423358 for ; Mon, 23 Mar 2026 16:26:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= JNjoxb/miPYUITIblVuJDVboPKpzuzXYI3UEyOHYqtw=; b=IJACb4WYCFKbRQss 9iHQJ1JEihHZk0bcMq2Oj03VTB1bR4f7iZmspnnfGKeg0Lz1IXetIwRmnUSXQtFh EJ5RL5VsnVPrEd96RNn1rEtd0eUJVvpgN+L43uKp9j3sQKAfL8XyCv7YgZwCS37z 0u9E2C/2u9yWnF3rZbwogxh1sk/+KRb5GmKP7EASPiLZnIhFYpAHatZBklIyktz8 oQfQbS+tpryrqhyUO8uXRONLGKSvqcwBmTg0Kj5bcqYeSx84wz3MLybzGDts+Zqc X/dHIPc14N8vfcKW6rY18TrMm3KHfOPyu7fEWSZkdN0Pfwwld5jy9JG/hhpkv2Wj xmXjNQ== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d36f08n61-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 23 Mar 2026 16:26:08 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-50b32feb719so28416541cf.2 for ; Mon, 23 Mar 2026 09:26:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774283167; x=1774887967; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=JNjoxb/miPYUITIblVuJDVboPKpzuzXYI3UEyOHYqtw=; b=UPBSGr/n6NjmJzrrGxckEfEhIEm6wfRBKODcj3H3+8UcnrKvc4f1LH3o9GmZ56RjAJ 6oCWqSBX3PoB5B5UlHIZi62wP573+tzQOp162Ie+ZOycBovxjUir3PKf8pkXb76Zn/m2 ujqqhlC52cuHE6Dp7XbDkWWPlyfSqUo0cEoJJN30+BJp2kHROujb1L7R/qJpRFN3TY0Y RE+fFdbA6uGXGvOw95JmsXBHENReAuHJtSCzRN8gLXtx6IqXgG1XJYy03mWGRGMfzGn2 8pFbaFE5YPIsIUZgQyomwV1p8Y5LdMHtCibvb9+h845BFfdrKC5hik8S5AcdE0MEQAn2 7bfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774283167; x=1774887967; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JNjoxb/miPYUITIblVuJDVboPKpzuzXYI3UEyOHYqtw=; b=OTggo0HAClOEmLMylEqIMj/BNnAvaW3pEARTIZ4SAzczeC9/4R7kE0g4yIMC9OLewZ yotk9WXSMok3g5N2If2EErSfP5e1TkzunH3Z+qHc6787+A8IAogt679u6Z4J0YfRgGLV FbTZm5l8AozOwKdSDIkpgGWt4vu5uOoytu8XFPhrVVFXi546vX7Ispa4+lFZoDa70NdR rOdoVbGaluVdxyusDc5oJZYuw4ob1IeOth8VQNptikUbar0bEswEi18s2+PoPeBTlmxK LqCmyM05lACB/CzhSNAFkQksW5oOK0XEcGxBc/FmL0iL8egMMPx/iDcVuPOtN8ae14I/ zoMQ== X-Forwarded-Encrypted: i=1; AJvYcCVU4ykhI84364J/NXLFKLLZ9VPq2KSVDUHe8cc8eyyArsiUPX6I9PK14StPJxaknhtnYTv5xREarxJW+xI=@vger.kernel.org X-Gm-Message-State: AOJu0YyqD+n883D1JJHLN+ndL4JZSh4mSpN0uiEkDXeUvI5BZjo4/7PK jqsvkJBnlniIV1DhTJ1eQIvWjsl8aGWA8Boj/nDHI1MydtMn+2NjDKK/wOamm4uqFhlUAU2kXsy Kz5tgctlq6VKxbZkL+65egz/LySu4mEYUBJ9OowyM74UfBTPs6EJkhr5NLsfIaTki1mIHJ7eGmy o= X-Gm-Gg: ATEYQzx3oeiaIbGYoiTTEcA5FD+phBqoIlBGFtefuxSCucYOB0wfY3LdyWV8yhuuqFL tBdOF93j8OZnC17prUdIwq0a/IDQyQiaMq0KTUqClfYILQmh2dWRqYf0VCbaTO56HD2nxuoiOsl /7Hla0g0p2U7LekPLberze+5Kxk1E3yzTRJvnCZLpfxNUOzwXruTQjCN8cRKatNsawFPUBw2hAX fkPy3tcpeRLRZfQ3lH265rbLsmYWCmeNVWH8VIfoALN3eJ4MRm8l1vo2EqqhBjJsa9JUe2x2F4m mzZgW0nTmRG4TUYFVS2Y8U9FcVDZ/4jr+076EnGHJbUjKhvyOX96uOrCZZ4N3LElJ4TPCzXeQHg 1HFR4Vd+x+cK6QKN3F90Ctq1rE9WED+Gx+lMdG+PWBzgCrIICnjLcv5wsh7rRyx2BnWIsOX9MDV JAtFk= X-Received: by 2002:ac8:7f0f:0:b0:509:1924:3f60 with SMTP id d75a77b69052e-50b3753fc76mr145977201cf.9.1774283167285; Mon, 23 Mar 2026 09:26:07 -0700 (PDT) X-Received: by 2002:ac8:7f0f:0:b0:509:1924:3f60 with SMTP id d75a77b69052e-50b3753fc76mr145976871cf.9.1774283166728; Mon, 23 Mar 2026 09:26:06 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-668cf7e4528sm3855593a12.11.2026.03.23.09.26.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Mar 2026 09:26:05 -0700 (PDT) Message-ID: Date: Mon, 23 Mar 2026 17:26:03 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] mailbox: qcom-ipcc: amend qcom_ipcc_irq_fn() to report errors To: Gabriele Paoloni Cc: mani@kernel.org, jassisinghbrar@gmail.com, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, mpapini@redhat.com, dnita@qti.qualcomm.com, rballati@qti.qualcomm.com, bijothom@qti.qualcomm.com, wchadwic@redhat.com References: <20260316102618.7953-1-gpaoloni@redhat.com> <20260316102618.7953-3-gpaoloni@redhat.com> <384e46f3-140c-4b88-a3c8-6cbb57ecff99@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=b+q/I9Gx c=1 sm=1 tr=0 ts=69c169a0 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=20KFwNOVAAAA:8 a=yPA8BO6uJK7ZP7c1Cs8A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-ORIG-GUID: 8l5N2Ve4ONnuL9ONcG926dg7x9BSewfQ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzIzMDEyNCBTYWx0ZWRfXw+87mwa006Jm JHqjy1L8HQPFkG3HNvd+r2wUQVanxAunMOMEcJaIWH39qqstVbKSLF9VSkzFCQiF5x9/SQjidbn WleU7hz6hD4TTUdCsCggIZAS4KUoB7toVnmhyae4IExv/ObjKiNNM7NfbNCaoD184zHHwbfJysq lNxOVuEG9f2eeBHs+fs+UIzrHEyFuR40irT2o3Hgzvnv/u7QjskyTf3MxdeD89PJYFWh/EO7f9u MdJz1tLIuSNKX6YQhU7tztOnZ1JkwQrE1yCS+bv+HCHVEXDVVD0qoVt5NbheuvxlmXHkMCNNnOD dLcdd5JIv93v4Wp9zzq8gKrqF5Z3O7IspVaGSiasQDjnUSfnmUIzSUsXaARrORnkPzvJYe6WIzu HFjmHFFOhdGd3rWFrwXt4QQFnBuOU88CID+lDCsMxUQnnEFuzWx87bsa2DAy02+3V/Dsg3MmoMi ic/UKTNpjebMZMtEgNw== X-Proofpoint-GUID: 8l5N2Ve4ONnuL9ONcG926dg7x9BSewfQ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-23_04,2026-03-23_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 impostorscore=0 adultscore=0 malwarescore=0 bulkscore=0 suspectscore=0 phishscore=0 clxscore=1015 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603230124 On 3/20/26 12:24 PM, Gabriele Paoloni wrote: > Hi Konrad > > On Tue, Mar 17, 2026 at 10:13 AM Konrad Dybcio > wrote: >> >> On 3/16/26 11:26 AM, Gabriele Paoloni wrote: >>> check the virq value returned by irq_find_mapping(), also >>> check the return value of generic_handle_irq(); return IRQ_NONE >>> if either of the checks fails. >>> >>> Signed-off-by: Gabriele Paoloni >>> --- >> >> It certainly seems useful to inspect a function's return value, however I >> noticed that out of 47 in-tree callers of generic_handle_irq() within >> drivers/, only one other driver (intel_lpe_audio within drm/i915) checks >> that.. >> >> Similarly, many other drivers never check if irq_find_mapping() actually >> succeeded. This makes me wonder how you discovered there's an issue in >> the first place. Could you please add some details in the commit message? > > Code inspection spotted the issue, and I could not find a justification for > irq_find_mapping() and generic_handle_irq() to always succeed; hence > I proposed this patch to follow good coding practices. That's a good enough reason Reviewed-by: Konrad Dybcio Konrad