From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH 05/10] staging: rtl8192e: Remove constant variable ps_force
Date: Fri, 6 Oct 2023 21:05:07 +0200 [thread overview]
Message-ID: <ecebc90415c202e4e465bfb5b10c54be8b42e684.1696548527.git.philipp.g.hortmann@gmail.com> (raw)
In-Reply-To: <cover.1696548527.git.philipp.g.hortmann@gmail.com>
Remove constant variable ps_force as its value is always 0. The equation
results accordingly. Remove dead code.
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
---
drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 1 -
drivers/staging/rtl8192e/rtl8192e/rtl_ps.c | 3 +--
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h
index 4b2ee1684dac..d4e998cfbefc 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h
@@ -263,7 +263,6 @@ struct r8192_priv {
short promisc;
short chan;
- bool ps_force;
u32 irq_mask[2];
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_ps.c b/drivers/staging/rtl8192e/rtl8192e/rtl_ps.c
index a4da11627199..44a9fe831849 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_ps.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_ps.c
@@ -181,8 +181,7 @@ static bool _rtl92e_ps_set_mode(struct net_device *dev, u8 rtPsMode)
{
struct r8192_priv *priv = rtllib_priv(dev);
- if (!priv->ps_force)
- priv->rtllib->ps = rtPsMode;
+ priv->rtllib->ps = rtPsMode;
if (priv->rtllib->sta_sleep != LPS_IS_WAKE &&
rtPsMode == RTLLIB_PS_DISABLED) {
unsigned long flags;
--
2.42.0
next prev parent reply other threads:[~2023-10-06 19:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-06 19:04 [PATCH 00/10] staging: rtl8192e: Remove last private functions from iw_handler_def Philipp Hortmann
2023-10-06 19:04 ` [PATCH 01/10] staging: rtl8192e: Remove function _rtl92e_wx_set_force_lps() Philipp Hortmann
2023-10-06 19:04 ` [PATCH 02/10] staging: rtl8192e: Remove function _rtl92e_wx_set_lps_awake_interval() Philipp Hortmann
2023-10-06 19:04 ` [PATCH 03/10] staging: rtl8192e: Remove constant variable reg_max_lps_awake_intvl Philipp Hortmann
2023-10-06 19:05 ` [PATCH 04/10] staging: rtl8192e: Remove function _rtl92e_wx_adapter_power_status() Philipp Hortmann
2023-10-06 19:05 ` Philipp Hortmann [this message]
2023-10-06 19:05 ` [PATCH 06/10] staging: rtl8192e: Remove function _rtl92e_wx_set_scan_type() Philipp Hortmann
2023-10-06 19:05 ` [PATCH 07/10] staging: rtl8192e: Remove unchanged variable active_scan Philipp Hortmann
2023-10-06 19:05 ` [PATCH 08/10] staging: rtl8192e: Remove function _rtl92e_wx_set_debug() Philipp Hortmann
2023-10-06 19:05 ` [PATCH 09/10] staging: rtl8192e: Remove unused variable rt_global_debug_component Philipp Hortmann
2023-10-06 19:05 ` [PATCH 10/10] staging: rtl8192e: Remove unused file rtllib_debug.h Philipp Hortmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ecebc90415c202e4e465bfb5b10c54be8b42e684.1696548527.git.philipp.g.hortmann@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®