From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752002AbdBIIve (ORCPT <rfc822;w@1wt.eu>);
        Thu, 9 Feb 2017 03:51:34 -0500
Received: from mail1.skidata.com ([91.230.2.99]:58749 "EHLO mail1.skidata.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751777AbdBIIvc (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 9 Feb 2017 03:51:32 -0500
X-Greylist: delayed 386 seconds by postgrey-1.27 at vger.kernel.org; Thu, 09 Feb 2017 03:51:31 EST
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2HpBAABK5xY/0oKEKxdGQEBAQEBAQEBA?=
 =?us-ascii?q?QEBBwEBAQEBhFxmg1KcERCTF4IPggyGIgKDOBcBAgEBAQEBAQEDgQdCDgGEGQE?=
 =?us-ascii?q?FI1YQCw0BCgICJgICRxAGAQwBBwK5coIlJgKLJQEBAQEBAQEBAgEBAQEBASIJA?=
 =?us-ascii?q?YEBgSaEG4IFgmqBPIYegl8Fj0OMLYF/kXYBiFsXhi+TEyABgTUPEA8EHYUigXK?=
 =?us-ascii?q?BfIZqgQwBAQE?=
X-IPAS-Result: =?us-ascii?q?A2HpBAABK5xY/0oKEKxdGQEBAQEBAQEBAQEBBwEBAQEBhFx?=
 =?us-ascii?q?mg1KcERCTF4IPggyGIgKDOBcBAgEBAQEBAQEDgQdCDgGEGQEFI1YQCw0BCgICJ?=
 =?us-ascii?q?gICRxAGAQwBBwK5coIlJgKLJQEBAQEBAQEBAgEBAQEBASIJAYEBgSaEG4IFgmq?=
 =?us-ascii?q?BPIYegl8Fj0OMLYF/kXYBiFsXhi+TEyABgTUPEA8EHYUigXKBfIZqgQwBAQE?=
X-IronPort-AV: E=Sophos;i="5.35,349,1484002800"; 
   d="scan'208";a="2384939"
Subject: Re: [PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller
 Driver
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Richard Leitner <dev@g0hl1n.net>, Greg KH <gregkh@linuxfoundation.org>
References: <1486543976-28006-1-git-send-email-richard.leitner@skidata.com>
 <1486560068.2133.395.camel@linux.intel.com> <20170208135957.GA916@kroah.com>
 <96c8a6f9-3b93-8ba0-22b1-502e22dac31c@skidata.com>
 <1486572009.2133.406.camel@linux.intel.com>
 <80e533b6-4eb3-0019-fe18-82dd0d7aaa1c@g0hl1n.net>
 <1486581644.2133.409.camel@linux.intel.com>
 <3902c4a9-cd1d-23fe-df75-127b5cab61ad@g0hl1n.net>
 <1486585012.2133.420.camel@linux.intel.com>
CC: <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <robh+dt@kernel.org>,
        <mark.rutland@arm.com>, <stern@rowland.harvard.edu>
From: Richard Leitner <richard.leitner@skidata.com>
Message-ID: <ecede753-026c-9d59-b4ac-4eae3ff2fdbb@skidata.com>
Date: Thu, 9 Feb 2017 09:44:17 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Icedove/45.6.0
MIME-Version: 1.0
In-Reply-To: <1486585012.2133.420.camel@linux.intel.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [172.16.60.30]
X-ClientProxiedBy: sdex1srv.skidata.net (172.16.10.92) To sdex1srv.skidata.net
 (172.16.10.92)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 02/08/2017 09:16 PM, Andy Shevchenko wrote:
> On Wed, 2017-02-08 at 21:03 +0100, Richard Leitner wrote:
>> Should I keep my inline {clr,set}_bit_in_byte() 
>> functions an use BIT() in there, or delete them and use BIT()
>> directly 
>> in usb251xb_get_ofdata() ?
> 
> Does it make any sense?
> 
> Even just name of your function is longer than what it substitutes.

Well, you're right :-)
So I'll change that for v5.

Thanks!