From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF3B9C77B73 for ; Mon, 22 May 2023 20:52:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233857AbjEVUws (ORCPT ); Mon, 22 May 2023 16:52:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54122 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231860AbjEVUwq (ORCPT ); Mon, 22 May 2023 16:52:46 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9547294 for ; Mon, 22 May 2023 13:52:44 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-4f122ff663eso7121941e87.2 for ; Mon, 22 May 2023 13:52:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684788763; x=1687380763; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qzzot298H9S1xfQy884A/n0F+LWiqtlI5Y6iFzIpxTc=; b=oMmr8mt0z/vOfSJrCq3pVtuEPbsCeAhYSqZ1Rwwrlg4IlUvBrjx2h6IR6rcId/aR8z hQE74P0bv510AuIg0+IBRXLkFXdOfjlBxs/iQZzGYGtXhhvN8zzCIZSahgoMQHK4ao7T nqD6gXwgHX4+A2yM5PNd9j5N1StTv9YAimTnEzogoqYXArx1/COtpDYOJaCq20XLqsX8 t77QiJuQ/NqXSs7FaC8IZOU/vza4UM2ldNmZMX8xiRUa+vjmtL05UxcT3YBInbSWwAVA 34T9SQHgPrAb5NLBk1KXxvdFHzuzmBqMPJACBGq/6BzT2Fs2tjF+v62DdXXPFdM1dQdL dFyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684788763; x=1687380763; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qzzot298H9S1xfQy884A/n0F+LWiqtlI5Y6iFzIpxTc=; b=Pr4mTabQwGPKjqKI4bJ17O71qiqj8VOwIRpV6f7wQOSuhP6NchzDBe8xSnsAaP3POn sv3eq8ZZIk3bFTFt+F6Eut9HuH4I3Wu958C7jUsVre+VKa34IycqHQ7g/dSVQLRbXdVe ldOxM24LBCpkTVlpxxdptVwM2KFIz4las7urB9Gx12pQ5K8qUNTce1HCK6JzkakYtZs4 9InYAxrs75QhHC4MsTdhOK754LCzWR/jOfmwyiXS9mUi10lHB31ABUzXvjacZMn1kUOM FKLbsY6Y2aihRWhLPRy1JTwrYLi4ixsU6qVxfRNwR/lUT8wwOVOE6w7c5m8JQdyEARHr GoHA== X-Gm-Message-State: AC+VfDw1fMijhKCnrGblqKo1L1ZZ2oWucPOlMasP/ojaehhcaItY1kTw wDJNnoXD1+TD0m507iU06ZPhZw== X-Google-Smtp-Source: ACHHUZ70BGA9Uob2tmq9vnnuOZF9GmElYbTbJOCcZ2XvSUohGie9tt0+BdXH0QSRUm7yrtoWpgHmbQ== X-Received: by 2002:ac2:55a1:0:b0:4f2:4fd7:a11f with SMTP id y1-20020ac255a1000000b004f24fd7a11fmr3325386lfg.54.1684788762858; Mon, 22 May 2023 13:52:42 -0700 (PDT) Received: from [192.168.1.101] (abyk97.neoplus.adsl.tpnet.pl. [83.9.30.97]) by smtp.gmail.com with ESMTPSA id b25-20020ac247f9000000b004f3b319ed4bsm1103692lfp.120.2023.05.22.13.52.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 May 2023 13:52:42 -0700 (PDT) Message-ID: Date: Mon, 22 May 2023 22:52:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v4 1/5] msm/drm/dsi: Round up DSC hdisplay calculation Content-Language: en-US To: Marijn Suijten , Jessica Zhang Cc: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , David Airlie , Daniel Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20230405-add-dsc-support-v4-0-15daf84f8dcb@quicinc.com> <20230405-add-dsc-support-v4-1-15daf84f8dcb@quicinc.com> From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22.05.2023 22:44, Marijn Suijten wrote: > On 2023-05-22 13:30:20, Jessica Zhang wrote: >> Currently, when compression is enabled, hdisplay is reduced via integer >> division. This causes issues for modes where the original hdisplay is >> not a multiple of 3. >> >> To fix this, use DIV_ROUND_UP to divide hdisplay. >> >> Reviewed-by: Marijn Suijten >> Suggested-by: Marijn Suijten > > Nit: probably these should go in the opposite order. And if they're > all supposed to be chronological, I think it is: > > Suggested-by: > Fixes: > Signed-off-by: > Reviewed-by: > > But unsure if that's a hard requirement, or even correct at all. > > - Marijn Or you can rely on b4 to pick that up if it comes from others Konrad > >> Fixes: 08802f515c3cf ("drm/msm/dsi: Add support for DSC configuration") >> Signed-off-by: Jessica Zhang >> --- >> drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c >> index 9223d7ec5a73..18d38b90eb28 100644 >> --- a/drivers/gpu/drm/msm/dsi/dsi_host.c >> +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c >> @@ -952,7 +952,7 @@ static void dsi_timing_setup(struct msm_dsi_host *msm_host, bool is_bonded_dsi) >> * pulse width same >> */ >> h_total -= hdisplay; >> - hdisplay = msm_dsc_get_bytes_per_line(msm_host->dsc) / 3; >> + hdisplay = DIV_ROUND_UP(msm_dsc_get_bytes_per_line(msm_host->dsc), 3); >> h_total += hdisplay; >> ha_end = ha_start + hdisplay; >> } >> >> -- >> 2.40.1 >>