From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B677A38C2DE; Sun, 31 May 2026 13:15:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780233353; cv=none; b=m+fgFzBU/cLm5XzvP2CXSzu7fl/61nfX/QMLH7sK0hJfTF8uoSyNwyWRNdQpLCCFYYqIbq8SKTrXMyZ78nG2uXEd5+TEE3A5LVIhOKJPwSiczggepMDP0WJROU2jsCTzr2Gi4/n3g81VUybn1d5sC90fVdhC493J7Ba0pVVQ0Rs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780233353; c=relaxed/simple; bh=nj129rjUByaIy9o0FSopNQk9RD+FeU54z1Cbh8ZBbdg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=om/1KyqoAe8Au2dlv5oaeChKdjTS6r8Kz5ypCcdC4uyseoNw/GrHkwViKUbh9N7bvTWzlIS3SoyZwzrmnjjQadIHzS8hOUepQkubKvWgQ8tICHa/76eZ80oyEXuC88iVfALJh7ktBUbIWxr+utihVk7nrxxzEdK1LT9xQaQDZvQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 Received: by smtp.kernel.org (Postfix) with ESMTPSA id AE3D21F00898; Sun, 31 May 2026 13:15:47 +0000 (UTC) Message-ID: Date: Sun, 31 May 2026 23:15:43 +1000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 03/11] m68k: mcf5441x: initialize DAC clocks by iio DAC driver name To: Angelo Dureghello , Geert Uytterhoeven , Steven King , Arnd Bergmann , Maxime Coquelin , Alexandre Torgue , Jonathan Cameron , David Lechner , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org References: <20260522-wip-stmark2-dac-v3-0-16be0ad35a67@baylibre.com> <20260522-wip-stmark2-dac-v3-3-16be0ad35a67@baylibre.com> Content-Language: en-US From: Greg Ungerer In-Reply-To: <20260522-wip-stmark2-dac-v3-3-16be0ad35a67@baylibre.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Angelo, On 23/5/26 07:20, Angelo Dureghello wrote: > From: Angelo Dureghello > > Later in this patchset, the mcf54415 DAC driver is added. > Considering some other different ColdFire cpu DACs exists, the DAC driver > is named as "mcf54415_dac", related to the mcf5441x family SoCs with > DACs (mcf54415/6/7/8). > > So updating DAC CLKDEDV_INIT with proper driver name. > > Signed-off-by: Angelo Dureghello > --- > Changes in v2: > - none > Changes in v3 > - roll back clock names as they was originally > --- > arch/m68k/coldfire/m5441x.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/m68k/coldfire/m5441x.c b/arch/m68k/coldfire/m5441x.c > index 5b5e09ecf487..b02ca2eb55a4 100644 > --- a/arch/m68k/coldfire/m5441x.c > +++ b/arch/m68k/coldfire/m5441x.c > @@ -106,8 +106,8 @@ static struct clk_lookup m5411x_clk_lookup[] = { > CLKDEV_INIT("mcfpit.3", NULL, &__clk_0_35), > CLKDEV_INIT("mcfeport.0", NULL, &__clk_0_36), > CLKDEV_INIT("mcfadc.0", NULL, &__clk_0_37), > - CLKDEV_INIT("mcfdac.0", NULL, &__clk_0_38), > - CLKDEV_INIT("mcfdac.1", NULL, &__clk_0_39), > + CLKDEV_INIT("mcf54415_dac.0", NULL, &__clk_0_38), > + CLKDEV_INIT("mcf54415_dac.1", NULL, &__clk_0_39), I thought after the last discussion on this that we would not change these clock names? Regards Greg > CLKDEV_INIT("mcfrtc.0", NULL, &__clk_0_42), > CLKDEV_INIT("mcfsim.0", NULL, &__clk_0_43), > CLKDEV_INIT("mcfusb-otg.0", NULL, &__clk_0_44), >