From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753467AbdHUMsE (ORCPT ); Mon, 21 Aug 2017 08:48:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51778 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751941AbdHUMsD (ORCPT ); Mon, 21 Aug 2017 08:48:03 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 3C79D5F73C Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=hdegoede@redhat.com Subject: Modifying the vboxguest ioctl API (Was: Re: [vbox-dev] [RFC] VGDrvCommonIoCtl: Add f32bit flag argument) From: Hans de Goede To: "Knut St. Osmundsen" , vbox-dev@virtualbox.org Cc: Greg Kroah-Hartman , Arnd Bergmann , Linux Kernel Mailing List References: <20170814072756.4729-1-hdegoede@redhat.com> <3e0b527c-a6ed-243b-15d9-b29c14905763@redhat.com> <83cdfab2-a5df-83c5-2fb0-55f8d81408be@oracle.com> <6ccad347-874e-8291-32bc-27fa44ea7259@redhat.com> Message-ID: Date: Mon, 21 Aug 2017 14:48:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <6ccad347-874e-8291-32bc-27fa44ea7259@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 21 Aug 2017 12:48:03 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 14-08-17 14:19, Hans de Goede wrote: > Hi, > > On 14-08-17 13:43, Knut St. Osmundsen wrote: >> Hi Hans, >> >> the other platforms also have KPIs or similar constructs for figuring >> out whether the client process issuing the I/O controls is a 32-bit or >> 64-bit one. However, using the VBOXGUEST_IOCTL_FLAG set to 0 or 0x80 if >> 32-bit or 64-bit was a less complex (+faster(+safer)) way of deal with >> this. The host driver does this as well. I would like the structure of >> the two to be as similar as possible. >> >> I'm not very keen to adding linux specific clutter (f32Bit + #ifndef >> RT_OS_LINUX) to the common code just because you can do it differently >> only Linux. Sorry. Want minimal platform specific cruft in common >> code. Hope you understand. > > OK and yes I understand. > >> PS. I noticed in the Linux kernel RFC email thread that we've agreed to >> freeze the I/O control ABI. We cannot guarantee that's it's 100% frozen >> at this point, since the generic status code fix (getting rid of that >> ioctl non-zero return value) hasn't been done yet. I will see if I can >> squeeze it in later this week. > > I had already decided to just live with the positive return for vbox > host status codes, but if you want this changed for other reasons, then yes > now would be the time to do that. But you don't have to do it just on > my account. I plan to post a v2 of the vboxguest driver for upstream tomorrow. Given the above I will mark it as a RFC for now. Anychance you can wrap this up soonish so that I can post a non RFC version with the final ABI upstream ? Regards, Hans