From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 947CD3ED105 for ; Tue, 30 Jun 2026 11:37:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782819474; cv=none; b=ZB9vq3m2PKTSR2wxXh+B1J9zwL2kIYNiKI9PFJN+nTbYpW6bATnzMQQObc6fsFLoHPhSdraCWcX8DjEDlsYK9T+hBoJgeeWDczKBh2OIMYrU34UVyk+xvvEdTG/XaG7McuVFiSc2S55e0KCleXKPvXLEDrXlIIn9LmOCnJ/sIUQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782819474; c=relaxed/simple; bh=OKGjc8evu6WM2M0aJPIG4/RO+8j2OSSLHHk7Qjexh4c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gX8AtuS4DBZnfp52w+ZH8g6bgQoDFPMlW33/jc3yu9ONES4Vh6Tb1GSPcknqvU0j9ITSIsJnmv5VDQRXd20iaR9L0kw8PGKbmLxJ/wxIPvrUKG9lgZQVQ4pdrfMdZsyH3DcQrLEfn4ulLgWApQlLagxr3X2V0QFD/txsa4UiMrg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WhEGOjzC; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=WLbyOUcW; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WhEGOjzC"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="WLbyOUcW" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65U9mxGf1604773 for ; Tue, 30 Jun 2026 11:37:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ey0sj4w86zYCDfrgPE3RBr/Qcb1sUI5QXivW3R/r9f4=; b=WhEGOjzCXvtcXV/w IgQOJjPeTqkzQPi8/c5B8wBXpqb1Q0QJcXWwglPAlin0qKEaTaPjddan50eOftsu OaMbZV9rA+B7ikWoAkC8l4Q1BS8h3bhx3LKixFk7i2RyHjtLyMuQ9odmjPs56R0D mPNHumnrEFpTV7S7bJ3diur9t35vjaE/B4TVkne0GSwFriWLfeazU2ADWDQb1wVq uU6OB52oXpOLWBxuCYyPRWGvJpUWNMo/lcrtIzsyYt70M8+P5agjR+UIHLSA8C1e XZ7hxyfFHzXrlHHj0OB0/sRPTj9xP7sa7B7/BrK7vOxoptGrR67X3jRchhK+Numb Qoe5Mg== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f462fhyu2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Jun 2026 11:37:52 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-92e69a569ffso1303585a.2 for ; Tue, 30 Jun 2026 04:37:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782819472; x=1783424272; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ey0sj4w86zYCDfrgPE3RBr/Qcb1sUI5QXivW3R/r9f4=; b=WLbyOUcWmBYfaLqLvQTVWKgAcjORcqHVRzc0XDWB/ehODsIvyyFjmhxPL7l2rNa+sA l0BzWqrdCkHWlbsNTfbJ1jaFY6m7JVuLcwH5pCkNQsW9NFXQvlW5cCV/7uDzJUVl5eor /qHy9FddDZYSaKGDAGJoTH6JlKS73q4gWXxAoDeTW/0nlPIIVPvS7UZMGn+P7MK07JB+ dKVU0JAJMbWVUfuDL+vwzCF6FIaxfw5x27PeZRJR1QRsjUUR7OMzHYt6BdB3xC/qrrrZ brsrbs7J+n01NN/sZQcvy+3AgmLPgnTR1o/yLVuxrKbB5cmN1nigYSBK3Q0WSEQb5AXx 7qXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782819472; x=1783424272; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ey0sj4w86zYCDfrgPE3RBr/Qcb1sUI5QXivW3R/r9f4=; b=Xb0qffSr362Mat1o9Jyuzx1REd4idXALHmmVd4H/urF8doixCWWJx9jiAW/v7oxQra +X5iieWSRQFXfB7gfx3hAdj64fTcNWf8KlUlh5jmdvzlyA4vt+3ojPdUfXApKRzJBl0H SfbyfsTDDIE1no7gTM2D7sRhGkR1fh3IV9nZ6vtlD9zoU/7IFCta7qMFfvgNOAaSU/H0 mg13PudYL2J/zcFdv13NTLSsJKrz4/mbaHO3ms8A5dpRBpITIWGH10cozpEzwXUX9MXu wEua2iZem6GigTyQRJ7vOtFIWrNp3frVfbTHG4Z/KQnq2niKM8XBsmGoe9JTo1vEGC5k mDAg== X-Forwarded-Encrypted: i=1; AFNElJ83JhD0GG/l+s5a/AD78C9Eg2F1rb7PTix5sb9YMiIKsmZV4/OvOU+PJ2ylFi3aguSK/NZnoyrxt+sdwro=@vger.kernel.org X-Gm-Message-State: AOJu0YyFOprX4edCmYZvH6rFADytneB4l2Q/W+5KWl+R4fcvUHtAErnR DRJREL0KCuu8e9PdhWfseBhxgzghCNdd4A7pFIlkZG/yKg67lcQfy3Jn2rNfh6GRiWHyCDZYw7c uCon5ebF2yrqqmhUPJgzJ9W8o/PBbWH7L+TPsEGmFOMuG9zC4xsJBvnCzOs65JC/6s4I= X-Gm-Gg: AfdE7cm44rawB76m+H1QeyDg+uG3JgGHZnOgZOgLVStJ04QIUqz1T2wypIMk29mS4U1 dtb9JPQOhb8b7CIk3EbMB2x2QVC/h0KH5PVBTWM1MJkD7gW8mNf4UXm2lbMM7xvURR/ma3eAfP9 GxQt+l4c+lt4QWHZhnRSmVx+iPh4PX/XynpK5+3GPftrMCpjTmvvLH/cAtCxPI7bg6uIhC4U74O LmTZ6+LSso5w3Y1fDAqA46UU8FN84qGrXljg3q7YAorlXZep8wTNSdAy37+diln3gDX2zBoedm4 q3BLS8MR9A14GW1QGVb7ZOHHitlXwHJHW7fq16Rgbghe7l9swTHg35B6LIhlnZ4SwiDvw2PaJXR HSNMUnPdycWfx8c1f6QdVtRXn+oMcgL7ni1k= X-Received: by 2002:a05:622a:11d4:b0:51b:f40b:2fa2 with SMTP id d75a77b69052e-51c105fd0f5mr32201371cf.1.1782819471789; Tue, 30 Jun 2026 04:37:51 -0700 (PDT) X-Received: by 2002:a05:622a:11d4:b0:51b:f40b:2fa2 with SMTP id d75a77b69052e-51c105fd0f5mr32201051cf.1.1782819471326; Tue, 30 Jun 2026 04:37:51 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1288f47394sm108948566b.43.2026.06.30.04.37.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Jun 2026 04:37:50 -0700 (PDT) Message-ID: Date: Tue, 30 Jun 2026 13:37:48 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 1/3] ASoC: codecs: lpass-wsa-macro: Switch to PM clock framework for runtime PM To: Ajay Kumar Nandam , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Srinivas Kandagatla Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20260629-xo-sd-codec-v7-b4-v7-0-fb37ce457c42@oss.qualcomm.com> <20260629-xo-sd-codec-v7-b4-v7-1-fb37ce457c42@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260629-xo-sd-codec-v7-b4-v7-1-fb37ce457c42@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjMwMDEwNyBTYWx0ZWRfXw0Ual2ICfyZ/ hA/fWG4HkddWaiZJy6d/mC44wmZRW6IC4/HKx8z2CWJjdZC5J+6rrLYmhIV6k384ZEZSRoazMSR +VfzgK9hjIf5dHTUWZeVeMFnbuvPk5prY4RK+UjUa75cuxbt/k5EPSfuQoOeCQ4Y59/60AahwLx 5joEyy2meqL0jC8orStJXBdy5zURwQ4TLKjjOU9Vs48vtaDy/UHhTo6lq3BjDe0i08On0XFoIfk 6WmEJJ/CyrN3WUpedWkY3dQOwlQhPLT7Vcx67PofsYaGyjmYD6NDDqvQdwt3ZAC6iIIshyNNusY e/9c87inNKdKh2ka/o9dvwsXZe4sFn9ugxwdDCaPuXZlt15y7xj9mrsbyaksufDE5gV12Nl0TR6 DA+vC66B7AyfDTMB8yENAF6N0CpzsosCnfItoMLQPzOtlF+S1K0zTIN1PocGO0jjMmUhYmrDWtl QMkrIl9vLcc+7voOpAg== X-Proofpoint-ORIG-GUID: JPDNwLCMu00cvcbyeWacO1i3WA1SFEkK X-Authority-Analysis: v=2.4 cv=JqbBas4C c=1 sm=1 tr=0 ts=6a43aa90 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=t2ZNzEmchGV416yE2bcA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-GUID: JPDNwLCMu00cvcbyeWacO1i3WA1SFEkK X-Proofpoint-Spam-Info: AW1haW4tMjYwNjMwMDEwNyBTYWx0ZWRfXyUn0DnTBpjYP c44lLHs5AvmiORyvcSiTLFI4rlYOd69M7uuf2c1+A4T7xA/B0tvXVc43jCncJBlf5RjbvEKoBIB /Q7ICXSCm1K6HoSbZI+Y0l8Xm3vmcNU= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-30_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 bulkscore=0 adultscore=0 impostorscore=0 suspectscore=0 phishscore=0 malwarescore=0 spamscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606300107 On 6/29/26 12:05 PM, Ajay Kumar Nandam wrote: > Convert the LPASS WSA macro codec driver to runtime PM clock management by > using the PM clock framework. > > Replace manual macro/dcodec/mclk/npl/fsgen clock toggling with PM clock > helpers and runtime PM callbacks. Keep the SWR gate runtime PM reference > from SWR clock enable until disable so autosuspend does not gate clocks > while SWR is still prepared. > > Set autosuspend delay to 100 ms so PM-clock-managed votes are dropped soon > after idle while still avoiding suspend/resume churn on short gaps. > > Add a PM_CLK dependency to SND_SOC_LPASS_WSA_MACRO since this patch > introduces PM clock APIs. > > Tighten error unwind by checking pm_runtime_put_sync_suspend() in probe and > by restoring regcache state if pm_clk_resume()/regcache_sync() fails. > > Suggested-by: Mark Brown > Signed-off-by: Ajay Kumar Nandam > --- I think this is good now Reviewed-by: Konrad Dybcio Konrad