mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
	Jonathan Corbet <corbet@lwn.net>
Cc: Lukas Bulwahn <lukas.bulwahn@gmail.com>,
	linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MAINTAINERS: adjust to filesystem doc ReST conversion
Date: Wed, 04 Mar 2020 13:24:48 -0800	[thread overview]
Message-ID: <ed040dd417d578e1ab4491d116c6ac1431142385.camel@perches.com> (raw)
In-Reply-To: <20200304212846.0c79c6da@coco.lan>

On Wed, 2020-03-04 at 21:28 +0100, Mauro Carvalho Chehab wrote:
> Em Wed, 4 Mar 2020 13:10:35 -0700
> Jonathan Corbet <corbet@lwn.net> escreveu:
> 
> > On Wed,  4 Mar 2020 08:29:50 +0100
> > Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
> > 
> > > Mauro's patch series <cover.1581955849.git.mchehab+huawei@kernel.org>
> > > ("[PATCH 00/44] Manually convert filesystem FS documents to ReST")
> > > converts many Documentation/filesystems/ files to ReST.
> > > 
> > > Since then, ./scripts/get_maintainer.pl --self-test complains with 27
> > > warnings on Documentation/filesystems/ of this kind:
> > > 
> > >   warning: no file matches F: Documentation/filesystems/...
> > > 
> > > Adjust MAINTAINERS entries to all files converted from .txt to .rst in the
> > > patch series and address the 27 warnings.
> > > 
> > > Link: https://lore.kernel.org/linux-erofs/cover.1581955849.git.mchehab+huawei@kernel.org
> > > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> > > ---
> > > Mauro, please ack.
> > > Jonathan, pick pick this patch for doc-next.  
> > 
> > Sigh, I need to work a MAINTAINERS check into my workflow...
> > 
> > Thanks for fixing these, but ... what tree did you generate the patch
> > against?  I doesn't come close to applying to docs-next.
> 
> I'm starting to suspect that maybe the best workflow would be to just 
> apply the patches at docs-next keeping links broken, and then run
> ./scripts/documentation-file-ref-check --fix by the end of a merge
> window, addressing such breakages.

I'm not sure at all that that script will always do the
right thing with MAINTAINERS, but it seems to work OK
except for some renames where a .txt file was directly
renamed to a .rst file in the same directory where there
was a similarly named file in a different directory.

Likely the direct rename of a filename extension from
.txt to .rst should always be applied by the script.

Anyway, for -next as of today:

$ git diff --shortstat
 64 files changed, 116 insertions(+), 116 deletions(-)

> There are usually lots of churn outside the merge window.
> 
> Another alternative would be to split the MAINTAINERS file on a
> per-subsystem basis. If I remember well, someone proposed this once at
> LKML. I vaguely remember that there were even a patch (or RFC)
> adding support for such thing for get_maintainers.pl.

Yeah.  get_maintainer.pl does work if the MAINTAINERS
file is split up a few different ways.

There was also a tool to do the MAINTAINERS split.
https://lore.kernel.org/patchwork/patch/817857/

I doubt that would matter at all given today's tools and
the general mechanisms of maintainers renaming files and
not running checkpatch in the first place.



  parent reply	other threads:[~2020-03-04 21:26 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-04  7:29 Lukas Bulwahn
2020-03-04  7:59 ` Mauro Carvalho Chehab
2020-03-04 10:54   ` Lukas Bulwahn
2020-03-04 20:10 ` Jonathan Corbet
2020-03-04 20:24   ` Joe Perches
2020-03-04 20:28   ` Mauro Carvalho Chehab
2020-03-04 21:02     ` Lukas Bulwahn
2020-03-04 21:24     ` Joe Perches [this message]
2020-03-05  6:14       ` Mauro Carvalho Chehab
2020-03-04 20:50   ` Lukas Bulwahn
2020-03-04 21:01     ` Jonathan Corbet
2020-03-04 22:57     ` Joe Perches
2020-03-06 21:17       ` Lukas Bulwahn
2020-03-07 10:01         ` Mauro Carvalho Chehab
2020-03-07 15:12           ` Joe Perches
2020-03-08  2:59             ` [PATCH] parse-maintainers: Do not sort section content by default Joe Perches
2020-03-26 16:45               ` Joe Perches
2020-03-26 22:54                 ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ed040dd417d578e1ab4491d116c6ac1431142385.camel@perches.com \
    --to=joe@perches.com \
    --cc=corbet@lwn.net \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    --cc=mchehab+huawei@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®