From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D87586DCE1 for ; Wed, 8 Apr 2026 09:14:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775639670; cv=none; b=ZhRAJz763r7APy9iQMCV1dCUx4NcECRmvd4LcJTo7lNiNkX3bBP/7flaUpltyuKdbcg/5g2OePeYC5Bzl1PR4cEXXJBMQkiHPOt8kQu7rxsV+sjS0f9ukTMnQKgFDyYwfZb0U6VOqB/jcTypz8/7ASK7ajxs3eEsEWzhmYW/PR0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775639670; c=relaxed/simple; bh=YvtodDdplKMdW3PBeWJkCqYTAkXl02h8pr2K+T1smhY=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=sU0UklAxirdLNBJlrx3/YMKHFA9/mPWglxmYqLPY3YuWOqLCetdj2QZy/sxXUb0SWOOQgNBX/P5ZRqQwiRQ81EuPyJ/40Eumad78KJ1MTu8+8/xS63Sk09Zk5ATioKDYLm4WexSN2PQD0jw6kHQOijjaiyJzLh2XUcfvCahSOjo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=b00s5HsL; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=bfkKCDT7; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="b00s5HsL"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="bfkKCDT7" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6388I1iC1796777 for ; Wed, 8 Apr 2026 09:14:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Q7cTSR5FSGG/VsgFWndHXllplgpX+lHRL5bp+rlm+lc=; b=b00s5HsLbAeWD9rF OgTnWAL2NbNVpiIqljY5NG71G3Bo3Lepj7AmAgwB0vHEs60/jPB864tCHGtWUOiD Is8fDK/+9DnL4y4eiEAtfw1Unz9HNpqFkdOhiIcEbgUBwIDR6wYIJsiun832V/Vk JXXx2l1P4vc55kT9F/1/E07be5xnIKVe4KfBxrsDHBoKAIEFaMtz0O1gdjCkFHIw vrcsXme/qpbjHZrK85P44qlIsqS8LZQdpSH/a/s3urHUDxTvorKF87lmd2iaC5rk 0D9XnZEzoouqfh+lYHfdWpwYYmu6gIK9OAsC8m15RLzc3ndEMBU53Yw9WFisAVBU aW5nxA== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dd51dbc60-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 08 Apr 2026 09:14:28 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2b2471321dcso167921785ad.1 for ; Wed, 08 Apr 2026 02:14:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775639668; x=1776244468; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:cc:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Q7cTSR5FSGG/VsgFWndHXllplgpX+lHRL5bp+rlm+lc=; b=bfkKCDT7yPFTurXmWjkJb4eT2hTxa8fOOvwNhNnkEutO5N4J0MaVb54tHwVoOuTzHY 98g4naa61MsyjyhWUno16/HMDiMOp3VO1m3zxUuT6vmch4CnLmqwy6MQSlPtUWFfXoYv xpQAHyx7AR6zr07NAL+H1UAhShFbQxiq30HM8qUgEMds7dkXh4gYE9tlHcwDHmFAKE3J kk33MJKzNIZd1ozwkyQCF1HBbagy0w77D701iaBpZ9ZtKsEPpoqWhxSvJu+ZPjFpFz45 vMy0Mzy4R3yL80YQQR5mSYuboaPJMT+9LO6nd3OLlUBfotL1ILaWHAekBYNWkzaJL1NP y0Ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775639668; x=1776244468; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:cc:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Q7cTSR5FSGG/VsgFWndHXllplgpX+lHRL5bp+rlm+lc=; b=oGRmm5DodcZjUJ8PpE8ybuY7B6X0ZaTQPhLIjEjjGeYizk2uj8ECUbjvoA8COyePs3 LC71g6VjjfFVxyT3EgCVUqMNWa/ftn9TtCsvJ+oPj3k6zq2lpBN8UHSUbFtDrY9b71hQ okWVjxCMXg32VfL6aOLFFiYNX7+LCx3NQEl5svcvEKMfBoM76472TMRPpOJS9DFCG4TV qFehPRbiC+/kSQuHx/Y4Fi6QOzKJ8iU+rAIWDkXQSsW8wlVVLtGpQWrbdQm5zMcxGDMr 7CO4TcbBPoCApRbOO3Y6JP3mO+fhi/E3f78p4WIl2AwtqR4zdT3vADixZEi1NUrupWW+ NIjw== X-Forwarded-Encrypted: i=1; AJvYcCVJU5WhbI3f8OennxcfEe6jNjcdI9ok7GrrFJgvP038mBO7b3CZdckqRJCEx/Noe1lsoqxVcwLD25KRBF4=@vger.kernel.org X-Gm-Message-State: AOJu0YxSpPebDXKbLNnO3U8kM610NtmhoDLB5w/72TU+H2k14RvPrsY0 PpI8C3yoaD0lOcDZZLOyc7HZ6mQkjgEI4B0426GPZTppGf41aFk13tuRIYXkk6JCiLWGlKeVrMD +XV9cremSJLvSmEx4p8uD7B/5TGmuM1Ll7A6h/w4hZSrZBP1tAsHhrrJdyzfkklmj6Wc= X-Gm-Gg: AeBDieuHNidlvS3xSzT8w8YEhvVOPPlIaeYLAUT2bpzyjQL0CXzUa4C0sroi1slZdBD ryHQZgaCZcY6ELVShiGY6iGHw4ZN3YWEn2e0j6MwU7h/Ank56dCQXrqy9S6vvzuDgjqSJ2zdCLE W6aFgn4mMalORyefAU6YY5LOBisqQ04zaRJBTScxR5LVnBdKlnBUsdfug2FrmQOS8IX7ZgXN11K skxyUu3ki5feEgs4ccW9kQiBjDMgoifrEXwQoL3LcTSCzvqYXbrbiTfqnH1o2nmJA+/bYuA6tNj 1Iw1Jnag0VOIAn6oEIkCpR1yMvTtc76gYVtDDovduZcelV9bVyJHHFxCy6lcw/telyJckRi6D+5 o2p0mbVdnl05yJ2iWXW13Qhj8nwkFYBbMY17qsrXOvHcvc0OajZJ894aqw16+PnQm+b4kO6cmQH NVXl31p3l/WIlOpxoI X-Received: by 2002:a17:903:4b28:b0:2b0:52b7:e82 with SMTP id d9443c01a7336-2b281867dc8mr185457245ad.16.1775639668338; Wed, 08 Apr 2026 02:14:28 -0700 (PDT) X-Received: by 2002:a17:903:4b28:b0:2b0:52b7:e82 with SMTP id d9443c01a7336-2b281867dc8mr185456875ad.16.1775639667873; Wed, 08 Apr 2026 02:14:27 -0700 (PDT) Received: from [10.249.21.102] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b27477a13dsm199169575ad.26.2026.04.08.02.14.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Apr 2026 02:14:27 -0700 (PDT) Message-ID: Date: Wed, 8 Apr 2026 17:14:21 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: wangao.wang@oss.qualcomm.com, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/5] media: iris: Add hardware power on/off ops for X1P42100 To: Dikshita Agarwal , Bryan O'Donoghue , Vikash Garodia , Abhinav Kumar , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio References: <20260401-enable_iris_on_purwa-v4-0-ca784552a3e9@oss.qualcomm.com> <20260401-enable_iris_on_purwa-v4-2-ca784552a3e9@oss.qualcomm.com> <9bfaf15e-99c8-a98e-d0df-9df86872bfe8@oss.qualcomm.com> Content-Language: en-US From: Wangao Wang In-Reply-To: <9bfaf15e-99c8-a98e-d0df-9df86872bfe8@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: 2xiQyFf22O6tnx-FFApx5DN1j8S6YOYh X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDA4MDA4MiBTYWx0ZWRfXzchJsBONvhNm znMw/qL15YsnQdVVpyTXrbeZjsAd3aERfRhH2YEh3RWlB6dvae4Hu72JJEvxAxUM54KqmJ+5P6s YbW8Xf8daSnhU33lZTk9sr2lDd4Vsg2jA6+jXunz2Nhor4d0GGCePJYKUnY983clgS135y/nMEK b/FbTOSGi3hU5MbHEXfmnWYbG9AnzrldQOCTn4mBiq38jwLB/UBOH8/YiPT7Nj4zbhJ+T+sSRNU 3A4aJK1bGsP63gBuMxZ4LGDbGxl2SY2wP+NfDJEoxMCLXYIDbjwbH7/3c6ZCf0KtH4glIG1SCX1 U7NOhHI7wfcJq+R2GtwfV4O8aitL72HkdTqTHeQkS91IEi8NdYgzHqW9SH+JxD9xFgzUylHngF+ 3pMnBDNcB/ReWWn0rt3p7sVlsDSg4RW2dbjw0Q5t2q49x17qDr1w7cc0zmVuGeeoa8COjIc+cb8 lGg/0CqjUL92t85CVsA== X-Authority-Analysis: v=2.4 cv=AcaB2XXG c=1 sm=1 tr=0 ts=69d61c74 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=uc885YhAzpYNqufBhGQA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-GUID: 2xiQyFf22O6tnx-FFApx5DN1j8S6YOYh X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-08_03,2026-04-08_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 bulkscore=0 malwarescore=0 phishscore=0 impostorscore=0 spamscore=0 clxscore=1015 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604080082 On 2026/4/1 20:37, Dikshita Agarwal wrote: >> + >> +static void iris_vpu3_purwa_power_off_hardware(struct iris_core *core) >> +{ >> + iris_vpu3_power_off_hardware(core); > > this will eventually call iris_vpu_power_off_hw which would try to disable > IRIS_HW_AHB_CLK which is not applicable to purwa I think, will that not > create any issue? > All VPU3s will call this hook, but none of them have IRIS_HW_AHB_CLK. -- Best Regards, Wangao