From: Gergo Koteles <soyer@irl.hu>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
amd-gfx@lists.freedesktop.org,
Hans de Goede <hdegoede@redhat.com>,
Alex Deucher <alexander.deucher@amd.com>,
Mario Limonciello <mario.limonciello@amd.com>,
Alex Hung <alex.hung@amd.com>,
Harry Wentland <harry.wentland@amd.com>
Subject: amdgpu_dm_connector_mode_valid regression
Date: Wed, 02 Apr 2025 12:40:53 +0200 [thread overview]
Message-ID: <ed09edb167e74167a694f4854102a3de6d2f1433.camel@irl.hu> (raw)
Hi,
While playing with
https://lore.kernel.org/all/61c3df83ab73aba0bc7a941a443cd7faf4cf7fb0.1743195250.git.soyer@irl.hu/
I found a regression that prevented some EDID DTDs from being selected
in some specific cases.
This is the first bad commit:
b255ce4 ("drm/amdgpu: don't change mode in
amdgpu_dm_connector_mode_valid()")
I think the problem is that decide_crtc_timing_for_drm_display_mode()
function tries to copy the crtc information from the preferred mode,
but that's not filled yet if the first one is the preferred one and
it's not the one with the maximum refresh rate.
amdgpu_dm_connector_mode_valid()
create_validate_stream_for_sink()
create_stream_for_sink()
decide_crtc_timing_for_drm_display_mode(&mode, preferred_mode, scale)
It works if I call
drm_mode_set_crtcinfo((struct drm_display_mode *)mode, 0) before
create_validate_stream_for_sink()
in amdgpu_dm_connector_mode_valid()
or
if I comment out the decide_crtc_timing_for_drm_display_mode() in
create_stream_for_sink()
but a better fix than these can be imagined :)
more information:
https://gitlab.freedesktop.org/drm/amd/-/issues/4085
Regards,
Gergo
next reply other threads:[~2025-04-02 10:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-02 10:40 Gergo Koteles [this message]
2025-04-02 12:00 ` Gergo Koteles
2025-04-02 13:36 ` Dmitry Baryshkov
2025-04-02 14:35 ` Gergo Koteles
2025-04-02 14:40 ` Dmitry Baryshkov
2025-04-02 15:00 ` Gergo Koteles
2025-04-11 10:01 ` Marek Marczykowski-Górecki
2025-04-24 8:48 ` Marek Marczykowski-Górecki
2025-04-24 9:06 ` Gergo Koteles
2025-04-24 13:12 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed09edb167e74167a694f4854102a3de6d2f1433.camel@irl.hu \
--to=soyer@irl.hu \
--cc=alex.hung@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®