mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: "icue.retsam.diman" <icue.retsam.diman@bumblecito.com>
Cc: github@bumblecito.com, Russell King <linux@armlinux.org.uk>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	"David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3 1/2] net: sfp: add 2500base-X quirk for ODI DFP-34X-2C3
Date: Wed, 18 Nov 2026 21:32:45 +0100	[thread overview]
Message-ID: <ed0f62db-f2fc-45ff-9ccf-5aa3e50c243b@lunn.ch> (raw)
In-Reply-To: <4fb66a63-b483-4777-9fe4-b94ccbe733b3@SynologyNAS>

On Wed, Nov 18, 2026 at 02:08:44PM -0600, icue.retsam.diman wrote:

> 
> Hi Andrew,
> 
> I tested the module without the quirk using an unmodified OpenWrt SNAPSHOT build (r38465-2ccaccdb98) for the GoodTop GT-SWTXG8FM (realtek/rtl930x).
> 
> The ODI DFP-34X-2C3 successfully establishes a 1000base-X link with autonegotiation enabled.
> 
> The  ethtool lan8  output confirms:
> 
> Advertised link modes: 1000baseX/Full
> 
> Link partner advertised link modes: 1000baseX/Full
> 
> Advertised auto-negotiation: Yes
> 
> Link partner advertised auto-negotiation: Yes
> 
> Speed: 1000Mb/s
> 
> Duplex: Full
> 
> Auto-negotiation: on
> 
> Link detected: yes
> 
> With the quirk, I was able to establish a 2500 Mb/s link with speed and duplex forced and autonegotiation disabled.
> 
> Therefore, the module works with 1000base-X autonegotiation without the quirk, while the quirk enables 2500base-X operation.

Thanks for testing. You could add a Tested-by: if you want. That will
help get the change merge.

What i was afraid of is that for some reason 2500BaseX is rejected by
the other end, and it will only work at 1000BaseX. For a traditional
SFP, that would be true if the SFP on the other end of the fibre could
only do 1000BaseX. But this is not a traditional SFP, it is XPON. Can
the OLT say no to 2500BaseX, or is this purely down to what the ONT
can do?

	Andrew

  parent reply	other threads:[~2026-11-18 20:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 16:23 [PATCH net-next v3 0/2] net: sfp: add ODI quirk and sort SFP quirk entries github
2026-11-18 16:23 ` [PATCH net-next v3 1/2] net: sfp: add 2500base-X quirk for ODI DFP-34X-2C3 github
2026-11-18 18:15   ` Andrew Lunn
     [not found]     ` <4fb66a63-b483-4777-9fe4-b94ccbe733b3@SynologyNAS>
2026-11-18 20:32       ` Andrew Lunn [this message]
2026-11-18 16:23 ` [PATCH net-next v3 2/2] net: sfp: sort OEM and Turris SFP quirks github
2026-11-18 18:11   ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ed0f62db-f2fc-45ff-9ccf-5aa3e50c243b@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=github@bumblecito.com \
    --cc=hkallweit1@gmail.com \
    --cc=icue.retsam.diman@bumblecito.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®