From: "SL Baur" <steve@xemacs.org>
To: yi.zhu@intel.com
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] iwlwifi 3945 debug parameter should be writable via sysfs
Date: Mon, 21 Apr 2008 00:10:52 -0700 [thread overview]
Message-ID: <ed10ee420804210010g228aa4b7j9383e5417b7dcb8c@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1073 bytes --]
Is there any reason why the debug parameter in the iwlwifi driver
should be read-only?
(Patch inlined and attached since I'm sure it will get whitespace
broken).
The debug parameter of the Intel 3945ABG driver should be writable
via sysfs.
Signed-off-by: SL Baur <steve@xemacs.org>
---
This patch is against Linus' 2.6.25 release.
--- linux-2.6/drivers/net/wireless/iwlwifi/iwl3945-base.c~ 2008-04-17
10:15:33.000000000 -0700
+++ linux-2.6/drivers/net/wireless/iwlwifi/iwl3945-base.c 2008-04-20
23:49:35.000000000 -0700
@@ -8855,7 +8855,7 @@ MODULE_PARM_DESC(disable, "manually disa
module_param_named(hwcrypto, iwl3945_param_hwcrypto, int, 0444);
MODULE_PARM_DESC(hwcrypto,
"using hardware crypto engine (default 0 [software])\n");
-module_param_named(debug, iwl3945_param_debug, int, 0444);
+module_param_named(debug, iwl3945_param_debug, int, 0644);
MODULE_PARM_DESC(debug, "debug output mask");
module_param_named(disable_hw_scan, iwl3945_param_disable_hw_scan, int, 0444);
MODULE_PARM_DESC(disable_hw_scan, "disable hardware scanning (default 0)");
-sb
[-- Attachment #2: iwl3945-debug.patch --]
[-- Type: application/octet-stream, Size: 1021 bytes --]
The debug parameter of the Intel 3945ABF driver should be writable
via sysfs.
Signed-off-by: SL Baur <steve@xemacs.org>
---
This patch is against Linus' 2.6.25 release. I've only started to push
on it, but this driver works better on the same box than the Microsoft
Windows XP driver.
--- linux-2.6/drivers/net/wireless/iwlwifi/iwl3945-base.c~ 2008-04-17 10:15:33.000000000 -0700
+++ linux-2.6/drivers/net/wireless/iwlwifi/iwl3945-base.c 2008-04-20 23:49:35.000000000 -0700
@@ -8855,7 +8855,7 @@ MODULE_PARM_DESC(disable, "manually disa
module_param_named(hwcrypto, iwl3945_param_hwcrypto, int, 0444);
MODULE_PARM_DESC(hwcrypto,
"using hardware crypto engine (default 0 [software])\n");
-module_param_named(debug, iwl3945_param_debug, int, 0444);
+module_param_named(debug, iwl3945_param_debug, int, 0644);
MODULE_PARM_DESC(debug, "debug output mask");
module_param_named(disable_hw_scan, iwl3945_param_disable_hw_scan, int, 0444);
MODULE_PARM_DESC(disable_hw_scan, "disable hardware scanning (default 0)");
next reply other threads:[~2008-04-21 7:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-21 7:10 SL Baur [this message]
2008-04-21 21:51 ` Tomas Winkler
2008-04-22 4:30 ` SL Baur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed10ee420804210010g228aa4b7j9383e5417b7dcb8c@mail.gmail.com \
--to=steve@xemacs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®