From: "Nazle Asmade, Muhammad Nazim Amirul" <muhammad.nazim.amirul.nazle.asmade@altera.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"mcoquelin.stm32@gmail.com" <mcoquelin.stm32@gmail.com>,
"alexandre.torgue@foss.st.com" <alexandre.torgue@foss.st.com>,
"rmk+kernel@armlinux.org.uk" <rmk+kernel@armlinux.org.uk>,
"maxime.chevallier@bootlin.com" <maxime.chevallier@bootlin.com>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: stmmac: xgmac: report L3/L4 filter match count in ethtool stats
Date: Fri, 5 Jun 2026 02:04:42 +0000 [thread overview]
Message-ID: <ed1ead6c-0505-4e56-97e3-b8e32e3e8e2b@altera.com> (raw)
In-Reply-To: <5e912b43-7c06-4d04-9ba0-8f929150429c@lunn.ch>
On 5/6/2026 3:30 am, Andrew Lunn wrote:
> On Thu, Jun 04, 2026 at 01:30:37AM -0700, muhammad.nazim.amirul.nazle.asmade@altera.com wrote:
>> From: Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@altera.com>
>>
>> Read the L3FM and L4FM bits from the RX descriptor status word (RDES2)
>> and increment the corresponding ethtool statistics counters. This allows
>> users to observe L3/L4 filter hit rates via ethtool -S.
>
> Are there any more bits which are missing?
>
> dwmac4 has RDES2_L3_L4_FILT_NB_MATCH_MASK for example.
>
> Andrew
Hi Jakub, Andrew
Thanks for the review!
To reply on Andrew question - As per what I'm seeing, the XGMAC2 RDES2
only defines L3FM (bit 27) and L4FM (bit 28) — there is no FILT_NB_MATCH
equivalent in the XGMAC2 descriptor layout, unlike dwmac4 which exposes
it via RDES2 bits [27:26]. This patch covers all filter match bits
available in XGMAC2 RDES2.
BR,
Nazim
next prev parent reply other threads:[~2026-06-05 2:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-04 8:30 muhammad.nazim.amirul.nazle.asmade
2026-06-04 19:05 ` Jacob Keller
2026-06-04 19:30 ` Andrew Lunn
2026-06-05 2:04 ` Nazle Asmade, Muhammad Nazim Amirul [this message]
2026-06-05 14:04 ` Andrew Lunn
2026-06-05 14:55 ` Maxime Chevallier
2026-06-06 2:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed1ead6c-0505-4e56-97e3-b8e32e3e8e2b@altera.com \
--to=muhammad.nazim.amirul.nazle.asmade@altera.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=maxime.chevallier@bootlin.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®