From: Lars-Peter Clausen <lars@metafoo.de>
To: Colin King <colin.king@canonical.com>,
Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
sayli karnik <karniksayli1995@gmail.com>,
Matt Ranostay <mranostay@gmail.com>,
Wei Yongjun <weiyongjun1@huawei.com>,
linux-iio@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: maxim_thermocouple: return -EINVAL on invalid read size
Date: Tue, 25 Oct 2016 21:11:21 +0200 [thread overview]
Message-ID: <ed223a81-32c1-d339-b4e1-16b8fca88b2e@metafoo.de> (raw)
In-Reply-To: <20161025190408.5012-1-colin.king@canonical.com>
On 10/25/2016 09:04 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> In the case that the read size is not 2 or 4 bytes
> then maxim_thermocouple_read is not initializing ret and
> hence may return early with a bogus error return or
> just through to return with a bogos unread value in *val.
> Fix this by setting ret to -EINVAL for invalid (unhandled)
> read sizes.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Again, Arnd already took the prize, https://lkml.org/lkml/2016/10/25/518
next prev parent reply other threads:[~2016-10-25 19:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-25 19:04 Colin King
2016-10-25 19:11 ` Lars-Peter Clausen [this message]
2016-10-25 20:05 ` Colin Ian King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed223a81-32c1-d339-b4e1-16b8fca88b2e@metafoo.de \
--to=lars@metafoo.de \
--cc=colin.king@canonical.com \
--cc=jic23@kernel.org \
--cc=karniksayli1995@gmail.com \
--cc=knaack.h@gmx.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mranostay@gmail.com \
--cc=pmeerw@pmeerw.net \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®