From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B25EAC77B6E for ; Fri, 14 Apr 2023 17:16:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229839AbjDNRQj (ORCPT ); Fri, 14 Apr 2023 13:16:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229846AbjDNRQh (ORCPT ); Fri, 14 Apr 2023 13:16:37 -0400 Received: from mail-io1-xd2b.google.com (mail-io1-xd2b.google.com [IPv6:2607:f8b0:4864:20::d2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0EC354C06 for ; Fri, 14 Apr 2023 10:16:18 -0700 (PDT) Received: by mail-io1-xd2b.google.com with SMTP id ca18e2360f4ac-760a66d23f8so5729539f.0 for ; Fri, 14 Apr 2023 10:16:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1681492576; x=1684084576; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Buw5s+0gaY0E7Wr5Fq9wEF/Hip04x/ZdzqMji/rutIE=; b=bHOe9TFrH4/VKBj3A+FcHcyWn4+tT1FVtSMNearIfC5jxl102ZfYzmcnXMBsbnCkOI aUfliKM8CRbSwru0o9Xh+owG/ntgA2iIemctzdiFqI6Y0eSLWxjKm7vtXeAg1jMTTHqV kFhDfQEarNbENRz3xsOU/ErCc7jWXukYsJdqk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681492576; x=1684084576; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Buw5s+0gaY0E7Wr5Fq9wEF/Hip04x/ZdzqMji/rutIE=; b=i/LURK3ywb2jO8eytnKuITAyjgOGfA2JDD9xc0jlqIsqqFo3qwf0/7fGQsjsJr29jn MO7arWRm3gxqZ/jjxFaaeyN9Au96Z6hza4lSwrQw0fpdAqkI4W8OskvQ2XHALTiQDhv7 CvHyjNQMW22tjLkgUvJWkReMoZ/WMdoRKjlZRTi95sG7bLyw6bHoCvJgMpwFbvyWnRZa 80LRzApbZdp/jqu8WMWSumlebFcK0SHxkBLeWkuE/PBQAI+YI+vUJghMAn+1tr5e3TDn QqSZz6K+Kjz3PVZozBHLxysM5uRXRrE3I+0aQi9t3SriTq1yp9xq2zQg1LbN0nrhUpXF L3gg== X-Gm-Message-State: AAQBX9ckDa/FlP9LThotVExfXspV6/sS0yXaKMxmfvQmCxb5tczNds96 OOBtbEYGAAlLmYd8NWMF0bO4KQ== X-Google-Smtp-Source: AKy350aw0bhU7xOJqHwM0rxF0YzFhl8KIwrx3RgDTncD3q1BnV0dHf+lbfE2WZa/5ZYz4MuHw0sElQ== X-Received: by 2002:a05:6e02:2147:b0:329:5d05:7801 with SMTP id d7-20020a056e02214700b003295d057801mr1903362ilv.0.1681492576111; Fri, 14 Apr 2023 10:16:16 -0700 (PDT) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id 62-20020a021141000000b0040bd8fcaa4bsm765874jaf.63.2023.04.14.10.16.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Apr 2023 10:16:15 -0700 (PDT) Message-ID: Date: Fri, 14 Apr 2023 11:16:15 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH] selftests/resctrl: Fix incorrect error return on test complete Content-Language: en-US To: Reinette Chatre , shuah@kernel.org Cc: ilpo.jarvinen@linux.intel.com, tan.shaopeng@jp.fujitsu.com, fenghua.yu@intel.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <37df0986015ecedec9a0244bdb0aa7c073bfe714.1681490161.git.reinette.chatre@intel.com> From: Shuah Khan In-Reply-To: <37df0986015ecedec9a0244bdb0aa7c073bfe714.1681490161.git.reinette.chatre@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/14/23 10:43, Reinette Chatre wrote: > An error snuck in between two recent conflicting changes: > Until recently ->setup() used negative values to indicate > normal test termination. This was changed in > commit fa10366cc6f4 ("selftests/resctrl: Allow ->setup() to return > errors") that transitioned ->setup() to use negative values > to indicate errors and a new END_OF_TESTS to indicate normal > termination. > > commit 42e3b093eb7c ("selftests/resctrl: Fix set up schemata with 100% > allocation on first run in MBM test") continued to use > negative return to indicate normal test termination. > > Fix mbm_setup() to use the new END_OF_TESTS to indicate > error-free test termination. > > Fixes: 42e3b093eb7c ("selftests/resctrl: Fix set up schemata with 100% allocation on first run in MBM test") > Reported-by: Ilpo Järvinen > Link: https://lore.kernel.org/lkml/bb65cce8-54d7-68c5-ef19-3364ec95392a@linux.intel.com/ > Signed-off-by: Reinette Chatre > --- > Hi Shuah, > > Apologies, this error snuck in between the two series > merged into kselftest's next this week. > No worries. This is now applied on top of others to linux-kselftest net. thanks, -- Shuah