From: Marc Gonzalez <marc.w.gonzalez@free.fr>
To: Bjorn Andersson <bjorn.andersson@linaro.org>,
Kishon Vijay Abraham I <kishon@ti.com>
Cc: MSM <linux-arm-msm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Evan Green <evgreen@chromium.org>,
Vivek Gautam <vivek.gautam@codeaurora.org>,
Niklas Cassel <niklas.cassel@linaro.org>,
Stanimir Varbanov <svarbanov@mm-sol.com>
Subject: Re: [PATCH] phy: qcom-qmp: Correct READY_STATUS poll break condition
Date: Wed, 19 Jun 2019 14:43:36 +0200 [thread overview]
Message-ID: <ed29cd18-81de-f90d-474b-30612418a67e@free.fr> (raw)
In-Reply-To: <3570d880-2b76-88ae-8721-e75cf5acec4c@free.fr>
On 13/06/2019 11:10, Marc Gonzalez wrote:
> Here are my observations for a 8998 board:
>
> 1) If I apply only the readl_poll_timeout() fix (not the mask_pcs_ready fixup)
> qcom_pcie_probe() fails with a timeout in phy_init.
> => this is in line with your regression analysis.
>
> 2) Your patch also fixes a long-standing bug in UFS init whereby sending
> lots of information to the console during phy init would lead to an
> incorrectly diagnosed time-out.
>
> Good stuff!
>
> Reviewed-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
> Tested-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
Hello Kishon,
Could you take this patch through your tree?
It fixes a pair of nasty bugs.
I do have a follow-up (trivial) patch on top of this one:
https://lore.kernel.org/patchwork/patch/1088044/
What are your thoughts on the usleep_range issue?
https://lore.kernel.org/patchwork/patch/1088035/
Regards.
next prev parent reply other threads:[~2019-06-19 12:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-04 23:24 Bjorn Andersson
2019-06-04 23:35 ` Evan Green
2019-06-12 13:08 ` Niklas Cassel
2019-06-12 17:34 ` Bjorn Andersson
2019-06-12 16:24 ` Marc Gonzalez
2019-06-12 17:25 ` Bjorn Andersson
2019-06-13 9:10 ` Marc Gonzalez
2019-06-19 12:43 ` Marc Gonzalez [this message]
2019-07-19 15:50 ` Marc Gonzalez
2019-07-23 10:31 ` Marc Gonzalez
2019-08-02 19:54 ` Marc Gonzalez
2019-08-06 0:43 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed29cd18-81de-f90d-474b-30612418a67e@free.fr \
--to=marc.w.gonzalez@free.fr \
--cc=bjorn.andersson@linaro.org \
--cc=evgreen@chromium.org \
--cc=kishon@ti.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=niklas.cassel@linaro.org \
--cc=svarbanov@mm-sol.com \
--cc=vivek.gautam@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®