From: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
To: Brian Norris <briannorris@chromium.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@redhat.com>,
linux-kernel@vger.kernel.org, Michal Hocko <mhocko@suse.com>,
Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Vlastimil Babka <vbabka@suse.cz>,
linux-mm@kvack.org, "Liam R. Howlett" <Liam.Howlett@oracle.com>
Subject: Re: [PATCH] mm: vm_event_item: Explicit #include for THREAD_SIZE
Date: Thu, 11 Sep 2025 13:43:23 +0100 [thread overview]
Message-ID: <ed2fd382-7b56-4007-8915-88e91cce11f5@lucifer.local> (raw)
In-Reply-To: <20250909201419.827638-1-briannorris@chromium.org>
On Tue, Sep 09, 2025 at 01:13:57PM -0700, Brian Norris wrote:
> This header uses THREAD_SIZE, which is provided by the thread_info.h
> header but is not included in this header. Depending on the #include
> ordering in other files, this can produce preprocessor errors.
>
> Signed-off-by: Brian Norris <briannorris@chromium.org>
This LGTM, so:
Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> ---
>
> include/linux/vm_event_item.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/vm_event_item.h b/include/linux/vm_event_item.h
> index 9e15a088ba38..92f80b4d69a6 100644
> --- a/include/linux/vm_event_item.h
> +++ b/include/linux/vm_event_item.h
> @@ -2,6 +2,8 @@
> #ifndef VM_EVENT_ITEM_H_INCLUDED
> #define VM_EVENT_ITEM_H_INCLUDED
>
> +#include <linux/thread_info.h>
> +
> #ifdef CONFIG_ZONE_DMA
> #define DMA_ZONE(xx) xx##_DMA,
> #else
> --
> 2.51.0.384.g4c02a37b29-goog
>
prev parent reply other threads:[~2025-09-11 12:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-09 20:13 Brian Norris
2025-09-09 23:53 ` Andrew Morton
2025-09-10 0:01 ` Brian Norris
2025-09-11 12:43 ` Lorenzo Stoakes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed2fd382-7b56-4007-8915-88e91cce11f5@lucifer.local \
--to=lorenzo.stoakes@oracle.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=briannorris@chromium.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=rppt@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®