From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752001AbdB0KFP (ORCPT ); Mon, 27 Feb 2017 05:05:15 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40342 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751654AbdB0KDz (ORCPT ); Mon, 27 Feb 2017 05:03:55 -0500 Subject: Re: [PATCH v2 4/5] KVM: MIPS: remove useless kvm_request_clear To: Andrew Jones , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= References: <20170224195002.28030-1-rkrcmar@redhat.com> <20170224195002.28030-5-rkrcmar@redhat.com> <20170227084539.oq3uviixwsjtmpdj@kamzik.brq.redhat.com> Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Paolo Bonzini , Marc Zyngier , Christian Borntraeger , Cornelia Huck , James Hogan , Paul Mackerras , Christoffer Dall From: David Hildenbrand Organization: Red Hat GmbH Message-ID: Date: Mon, 27 Feb 2017 11:03:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170227084539.oq3uviixwsjtmpdj@kamzik.brq.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Mon, 27 Feb 2017 10:03:56 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 27.02.2017 um 09:45 schrieb Andrew Jones: > On Fri, Feb 24, 2017 at 08:50:01PM +0100, Radim Krčmář wrote: >> Signed-off-by: Radim Krčmář >> --- >> arch/mips/kvm/emulate.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/arch/mips/kvm/emulate.c b/arch/mips/kvm/emulate.c >> index 552ae2b5e911..70614ca41744 100644 >> --- a/arch/mips/kvm/emulate.c >> +++ b/arch/mips/kvm/emulate.c >> @@ -865,7 +865,6 @@ enum emulation_result kvm_mips_emul_wait(struct kvm_vcpu *vcpu) >> * check if any I/O interrupts are pending. >> */ >> if (kvm_request_test_and_clear(KVM_REQ_UNHALT, vcpu)) { >> - __kvm_request_clear(KVM_REQ_UNHALT, vcpu); >> vcpu->run->exit_reason = KVM_EXIT_IRQ_WINDOW_OPEN; >> } > > should remove the {} too. > With that, Reviewed-by: David Hildenbrand -- Thanks, David