From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Vijaya Anand <sunrockers8@gmail.com>,
lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Daniel Baluta <daniel.baluta@nxp.com>
Subject: Re: [PATCH v2] ASoC: dt-bindings: adi,adau17x1: Convert to DT schema
Date: Thu, 16 Mar 2023 09:03:01 +0100 [thread overview]
Message-ID: <ed3358f2-cdd8-4cbf-48ed-3f8f462badee@linaro.org> (raw)
In-Reply-To: <20230315231055.3067-1-sunrockers8@gmail.com>
On 16/03/2023 00:10, Vijaya Anand wrote:
> Convert the binding document for adi,adau17x1 from txt to yaml
> so one could validate dt-entries correctly and any future additions
> can go into yaml format. Add address and size cells to example to
> prevent errors regarding reg format.
>
> Signed-off-by: Vijaya Anand <sunrockers8@gmail.com>
> Cc: Daniel Baluta <daniel.baluta@nxp.com>
> ---
> Changes since v1:
> - added 'Codec' in title to clarify type of devices
> - put compatible devices in lexographic order
> - changed description of clocks
> - changed 'unevaluatedProperties' to 'additionalProperties'
> - changed node names to be generic
You sent a v2, so this should be v3. Keep it consistent, otherwise it
confuses reviewers...
>
> ---
> .../bindings/sound/adi,adau17x1.txt | 32 ------------
> .../bindings/sound/adi,adau17x1.yaml | 52 +++++++++++++++++++
> 2 files changed, 52 insertions(+), 32 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/sound/adi,adau17x1.txt
> create mode 100644 Documentation/devicetree/bindings/sound/adi,adau17x1.yaml
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-03-16 8:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 23:10 Vijaya Anand
2023-03-16 8:03 ` Krzysztof Kozlowski [this message]
2023-03-16 13:53 ` Rob Herring
2023-03-16 19:17 ` Krzysztof Kozlowski
2023-03-16 14:18 ` Mark Brown
2023-03-16 19:16 ` Krzysztof Kozlowski
2023-03-16 19:45 ` Mark Brown
2023-03-17 9:25 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed3358f2-cdd8-4cbf-48ed-3f8f462badee@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sunrockers8@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®