Re: [PATCH v4 2/4] drm/kmb/dsi: convert to of_drm_find_and_get_bridge()

[Louis Chauvet <louis.chauvet@bootlin.com>]

On 4/2/26 18:27, Luca Ceresoli wrote:
> of_drm_find_bridge() is deprecated. Move to its replacement
> of_drm_find_and_get_bridge() which gets a bridge reference.
> 
> This driver has global variables for the DSI host and DSI device, and code
> to allocate them on probe but no code to free them when on remove. So it
> does not at all support removal, and not even multiple instances. For this
> reason putting the reference would be pointless here.
> 
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>

Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com>

> ---
>   drivers/gpu/drm/kmb/kmb_dsi.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/kmb/kmb_dsi.c b/drivers/gpu/drm/kmb/kmb_dsi.c
> index aeb2f9f98f23..febca939bd01 100644
> --- a/drivers/gpu/drm/kmb/kmb_dsi.c
> +++ b/drivers/gpu/drm/kmb/kmb_dsi.c
> @@ -251,7 +251,7 @@ int kmb_dsi_host_bridge_init(struct device *dev)
>   		return -EINVAL;
>   	}
>   	/* Locate drm bridge from the hdmi encoder DT node */
> -	adv_bridge = of_drm_find_bridge(encoder_node);
> +	adv_bridge = of_drm_find_and_get_bridge(encoder_node);
>   	of_node_put(dsi_out);
>   	of_node_put(encoder_node);
>   	if (!adv_bridge) {
>