From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D725C7EE2F for ; Wed, 7 Jun 2023 17:17:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231234AbjFGRR1 (ORCPT ); Wed, 7 Jun 2023 13:17:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230037AbjFGRRZ (ORCPT ); Wed, 7 Jun 2023 13:17:25 -0400 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49D2E1BDC; Wed, 7 Jun 2023 10:17:24 -0700 (PDT) Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-655fce0f354so2409816b3a.0; Wed, 07 Jun 2023 10:17:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686158244; x=1688750244; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DFPGwpCQpZDlbK+2dcezD0d5mxiO5AMq/+/AN27SQOM=; b=Yc9OAdceP2EkMmzV5XHhv1rtLxoDRavVLZ4CyMM3lMoTYc6R2MHT9itt/VftOWArtu kuOnhb/Pkh9I4k5GuFBO2OcF8jnJaYVPA+GzRrE7r1z/pmnRQuvptgnguOItL1Zq7W1i IFs08raDkz4Bv7bvGTdvkJhhjG5YX12VLzq/VgwNiOWAAKN0Wme20PIpDNdQo5RpXf6T 0rte9LSqojdgJxdhtPf+m1LFGb64MSRedxQHOT2FYPCOJJvjOrcwWKi0fvubGZJHt8lm DxUQO0AEheISX0ra6e61Ggv7D8Q9jAxYFFczZPZB67JELyyiInjmca8pcKMeDaKlcQq3 Vw5A== X-Gm-Message-State: AC+VfDw8F5OEhlHqX1FO9FAGXfqV5QOJ1/QTEqDOOg4yN+QSetR+5FwB /DJFtpODVquFXqoMQuZfED4= X-Google-Smtp-Source: ACHHUZ7v8zzX5zKgbuGtCNfhzwZXUtn5YrrNGyBjX3Hfyxj9y8BR90kt2+NZlmgBHihAc8RVnQ2zPg== X-Received: by 2002:a05:6a20:7293:b0:10f:13bb:5d4f with SMTP id o19-20020a056a20729300b0010f13bb5d4fmr2039900pzk.2.1686158243558; Wed, 07 Jun 2023 10:17:23 -0700 (PDT) Received: from [192.168.3.219] ([98.51.102.78]) by smtp.gmail.com with ESMTPSA id d10-20020a631d0a000000b0051b36aee4f6sm9349487pgd.83.2023.06.07.10.17.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Jun 2023 10:17:23 -0700 (PDT) Message-ID: Date: Wed, 7 Jun 2023 10:17:22 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH] scsi: ufs-mediatek: add dependency for RESET_CONTROLLER Content-Language: en-US To: Randy Dunlap , linux-kernel@vger.kernel.org Cc: kernel test robot , Stanley Chu , Peter Wang , Paul Gazzillo , Necip Fazil Yildiran , linux-scsi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, "James E.J. Bottomley" , "Martin K. Petersen" References: <20230602023957.9187-1-rdunlap@infradead.org> From: Bart Van Assche In-Reply-To: <20230602023957.9187-1-rdunlap@infradead.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/1/23 19:39, Randy Dunlap wrote: > When RESET_CONTROLLER is not set, kconfig complains about missing > dependencies for RESET_TI_SYSCON, so add the missing dependency > just as is done above for SCSI_UFS_QCOM. > > Silences this kconfig warning: > > WARNING: unmet direct dependencies detected for RESET_TI_SYSCON > Depends on [n]: RESET_CONTROLLER [=n] && HAS_IOMEM [=y] > Selected by [m]: > - SCSI_UFS_MEDIATEK [=m] && SCSI_UFSHCD [=y] && SCSI_UFSHCD_PLATFORM [=y] && ARCH_MEDIATEK [=y] > > Fixes: de48898d0cb6 ("scsi: ufs-mediatek: Create reset control device_link") > Signed-off-by: Randy Dunlap > Reported-by: kernel test robot > Link: lore.kernel.org/r/202306020859.1wHg9AaT-lkp@intel.com > Cc: Stanley Chu > Cc: Peter Wang > Cc: Paul Gazzillo > Cc: Necip Fazil Yildiran > Cc: linux-scsi@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-mediatek@lists.infradead.org > Cc: "James E.J. Bottomley" > Cc: "Martin K. Petersen" > --- > drivers/ufs/host/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff -- a/drivers/ufs/host/Kconfig b/drivers/ufs/host/Kconfig > --- a/drivers/ufs/host/Kconfig > +++ b/drivers/ufs/host/Kconfig > @@ -72,6 +72,7 @@ config SCSI_UFS_QCOM > config SCSI_UFS_MEDIATEK > tristate "Mediatek specific hooks to UFS controller platform driver" > depends on SCSI_UFSHCD_PLATFORM && ARCH_MEDIATEK > + depends on RESET_CONTROLLER > select PHY_MTK_UFS > select RESET_TI_SYSCON > help Hmm ... is the above patch complete? Shouldn't a similar dependency be added to the ufs-hisi and ufs-sprd drivers? See also the following git grep output: $ git grep -nH 'include.*linux/reset.h' */ufs drivers/ufs/host/ufs-hisi.c:16:#include drivers/ufs/host/ufs-mediatek.c:21:#include drivers/ufs/host/ufs-qcom.h:9:#include drivers/ufs/host/ufs-sprd.c:14:#include Thanks, Bart.