From: Joe Perches <joe@perches.com>
To: Harry Wentland <harry.wentland@amd.com>,
Deepak R Varma <drv@mailo.com>,
Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
Alex Deucher <alexander.deucher@amd.com>,
Aurabindo Pillai <aurabindo.pillai@amd.com>
Cc: "Leo Li" <sunpeng.li@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Pan, Xinhui" <Xinhui.Pan@amd.com>,
"David Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org,
"Saurabh Singh Sengar" <ssengar@microsoft.com>,
"Praveen Kumar" <kumarpraveen@linux.microsoft.com>
Subject: Re: [PATCH] drm/amd/display: Simplify same effect if/else blocks
Date: Sat, 04 Mar 2023 15:48:05 -0800 [thread overview]
Message-ID: <ed3f46b20241a87f666a92441383e7fa55d9eadb.camel@perches.com> (raw)
In-Reply-To: <4d670a5c-b680-ba76-a640-88b3d945c0b0@amd.com>
On Fri, 2023-03-03 at 15:35 -0500, Harry Wentland wrote:
> Actually I was wrong. Too many similar-looking snippets in this
> function made me look at the wrong thing. This change is fine and
> Reviewed-by: Harry Wentland <harry.wentland@amd.com.
So why was the change made in the first place?
Please explain commit 9114b55fabae.
next prev parent reply other threads:[~2023-03-04 23:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-15 10:00 Deepak R Varma
2023-01-15 20:52 ` Joe Perches
2023-01-22 18:53 ` Deepak R Varma
2023-03-01 20:21 ` Deepak R Varma
2023-03-02 16:37 ` Harry Wentland
2023-03-03 17:50 ` Deepak R Varma
2023-03-03 20:35 ` Harry Wentland
2023-03-04 23:48 ` Joe Perches [this message]
2023-03-03 21:11 ` Hamza Mahfooz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed3f46b20241a87f666a92441383e7fa55d9eadb.camel@perches.com \
--to=joe@perches.com \
--cc=Rodrigo.Siqueira@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=aurabindo.pillai@amd.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=drv@mailo.com \
--cc=harry.wentland@amd.com \
--cc=kumarpraveen@linux.microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ssengar@microsoft.com \
--cc=sunpeng.li@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®