From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752163AbcEYV64 (ORCPT ); Wed, 25 May 2016 17:58:56 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:34494 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751284AbcEYV6z (ORCPT ); Wed, 25 May 2016 17:58:55 -0400 From: Salah Triki To: akpm@linux-foundation.org Cc: Salah Triki , linux-kernel@vger.kernel.org Subject: [PATCH 1/2] fs: befs: Move useless assignment Date: Wed, 25 May 2016 22:58:31 +0100 Message-Id: X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Control is transfered to unacquire_none when sb->s_fs_info is equal to NULL, so the assignment to NULL is useless and it is moved above unacquire_none. Signed-off-by: Salah Triki --- fs/befs/linuxvfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c index 7da05b1..75ec9a7 100644 --- a/fs/befs/linuxvfs.c +++ b/fs/befs/linuxvfs.c @@ -870,9 +870,9 @@ befs_fill_super(struct super_block *sb, void *data, int silent) unacquire_priv_sbp: kfree(befs_sb->mount_opts.iocharset); kfree(sb->s_fs_info); + sb->s_fs_info = NULL; unacquire_none: - sb->s_fs_info = NULL; return ret; } -- 1.9.1