From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1DA01344DAC for ; Thu, 11 Jun 2026 12:22:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781180572; cv=none; b=ARiUtJSsT/7JMzMMeu3Eh9mdNre6vP59K2qxygixICP7gULxbppbEYMeWpQrd5MciIc9MfARSQLfax+ZwOAZ9e22kt7RSeirYI1nkTfq9dqGGXPu+wjxWltFVLAQjNC8/SNad3CqOzZ1E+BSBOz9yW73PFagPJ0Slx35UjVC24E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781180572; c=relaxed/simple; bh=6mybAxFWA9piKMYdQTC95b5ZGi6YKc2Dvduxn+GK1Rs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=V66eb7YMCtDWH+lcaTddksG8vOXTGLRc05zqdPOCJxoE8q0nRRC/zTZcYIJ+vsMUQhkx0SUvantdkLemVmPqJh87+MPTIITS9TgQi7GmDZ9rfl3i76WYSFwe4MH9IsIwfQM/qeTL8JueBL9nVIjLxEXXObe+YlXMFZU2T7tgqq4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=sZuwcPG3; arc=none smtp.client-ip=209.85.167.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="sZuwcPG3" Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-5aa68da4e45so709134e87.2 for ; Thu, 11 Jun 2026 05:22:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1781180569; x=1781785369; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=3UVAPv+vJYyMdfCgAAqYJ+tpswqCocudVoYqqRm2LCg=; b=sZuwcPG3VczZISaPBGPUIykdEVbYJmqWYESl0nQwgXSBnWyTgIQx+NZWRAXknB/oBd i7jzaBuPwUV5Eaz1P9UvlsuO+18UVjbHf2PKL8Mltx8H09UjN3nvf2tL+fcKDz1ylKuY 1pHLnMxxk7Gju4UrFZsszu2s0brHQs4i0PXmmsR+4Pr+50dOEbXGIq3D+7RVMFMTVIoM euvfJGEKm2UELN6qTQ2z6G2pb81APsN/FIxtGLiDDSDfXIgFZkXG/KJZe1EJuXlGxCSk h1Wy9jsHN/7KsPEyYyxKQ88nzCXu9QbGQZXgzHnQBwXriPQdJhDu5tDVuiQzCZhR46Yk qS5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781180569; x=1781785369; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=3UVAPv+vJYyMdfCgAAqYJ+tpswqCocudVoYqqRm2LCg=; b=buzx1Lc63xnJkQV5X2XsONtfLSzJSRr4YAz1gqLWCD9she//xVkY94NCxNdSGTFuoZ EyiZ/EMKb53MVSyqV+0VQtBcaiASDtgEDsnUgmmc3zw0d0VUVMH7mUR+z2quNUGq3HYd UbhjmF0+L+blNamKpGXMeyj0W7ubsaO/mMbgR23nFsFlPkEEgTFe7DexdMmYrXy1yyMK RVHm0uggTbgGez20jijeGUmlEu09yLlXiIkYFLub0xdx39/b4cRpFg6ODR8n7/1LK23+ Lur524bDnOVym0sC8rWqJxpRqznu6PJDlmSbfE6hRKf+/lK4+ZKbqJ+KKZ7zT6XL/5dv RdGQ== X-Forwarded-Encrypted: i=1; AFNElJ8kfxOgBfK60lERjfZtPOULj1nKZp16C9taZHFPagm6EKGpBbIY+SKb3LNnQphBrjBeqriAb08y9zStihY=@vger.kernel.org X-Gm-Message-State: AOJu0Yy1S/hxFte1Ht29dD3tEwtz0CCAPNjxmuAsuYFmjyHpQk5Oi423 Bm1F9vi6Ua+WZq0C7VJujk1zqmkfA686Ke/yaNYmL5P7LQyohnMdNfMu0L38zibwB5UHYJE1ZG8 B/5JJN4g= X-Gm-Gg: Acq92OHYBNPFHtsG3JLY36dEjUmHTJV7RSa4L00VTWhYqaoKxNLMmtqFegCe558BN57 NcshBJ1ys/QAMcTttwupAmxp20Ayy/yc1UubdDxfXvyIxV0tc3JKU0+wI3Mx1hH+Yb//NCbuf5S AQ8n0R+5FRs56YOzOy4gtfR1t9C/3vtkk9kMnK204s1fUbWpIA5DzEJYbrh8bBQTGnHv4qcv3q6 1PIdHJHlCtyWt9vryXWX0VOAMIG9Xz/Hdl4obUoELDwL1Q6t4cGgC0bo5wmMSUDMtgKNVKrfY86 6DJC+7x3A5MlMJdSeN86kdz+pMRLJ7c01Dmkc/RIynOmbm7lnWK8KckhSFtiXXmr529wOLx950Z BY4gmuYtwtYbwjeEgjlAmxyaIs+nH+hVSZr6qLSXRzgPUrcrECXuVhlrJrxaZXgwOXn70QPavT5 dc+zlrtJLI+m1OiVe7vVSR2AxHjmkoQYOCSdjYyO87QM50tGi+BEHscaIf2/kuU9zyLtUPa8+gD +ADrCfvi4vPs2TU X-Received: by 2002:a05:6512:1548:b0:5ad:2ac0:9fb0 with SMTP id 2adb3069b0e04-5ad2ac0a109mr69074e87.4.1781180569120; Thu, 11 Jun 2026 05:22:49 -0700 (PDT) Received: from [192.168.1.100] (91-159-24-186.elisa-laajakaista.fi. [91.159.24.186]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5aa7b8fc8d9sm6258927e87.28.2026.06.11.05.22.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jun 2026 05:22:48 -0700 (PDT) Message-ID: Date: Thu, 11 Jun 2026 15:22:47 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 2/9] media: qcom: camss: csiphy-3ph: Fix lane mask calculation To: david@ixit.cz, Robert Foss , Todor Tomov , Bryan O'Donoghue , Bryan O'Donoghue , Mauro Carvalho Chehab , Luca Weiss , Petr Hodina , "Dr. Git" , Cory Keitz , Loic Poulain , Hans Verkuil , Nihal Kumar Gupta Cc: Frank Li , Konrad Dybcio , Kieran Bingham , Sakari Ailus , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org, stable@vger.kernel.org References: <20260610-qcom-cphy-v8-0-cd4387785179@ixit.cz> <20260610-qcom-cphy-v8-2-cd4387785179@ixit.cz> From: Vladimir Zapolskiy In-Reply-To: <20260610-qcom-cphy-v8-2-cd4387785179@ixit.cz> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 6/10/26 21:28, David Heidelberg via B4 Relay wrote: > From: David Heidelberg > > The lane mask must be multiplied by 2, but this was accidentally omitted. Fortunately this computed lane mask value has never been used expectedly by csiphy-3ph users. > > Fixes: c94d21ffa814 ("media: camss: Add CSIPHY files") > Cc: stable@vger.kernel.org > Suggested-by: Nihal Kumar Gupta > Signed-off-by: David Heidelberg Fixes shall be the first patches in any series, please reorder for v9. Then, formally it looks like a fix, but to my understanding it's just a noop change against the current upstream codebase, thus the change is not justified to gain the Fixes tag, see Documentation/process/stable-kernel-rules.rst. > --- > drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c > index dac8d2ecf7995..7c8c0e41bc62f 100644 > --- a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c > +++ b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c > @@ -1114,17 +1114,17 @@ static void csiphy_gen2_config_lanes(struct csiphy_device *csiphy, > static u8 csiphy_get_lane_mask(struct csiphy_lanes_cfg *lane_cfg) > { > u8 lane_mask; > int i; > > lane_mask = CSIPHY_3PH_CMN_CSI_COMMON_CTRL5_CLK_ENABLE; > > for (i = 0; i < lane_cfg->num_data; i++) > - lane_mask |= 1 << lane_cfg->data[i].pos; > + lane_mask |= BIT(lane_cfg->data[i].pos * 2); > > return lane_mask; > } > > static bool csiphy_is_gen2(u32 version) > { > bool ret = false; > > After dropping Fixes tag and cc to stable, Reviewed-by: Vladimir Zapolskiy -- Best wishes, Vladimir