From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B00F51865E3 for ; Tue, 26 Nov 2024 10:29:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732616974; cv=none; b=HkpvgpOQPQ5FaZIIBWUlm94O1ClGY4E/jDTpG3+fLkNd6axJ8QsF9FgDPcy2rlBhUxLJ6rkWg7LlmZRZgfBjT3LGVX8c7Mvi36yjKEkRAvydsIfKtMGsuE5nEv9IYzyCpHh3LvHZnjUGq+UDmxHAMBJSEhqCK0PuCLyEOzET8RI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732616974; c=relaxed/simple; bh=NjyGHAc2oi2KnpU+ygfb/gz2HMXg+H1wEaeSlojCR3A=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=t2nRxW3usIEO8fe6b3ITbVcmQ/8CT+nX7yeR8xJgPJxv1sZxgH3QRitNIFZSgMVZG3xNjwwqZz80ksZl7OwDuJoZg7sSnseDudJkxhatgcqaaK1Dat2tQQcDOLYcFbEkqv6st0NkJ3BqaD+e3ztmoCfcgiA2kkUi4j/6wETKtxQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=ZfhKKIs9; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="ZfhKKIs9" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4349e4e252dso19405235e9.0 for ; Tue, 26 Nov 2024 02:29:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1732616970; x=1733221770; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VDslh+ljpVvNODtMmRwl8AAxwmvJGoBek7yI5XWC5Bw=; b=ZfhKKIs9ee7qrNgXwe62rmxzIBu4nbCtLtSnk5m2+/DlY3HuS2iGuU9Vr8g7UOGoB6 3wYWwzi2tIiZxSHdjDXe8hQ60LzAtJ37Y2AvNC4N+zxuuud01hZviokyEyXSyNsuMmD3 qhLhlT9TxamMdXuKvx3NDwc8CXyEvtnVTILJHqVe8pAVu4olOjMMOTcO15/+BKHA0RnI MLv5dfI1iJQ9MstmzWSDj13uVT/x0P4idvt8j4Mxh4IaUuQn0eBS2o4FK+AgqA9r0ur9 eyVswcMljopGBZjQjDV7iNdf02WMkUnxh1rzWDak1xjASh+VuxBqoPXSGa/O/lTIzFmz g7kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732616970; x=1733221770; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VDslh+ljpVvNODtMmRwl8AAxwmvJGoBek7yI5XWC5Bw=; b=I+udGBWHOyYbLvlBijnCofqsWT22PA63SrtH7rMpAIRXKnGZoMbVXQzLMJ5nfCd1FS Yf9i5E66xedcgJwcwvQM7Xe6mDKAHgEZJRoGOlXKB33Djk8hontSOvlIw3bstpnD+8wN kx9LwEwl0iAueway3v/KsBf+lWt2DLX3iX8NIu+Dc5WcVlgWgw9WNLLLk3r0Wf94hpkd XgL/o0HFT6QDNl0eE7JX+tw9cqmAKaQyVqTIFKnkQTDcrtl+TzCo9mOE8S0qYOKX4Kk1 Q/fsQCMVK5qClKG6G8AuAB4qrGA7k1p4FwD4+VadDQ9revb3xrrqP7Ak5xY1wqTIPhSC FKpw== X-Forwarded-Encrypted: i=1; AJvYcCVsM/BZ0i/ooVO7SRfg3ckX/AgOI3SSxwWZ+rFsreGgU0SILbp09eERvJ/SD13yUSmPWwP9hgltWLBAjzc=@vger.kernel.org X-Gm-Message-State: AOJu0YyugTDfkSA94D+JXx8bGs0gFVNBsszeTbZMEyeaea/uSZS5SDRE 8x2i4V+YmlBboAeGho5apindIwdlVDpTvPCGoenWQr8/KAHB4VCXjn7BZkg87EY= X-Gm-Gg: ASbGncu6QoLrGgI1bLC3VupZnp0grcUJXYew4gPXhaXBQAMqR+3oXJp9Lic7awORtfk jQSIckDH8IqZ+Id3TX3oURnHYUj5/bCKYzmS9vmz2T67zIO6WYzIe36YughcsbO7fa6dxu62ysq tseDZBNhu4IhK7hJt489S3XNFgtA3ioDjWw8n2CU8uUPUpxltxscRPI04zGfWnttv6heH9JpwHW va6xPOujnxf/20zswkM9jUszW4oMZmoL3sJIFenQvXayGJ+hfwpIyJGPJWPf82JXf58+5m/jymI 5zRl0oQzHMwr9Q== X-Google-Smtp-Source: AGHT+IFgeqqkJ6wjR9SgxT1xrYJ0KahQXa7sIHvXaict/TpEQq8UBgqk2qQhjj3zdFl3pgNOycsAVA== X-Received: by 2002:a05:6000:1866:b0:382:4a3b:5139 with SMTP id ffacd0b85a97d-38260bed0dcmr13711723f8f.59.1732616970162; Tue, 26 Nov 2024 02:29:30 -0800 (PST) Received: from [192.168.0.172] (88-127-185-239.subs.proxad.net. [88.127.185.239]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-433cde8c804sm159339195e9.30.2024.11.26.02.29.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Nov 2024 02:29:29 -0800 (PST) Message-ID: Date: Tue, 26 Nov 2024 11:29:28 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/1] ASoc: mediatek: mt8365: Don't use "proxy" headers To: Andy Shevchenko Cc: Mark Brown , Nicolas Belin , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Matthias Brugger , AngeloGioacchino Del Regno References: <20241031102725.2447711-1-andriy.shevchenko@linux.intel.com> Content-Language: en-US From: Alexandre Mergnat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Andy On 25/11/2024 12:50, Andy Shevchenko wrote: > On Mon, Nov 25, 2024 at 12:32:13PM +0100, Alexandre Mergnat wrote: >> Hello Andy. >> >> Actually, after test it, "linux/of_gpio.h" isn't needed at all anymore. >> >> That mean all added include in this patch aren't required. > Do you mean the driver doesn't not use types from types.h or dev_*() macros > from dev_printk.h? I don't believe this, sorry. > > Basically what you are trying to say is "let's move of_gpio.h implicit > includes to become something else's problem". It's not what this patch > intended to do. I'm just saying that I've test a build/boot with "linux/of_gpio.h" removed and without all include added in you patch. My understand is "linux/of_gpio.h" act as proxy for the includes added in your patch, my first idea was "if I remove it, build should fail cause of lack of other includes". I can understand these missing includes are mandatory, that probably means there is another proxy header ? Maybe my test isn't consistent because it isn't possible to clear all proxy ? If that's the case, consider my review-by. I've validated some include manually. Are you using a script to parse the file and raise all necessary "linux/*" include ? -- Regards, Alexandre