From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F5E03B19AE for ; Mon, 29 Jun 2026 07:05:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782716707; cv=none; b=To85GGPKTX7KKmN/Cr4i4/87NXSfc8mCfTQVMlPs5RQmiHSlGmnODf2QTS7G4IIE4AAE5S3gHmW9UAl6InGf0ivV3LcH6SC/NYpoKI7wmBEepdiaTOV5R9tYHMG0CBWaoFQw7Pr7t5lTwHPB+dl7//47XFRPGyyFvs5h742zz8M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782716707; c=relaxed/simple; bh=SWnr9Eln3PiSeTE/U/NySmFTNG+pnN8jB2pyu4MN3rg=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=l3WdfXqDq8uVSB/VIQSomlwtV7ZrI8k2Pl+x0j8dv4Jtc0g36a2tBuDsS8rc5+hPfTyJaWsqnz2n+ALoY1pnU3sodCTsKh6fQf5KuKAcDuvZrWyqxR1tmhoANElNq6wauni/QNSz0JTyreVurNCZiewA7qAjMcaifWEvFTDXuEU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=OYw6NA7U; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=MYiS39Jt; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="OYw6NA7U"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="MYiS39Jt" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1782716705; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ApRfeIMP2d5U5s8s5CxROo3JDafbwy3URSsiSmHVeIE=; b=OYw6NA7UR+eMjvG7jPjyOzV4vaHqIj1L7jM2f67ZbZ0ohkkICJwzMmyKeUSzf+EHxMmZqL j4oIpwlwRs9NOBBjqkKTsLtexuOSGHl2/XiSTx0BnfHOL8kShyQ6yWIxNh8x5+XQO10394 Nfto/GU2HjZ4XtLELEZ1KzHAjnJhfyQ= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-673-l-X31yZYPRWGmnBUyeqTYw-1; Mon, 29 Jun 2026 03:05:03 -0400 X-MC-Unique: l-X31yZYPRWGmnBUyeqTYw-1 X-Mimecast-MFC-AGG-ID: l-X31yZYPRWGmnBUyeqTYw_1782716702 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-473e18559b2so246351f8f.0 for ; Mon, 29 Jun 2026 00:05:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1782716702; x=1783321502; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=ApRfeIMP2d5U5s8s5CxROo3JDafbwy3URSsiSmHVeIE=; b=MYiS39JtL7I7FbH9G0MGw2HTf+On/ClEOy78LflU08VpeUqU/T22FtNykYI4ShLrXc ZUjYzkaLBAwHi6m/jmW2/FbqItbxcEhV/gEyIkVinqznxD5ddXbqY5o3z21q1NBOZ6Dj 434eU1Gm17J1tcnNHKw0AEAUcJN3D2Mp0D54iMKRlqCVJmHi6vUCRcornVfJ+dG23ZVy 5YjhldkSAy8dYoKvu/XuSmNEDQimqvJZq7SiNmaGkPIdo5KQWbUPdxBflgyYEMl/XV0G BPTbocc/k0Tlz7BnQPpNhN7n7TD0XPJRRzDohzkkAC4+dwL0pRe8hcARnhQ82/5VAOzh X20w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782716702; x=1783321502; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ApRfeIMP2d5U5s8s5CxROo3JDafbwy3URSsiSmHVeIE=; b=rUAy9lAfP3Ovk0UodP1OiltpsEUvtxJvscT3Q685khEfeDbIzdP7VPIj6GipO0suNq 9ypmk7NVLO/tcYmmQcsGIHG9iFzP9M37LPQtc74vL7vuhw9cts8jxQTlqwT3wBy2S/OP hKlsz/o0+0dEjzjWU2J0l93fTPY66/IyeyiFWVVxGPG7zeiEMhjh7kEtPCo4dQJogSQ2 rM8XSoOXflgdebmX5Ff2mxOraf1MfrgFE22UF5x6yj0QdLh3ZLnGriVwyIc3hThyYL9e MSVNSlojPCpa32+MnmVaNSuQXqr/oqXs/epI87ePInyg373X/paO7X4NuWTkWM+pD+SC Le8w== X-Forwarded-Encrypted: i=1; AHgh+RqSzh9oIeHPs32MBsDYfMzC0USldd685Xe6dXHIY9G1im1r6kAZlQ7eDAsW0OzGZf03ZQfzLgeg7Mk3jWU=@vger.kernel.org X-Gm-Message-State: AOJu0Yx50UUr5LPcXE28h1B8iA+MaWPmIhzBmWj6zyGxb7Sv2iPIaPoG 8fdVHUQQkpYnX56IR8HKvzipb6L7BUK8mazsrAKd3/iklkXH84/XwLL/OC67Z1Dg0DQ9gi5a2jR shhKwkoaWfSCk0+GyQGjab8SO7B+kA8GSpnnoi5XZImyskYwxKl9HrVaybC4Aw/ihvA== X-Gm-Gg: AfdE7cmW6NXDuPI1b17ajheAix+tRvk7juLOuriRpAMJ8Ne+Vx6y3LlLM/ogfPiUJwg /08jj99T5XQnaMmB3CLLC7pJMDp8If2Wnfa+vPV6YxegcP50hewejYb6vfVuKs1mHeLUiAQrlFJ uH0NVWG+jX+Bo9mBPdA65UzuvnyTI2m3isjlu7Y4FxH7gzsYoBVDWV1/2Fc6h2AGXu83w21sTW8 90IdpFNWit6eu98al8YskSKAtBLWChrPcurByJ+7jz/w8MLnZaLJSRUdsEX4/SLdTlWgfaIvqRW Fctu+xYiIjmjDowseylrB4lDCBGbPX8yeiKC2rIdwbTaunfz70z1Cx4vBQiijGadGKNSmDe/MPV 8EbrBcDBNSl9MBsO/HAvjYcxX+NaMc1w24KeoArP5hJuauqdPIsdv3XVlPmuJxYVYsxkzKMPoJ/ sFolEI X-Received: by 2002:a05:6000:2283:b0:473:1ccc:15bf with SMTP id ffacd0b85a97d-4731ccc1722mr5730466f8f.42.1782716702428; Mon, 29 Jun 2026 00:05:02 -0700 (PDT) X-Received: by 2002:a05:6000:2283:b0:473:1ccc:15bf with SMTP id ffacd0b85a97d-4731ccc1722mr5730418f8f.42.1782716701970; Mon, 29 Jun 2026 00:05:01 -0700 (PDT) Received: from gmonaco-thinkpadt14gen3.rmtit.csb (212-8-243-115.hosted-by-worldstream.net. [212.8.243.115]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-46f978dc0a9sm23663882f8f.15.2026.06.29.00.04.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2026 00:04:59 -0700 (PDT) Message-ID: Subject: Re: [PATCH v3 14/17] verification/rvgen: Add selftests for rvgen kunit From: Gabriele Monaco To: Wen Yang , linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Nam Cao , Steven Rostedt , Thomas Weissschuh , Tomas Glozar , John Kacur Date: Mon, 29 Jun 2026 09:04:57 +0200 In-Reply-To: <53f2d13c-cc1d-48fd-95f0-2c1ff1edfc88@linux.dev> References: <20260625121440.116317-1-gmonaco@redhat.com> <20260625121440.116317-15-gmonaco@redhat.com> <53f2d13c-cc1d-48fd-95f0-2c1ff1edfc88@linux.dev> Autocrypt: addr=gmonaco@redhat.com; prefer-encrypt=mutual; keydata=mDMEZuK5YxYJKwYBBAHaRw8BAQdAmJ3dM9Sz6/Hodu33Qrf8QH2bNeNbOikqYtxWFLVm0 1a0JEdhYnJpZWxlIE1vbmFjbyA8Z21vbmFjb0BrZXJuZWwub3JnPoiZBBMWCgBBFiEEysoR+AuB3R Zwp6j270psSVh4TfIFAmjKX2MCGwMFCQWjmoAFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgk Q70psSVh4TfIQuAD+JulczTN6l7oJjyroySU55Fbjdvo52xiYYlMjPG7dCTsBAMFI7dSL5zg98I+8 cXY1J7kyNsY6/dcipqBM4RMaxXsOtCRHYWJyaWVsZSBNb25hY28gPGdtb25hY29AcmVkaGF0LmNvb T6InAQTFgoARAIbAwUJBaOagAULCQgHAgIiAgYVCgkICwIEFgIDAQIeBwIXgBYhBMrKEfgLgd0WcK eo9u9KbElYeE3yBQJoymCyAhkBAAoJEO9KbElYeE3yjX4BAJ/ETNnlHn8OjZPT77xGmal9kbT1bC1 7DfrYVISWV2Y1AP9HdAMhWNAvtCtN2S1beYjNybuK6IzWYcFfeOV+OBWRDQ== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.60.1 (3.60.1-1.fc44) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2026-06-29 at 01:06 +0800, Wen Yang wrote: > On 6/25/26 20:14, Gabriele Monaco wrote: > > +static void handle_example_event(void *data, /* XXX: fill header */) > > +{ > > + ltl_atom_update(task, LTL_EVENT_A, true/false); > > +} > > + > > +static int enable_test_ltl_kunit(void) > > +{ > > + int retval; > > + > > + retval =3D ltl_monitor_init(); > > + if (retval) > > + return retval; > > + > > + rv_attach_trace_probe("test_ltl_kunit", /* XXX: tracepoint */, > > handle_example_event); > > + > > + return 0; > > +} > > + > > +static void disable_test_ltl_kunit(void) > > +{ > > + rv_detach_trace_probe("test_ltl_kunit", /* XXX: tracepoint */, > > handle_sample_event); > > + >=20 > one typo: > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 handle_sample_event should be = handle_example_event. Keep in mind that those files are not ready to build, users need to touch them anyway after generation from rvgen. Nevertheless, this has been inconsistent for a while and I should fix it. > > + ltl_monitor_destroy(); > > +} ... > > +MODULE_LICENSE("GPL"); > > +MODULE_AUTHOR(/* TODO */); >=20 > Please use a valid string here. Likewise, this is not supposed to build, we are just validating what rvgen produces and that's the expected output, the user will need to fill it with an appropriate string. LTL uses a different approach compared to DA/HA in this template, I'm not sure it's worth aligning the two.. Thanks, Gabriele > > +MODULE_DESCRIPTION("test_ltl_kunit: auto-generated");